Skip to content

armgit / Pulse

Public Imported from GitHub
0

Real-time monitoring dashboard for Proxmox VE, PBS, Docker, Kubernetes, TrueNAS and vSphere. Self-hosted, with alerts for failed backups, full disks, unhealthy containers and offline nodes.

Keep frontend graph controls bound to their build producer

pulse-triage[bot]feb6df8f8767
diff --git a/docs/release-control/v6/internal/subsystems/deployment-installability.md b/docs/release-control/v6/internal/subsystems/deployment-installability.md
index 4b6501997a..4bd2c7b1de 100644
--- a/docs/release-control/v6/internal/subsystems/deployment-installability.md
+++ b/docs/release-control/v6/internal/subsystems/deployment-installability.md
@@ -828,7 +828,10 @@ failed, cancelled or skipped proof fails that check; only an explicit, consisten
non-runtime classification admits inapplicable checks. Each execution job retains
the 30-minute ceiling; the aggregate has a five-minute orchestration deadline.
-`frontend-build` installs the locked graph, performs the unchanged formatting,
+Before installation, `frontend-build` executes the dependency-free Solid
+serialization graph controls and checks the complete lock. Its pre-install
+ordering and unchanged strict audit are bound to this producer, not the separate
+runtime consumer. `frontend-build` installs the locked graph, performs the unchanged formatting,
lint and type checks, then builds and size-checks the production frontend. It
requires a nonempty index/assets tree and compares the complete generated
frontend and embed copy. Only that successful checkout-bound build is packed
@@ -872,7 +875,11 @@ selection failure; they do not reproduce hosted GitHub rerun/transport behaviour
in the Go install-test suite, separately from compiler/asset admission. These
controls are not real compilation. `TestFrontendCIRequiresCompleteIsolatedUnitProof`
executes the workflow-order, complete-shard and actual fail-closed audit/verdict
-controls in `scripts/tests/test_frontend_workflow_order.py`. Actual containing CI checkout/phase logs
+controls in `scripts/tests/test_frontend_workflow_order.py`, including execution
+of the actual pre-install Node test/check recipe so a stale workflow selector
+cannot escape this registered proof route. `TestFrontendDependencySecurityAuditsAreRequired`
+also binds the audit deadline and verdict to the build/audit producer.
+Actual containing CI checkout/phase logs
remain necessary before using the result as real-embed source proof; unrelated
stub builds, workflow success, releases and installed recovery remain distinct.
diff --git a/scripts/installtests/build_release_assets_test.go b/scripts/installtests/build_release_assets_test.go
index a365cfd9c9..6c0aac35c3 100644
--- a/scripts/installtests/build_release_assets_test.go
+++ b/scripts/installtests/build_release_assets_test.go
@@ -4648,9 +4648,21 @@ func TestFrontendDependencySecurityAuditsAreRequired(t *testing.T) {
if err != nil {
t.Fatalf("read %s: %v", workflowPath, err)
}
- frontendJob := workflowJobBlock(t, string(workflow), "frontend-checks")
+ frontendJob := workflowJobBlock(t, string(workflow), "frontend-build")
+ for _, needle := range []string{
+ `- name: Check Solid serialization dependency edges`,
+ `- name: Install frontend dependencies`,
+ `- name: Audit complete frontend dependency graph`,
+ `NPM_AUDIT_REQUIRE_RESULT: ${{ needs.changes.outputs.frontend_deps }}`,
+ `- name: Require frontend dependency audit`,
+ `COMPLETE_AUDIT_RESULT: ${{ steps.audit-complete.outcome }}`,
+ } {
+ if !strings.Contains(frontendJob, needle) {
+ t.Fatalf("frontend build/audit producer missing %s", needle)
+ }
+ }
if !strings.Contains(frontendJob, "timeout-minutes: 30") {
- t.Fatal("frontend job must keep a bounded timeout above the audit budget")
+ t.Fatal("frontend build/audit producer must keep a bounded timeout above the audit budget")
}
}
diff --git a/scripts/tests/check-frontend-serialization.test.mjs b/scripts/tests/check-frontend-serialization.test.mjs
index b34b17c07a..d964f1384e 100644
--- a/scripts/tests/check-frontend-serialization.test.mjs
+++ b/scripts/tests/check-frontend-serialization.test.mjs
@@ -172,8 +172,8 @@ test('prereleases and malformed locked versions cannot claim compatibility', ()
test('CI fails the graph check before installation without relaxing the audit', () => {
const workflow = readFileSync(new URL('../../.github/workflows/build-and-test.yml', import.meta.url), 'utf8');
- const job = /\n frontend-checks:\n([\s\S]*?)(?=\n [\w-]+:\n|$)/.exec(workflow);
- assert.ok(job, 'the build/audit/runtime job must contain the graph check');
+ const job = /\n frontend-build:\n([\s\S]*?)(?=\n [\w-]+:\n|$)/.exec(workflow);
+ assert.ok(job, 'the build/audit producer must contain the graph check');
const frontend = job[1];
const check = frontend.indexOf('- name: Check Solid serialization dependency edges');
const install = frontend.indexOf('- name: Install frontend dependencies');
diff --git a/scripts/tests/test_frontend_workflow_order.py b/scripts/tests/test_frontend_workflow_order.py
index 118e730606..ad54c22800 100644
--- a/scripts/tests/test_frontend_workflow_order.py
+++ b/scripts/tests/test_frontend_workflow_order.py
@@ -25,6 +25,24 @@ class FrontendWorkflowOrderTest(unittest.TestCase):
self.assertEqual(len(matches), 1, f"expected one {name} step")
return matches[0]
+ def test_preinstall_serialization_step_runs_its_registered_graph_controls(self):
+ # Run the actual dependency-free pre-install recipe, not just the
+ # Python workflow assertions. Its Node controls also read this workflow
+ # and must follow the producer when build and runtime jobs are split.
+ # Otherwise a stale job selector can pass local proof and stop CI before
+ # npm installation, leaving all expensive proof inapplicable.
+ check = self.step("Check Solid serialization dependency edges")
+ self.assertEqual(check, {
+ "name": "Check Solid serialization dependency edges",
+ "run": "node --test scripts/tests/check-frontend-serialization.test.mjs\n"
+ "node scripts/check-frontend-serialization.mjs\n",
+ })
+ names = [step.get("name") for step in self.steps]
+ self.assertLess(names.index(check["name"]), names.index("Install frontend dependencies"))
+ result = subprocess.run(["bash", "-e", "-u", "-o", "pipefail", "-c", check["run"]],
+ cwd=ROOT, text=True, capture_output=True, timeout=15)
+ self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
+
def test_type_build_and_size_admit_the_unit_suite_in_order(self):
names = [step.get("name") for step in self.steps]
ordered = [