Skip to content

Create polished demo videos without editing skills. Mac/Windows/Linux

refactor: remove NO_BACKGROUND references and related code for cleaner background handling

Lawrence0aecbe897a14
diff --git a/src/components/video-editor/SettingsPanel.tsx b/src/components/video-editor/SettingsPanel.tsx
index f8b9b216..f5f15cf6 100644
--- a/src/components/video-editor/SettingsPanel.tsx
+++ b/src/components/video-editor/SettingsPanel.tsx
@@ -1,7 +1,7 @@
import { cn } from "@/lib/utils";
import { useEffect, useRef } from "react";
import { getAssetPath, getRenderableAssetUrl } from "@/lib/assetPath";
-import { BUILT_IN_WALLPAPERS, NO_BACKGROUND, WALLPAPER_PATHS, WALLPAPER_RELATIVE_PATHS } from "@/lib/wallpapers";
+import { BUILT_IN_WALLPAPERS, WALLPAPER_PATHS, WALLPAPER_RELATIVE_PATHS } from "@/lib/wallpapers";
import { SliderControl } from "./SliderControl";
import { Switch } from "@/components/ui/switch";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
@@ -631,32 +631,14 @@ export function SettingsPanel({
accept=".jpg,.jpeg,image/jpeg"
className="hidden"
/>
- <div className="flex gap-1.5">
- <div
- className={cn(
- "aspect-square w-9 h-9 rounded-md border-2 overflow-hidden cursor-pointer transition-all duration-200 shadow-sm flex items-center justify-center",
- selected === NO_BACKGROUND
- ? "border-[#2563EB] ring-1 ring-[#2563EB]/30"
- : "border-white/10 hover:border-[#2563EB]/40 opacity-80 hover:opacity-100"
- )}
- style={{
- backgroundImage: 'repeating-conic-gradient(#555 0% 25%, #333 0% 50%)',
- backgroundSize: '8px 8px',
- }}
- aria-label={tSettings('background.none')}
- title={tSettings('background.none')}
- onClick={() => onWallpaperChange(NO_BACKGROUND)}
- role="button"
- />
- <Button
- onClick={() => fileInputRef.current?.click()}
- variant="outline"
- className="flex-1 gap-2 bg-white/5 text-slate-200 border-white/10 hover:bg-[#2563EB] hover:text-white hover:border-[#2563EB] transition-all h-7 text-[10px]"
- >
- <Upload className="w-3 h-3" />
- {tSettings('background.uploadCustom')}
- </Button>
- </div>
+ <Button
+ onClick={() => fileInputRef.current?.click()}
+ variant="outline"
+ className="w-full gap-2 bg-white/5 text-slate-200 border-white/10 hover:bg-[#2563EB] hover:text-white hover:border-[#2563EB] transition-all h-7 text-[10px]"
+ >
+ <Upload className="w-3 h-3" />
+ {tSettings('background.uploadCustom')}
+ </Button>
<div className="grid grid-cols-7 gap-1.5">
{customImages.map((imageUrl, idx) => {
diff --git a/src/components/video-editor/VideoPlayback.tsx b/src/components/video-editor/VideoPlayback.tsx
index 36313d84..6c5b7f0d 100644
--- a/src/components/video-editor/VideoPlayback.tsx
+++ b/src/components/video-editor/VideoPlayback.tsx
@@ -1,7 +1,7 @@
import type React from "react";
import { useEffect, useRef, useImperativeHandle, forwardRef, useState, useMemo, useCallback } from "react";
import { getAssetPath, getRenderableAssetUrl } from "@/lib/assetPath";
-import { DEFAULT_WALLPAPER_PATH, DEFAULT_WALLPAPER_RELATIVE_PATH, NO_BACKGROUND } from "@/lib/wallpapers";
+import { DEFAULT_WALLPAPER_PATH, DEFAULT_WALLPAPER_RELATIVE_PATH } from "@/lib/wallpapers";
import { Application, Container, Sprite, Graphics, BlurFilter, Texture, VideoSource } from 'pixi.js';
import { MotionBlurFilter } from 'pixi-filters/motion-blur';
import { ZOOM_DEPTH_SCALES, type ZoomRegion, type ZoomFocus, type ZoomDepth, type TrimRegion, type SpeedRegion, type AnnotationRegion, type CursorTelemetryPoint } from "./types";
@@ -1024,13 +1024,10 @@ const VideoPlayback = forwardRef<VideoPlaybackRef, VideoPlaybackProps>(({
};
}, [])
- const isNoBackground = wallpaper === NO_BACKGROUND;
const isImageUrl = Boolean(resolvedWallpaper && (resolvedWallpaper.startsWith('file://') || resolvedWallpaper.startsWith('http') || resolvedWallpaper.startsWith('/') || resolvedWallpaper.startsWith('data:')))
- const backgroundStyle = isNoBackground
- ? {}
- : isImageUrl
- ? { backgroundImage: `url(${resolvedWallpaper || ''})` }
- : { background: resolvedWallpaper || '' };
+ const backgroundStyle = isImageUrl
+ ? { backgroundImage: `url(${resolvedWallpaper || ''})` }
+ : { background: resolvedWallpaper || '' };
const nativeAspectRatio = (() => {
const locked = lockedVideoDimensionsRef.current;
@@ -1049,10 +1046,7 @@ const VideoPlayback = forwardRef<VideoPlaybackRef, VideoPlaybackProps>(({
{/* Background layer */}
<div
className="absolute inset-0 bg-cover bg-center"
- style={isNoBackground ? {
- backgroundImage: 'repeating-conic-gradient(#3a3a3a 0% 25%, #222 0% 50%)',
- backgroundSize: '16px 16px',
- } : {
+ style={{
...backgroundStyle,
filter: backgroundBlur > 0 ? `blur(${backgroundBlur}px)` : 'none',
}}
diff --git a/src/i18n/locales/en/settings.json b/src/i18n/locales/en/settings.json
index b0d7121d..2ffb67f0 100644
--- a/src/i18n/locales/en/settings.json
+++ b/src/i18n/locales/en/settings.json
@@ -34,7 +34,6 @@
},
"background": {
"title": "Background",
- "none": "None",
"image": "Image",
"color": "Color",
"gradient": "Gradient",
diff --git a/src/i18n/locales/es/settings.json b/src/i18n/locales/es/settings.json
index 9f35964d..335bb00d 100644
--- a/src/i18n/locales/es/settings.json
+++ b/src/i18n/locales/es/settings.json
@@ -34,7 +34,6 @@
},
"background": {
"title": "Fondo",
- "none": "Ninguno",
"image": "Imagen",
"color": "Color",
"gradient": "Degradado",
diff --git a/src/i18n/locales/zh-CN/settings.json b/src/i18n/locales/zh-CN/settings.json
index f3854608..5e2ef5bb 100644
--- a/src/i18n/locales/zh-CN/settings.json
+++ b/src/i18n/locales/zh-CN/settings.json
@@ -34,7 +34,6 @@
},
"background": {
"title": "背景",
- "none": "无",
"image": "图片",
"color": "颜色",
"gradient": "渐变",
diff --git a/src/lib/exporter/frameRenderer.ts b/src/lib/exporter/frameRenderer.ts
index 8805ef1a..65dc925d 100644
--- a/src/lib/exporter/frameRenderer.ts
+++ b/src/lib/exporter/frameRenderer.ts
@@ -8,7 +8,6 @@ import { applyZoomTransform, computeFocusFromTransform, computeZoomTransform, cr
import { DEFAULT_FOCUS, ZOOM_SCALE_DEADZONE, ZOOM_TRANSLATION_DEADZONE_PX } from '@/components/video-editor/videoPlayback/constants';
import { renderAnnotations } from './annotationRenderer';
import { PixiCursorOverlay, DEFAULT_CURSOR_CONFIG, preloadCursorAssets } from '@/components/video-editor/videoPlayback/cursorRenderer';
-import { NO_BACKGROUND } from '@/lib/wallpapers';
interface FrameRenderConfig {
width: number;
@@ -188,11 +187,6 @@ export class FrameRenderer {
private async setupBackground(): Promise<void> {
const wallpaper = await this.resolveWallpaperForExport(this.config.wallpaper);
- // No background requested — leave the composite canvas transparent
- if (this.config.wallpaper === NO_BACKGROUND) {
- return;
- }
-
// Create background canvas for separate rendering (not affected by zoom)
const bgCanvas = document.createElement('canvas');
bgCanvas.width = this.config.width;
@@ -621,7 +615,7 @@ export class FrameRenderer {
} else {
ctx.drawImage(bgCanvas, 0, 0, w, h);
}
- } else if (this.config.wallpaper !== NO_BACKGROUND) {
+ } else {
console.warn('[FrameRenderer] No background sprite found during compositing!');
}
diff --git a/src/lib/wallpapers.ts b/src/lib/wallpapers.ts
index 7b6be16f..4540fe6c 100644
--- a/src/lib/wallpapers.ts
+++ b/src/lib/wallpapers.ts
@@ -35,6 +35,3 @@ export const WALLPAPER_PATHS = BUILT_IN_WALLPAPERS.map((wallpaper) => wallpaper.
export const WALLPAPER_RELATIVE_PATHS = BUILT_IN_WALLPAPERS.map((wallpaper) => wallpaper.relativePath);
export const DEFAULT_WALLPAPER_PATH = WALLPAPER_PATHS[0];
export const DEFAULT_WALLPAPER_RELATIVE_PATH = WALLPAPER_RELATIVE_PATHS[0];
-
-/** Sentinel value indicating no background should be rendered. */
-export const NO_BACKGROUND = 'none';