Skip to content

Create polished demo videos without editing skills. Mac/Windows/Linux

fix(audio): Enforce strict 100% volume ceiling for all audio tracks

Alan Trebugeais2d4ee6e0d474
diff --git a/src/components/video-editor/audio/useClipAudioSettingsController.ts b/src/components/video-editor/audio/useClipAudioSettingsController.ts
index 08ad0d5e..924d8652 100644
--- a/src/components/video-editor/audio/useClipAudioSettingsController.ts
+++ b/src/components/video-editor/audio/useClipAudioSettingsController.ts
@@ -63,7 +63,7 @@ export function useClipAudioSettingsController({
normalize: false,
};
const normalizeGain = settings.normalize ? SOURCE_AUDIO_NORMALIZE_GAIN : 1;
- return Math.max(0, Math.min(2, settings.volume * normalizeGain));
+ return Math.max(0, Math.min(1, settings.volume * normalizeGain));
}, [embeddedTrackId, previewSourceAudioTrackSettings]);
const getSourceTrackPreviewGain = useCallback(
@@ -74,7 +74,7 @@ export function useClipAudioSettingsController({
normalize: false,
};
const normalizeGain = settings.normalize ? SOURCE_AUDIO_NORMALIZE_GAIN : 1;
- return Math.max(0, Math.min(2, settings.volume * normalizeGain));
+ return Math.max(0, Math.min(1, settings.volume * normalizeGain));
},
[previewSourceAudioTrackSettings],
);
diff --git a/src/components/video-editor/audio/useSourceAudioTrackSettings.ts b/src/components/video-editor/audio/useSourceAudioTrackSettings.ts
index 22688534..9f126853 100644
--- a/src/components/video-editor/audio/useSourceAudioTrackSettings.ts
+++ b/src/components/video-editor/audio/useSourceAudioTrackSettings.ts
@@ -116,7 +116,7 @@ export function useSourceAudioTrackSettings({
setSourceAudioTrackSettingsByClip((prev) => {
const prevClip = prev[selectedClipId] ?? defaultSourceAudioTrackSettings;
const nextVolume = Number.isFinite(volume)
- ? Math.max(0, Math.min(2, volume))
+ ? Math.max(0, Math.min(1, volume))
: (prevClip[id]?.volume ?? 1);
const prevNormalize = prevClip[id]?.normalize ?? false;
if (
diff --git a/src/components/video-editor/timeline/components/viewport/TimelineCanvas.tsx b/src/components/video-editor/timeline/components/viewport/TimelineCanvas.tsx
index 736a6d6e..17b242f4 100644
--- a/src/components/video-editor/timeline/components/viewport/TimelineCanvas.tsx
+++ b/src/components/video-editor/timeline/components/viewport/TimelineCanvas.tsx
@@ -278,7 +278,7 @@ function AudioItemWithWaveform({
variant="audio"
waveformPeaks={peaks}
waveformSegmentSpan={normalizedWaveformSpan}
- waveformGain={Math.max(0, Math.min(2, item.audioGain ?? 1))}
+ waveformGain={Math.max(0, Math.min(1, item.audioGain ?? 1))}
waveformNormalize={Boolean(item.audioNormalize)}
>
{item.label}
@@ -405,7 +405,7 @@ const TimelineCanvasRows = memo(function TimelineCanvasRows({
variant="audio"
waveformPeaks={track.peaks}
waveformSegmentSpan={item.sourceSpan ?? item.span}
- waveformGain={Math.max(0, Math.min(2, settings.volume))}
+ waveformGain={Math.max(0, Math.min(1, settings.volume))}
waveformNormalize={Boolean(settings.normalize)}
muted={item.muted}
>