Skip to content

Create polished demo videos without editing skills. Mac/Windows/Linux

fix: parsing of window ID was not done. Hence why it couldn't record something other than the entire screen.

Alan Trebugeais3e3e76f2c992
diff --git a/electron/ipc/register/recording.ts b/electron/ipc/register/recording.ts
index f2cb6660..9e9e6e96 100644
--- a/electron/ipc/register/recording.ts
+++ b/electron/ipc/register/recording.ts
@@ -412,6 +412,9 @@ export function registerRecordingHandlers(
let orphanedMicAudioPath: string | null = null;
const browserMicFallbackRequested =
shouldStartWindowsBrowserMicrophoneFallback(options);
+ const windowId = parseWindowId(source?.id);
+ const isWindowCapture = Boolean(windowId && source?.id?.startsWith("window:"));
+
const resolvedDisplay = resolveWindowsCaptureDisplay(
source,
getScreen().getAllDisplays(),
@@ -423,13 +426,18 @@ export function registerRecordingHandlers(
const config: Record<string, unknown> = {
outputPath,
fps: 60,
- displayId: resolvedDisplay.displayId,
- displayX: Math.round(resolvedDisplay.bounds.x),
- displayY: Math.round(resolvedDisplay.bounds.y),
- displayW: Math.round(resolvedDisplay.bounds.width),
- displayH: Math.round(resolvedDisplay.bounds.height),
};
+ if (isWindowCapture) {
+ config.windowHandle = windowId;
+ } else {
+ config.displayId = resolvedDisplay.displayId;
+ config.displayX = Math.round(resolvedDisplay.bounds.x);
+ config.displayY = Math.round(resolvedDisplay.bounds.y);
+ config.displayW = Math.round(resolvedDisplay.bounds.width);
+ config.displayH = Math.round(resolvedDisplay.bounds.height);
+ }
+
if (options?.capturesSystemAudio) {
systemAudioPath = path.join(
recordingsDir,