Create polished demo videos without editing skills. Mac/Windows/Linux
revert: undo linux cursor-overlay portal guards
webadderall5717fd60fcfd
diff --git a/electron/electron-env.d.ts b/electron/electron-env.d.tsindex c5958754..a3f663f2 100644--- a/electron/electron-env.d.ts+++ b/electron/electron-env.d.ts@@ -676,7 +676,6 @@ interface Window {options?: {preserveProjectPath?: boolean;hideOverlayCursorByDefault?: boolean;- nativeCaptureUnavailable?: boolean;},) => Promise<{ success: boolean; webcamPath: string | null }>;setCurrentRecordingSession: (@@ -685,7 +684,6 @@ interface Window {webcamPath?: string | null;timeOffsetMs?: number;hideOverlayCursorByDefault?: boolean;- nativeCaptureUnavailable?: boolean;},options?: { preserveProjectPath?: boolean },) => Promise<{ success: boolean }>;@@ -696,7 +694,6 @@ interface Window {webcamPath?: string | null;timeOffsetMs?: number;hideOverlayCursorByDefault?: boolean;- nativeCaptureUnavailable?: boolean;};}>;getCurrentVideoPath: () => Promise<{ success: boolean; path?: string }>;@@ -842,11 +839,7 @@ interface Window {/** Returns the app version from package.json */getAppVersion: () => Promise<string>;/** Hide the OS cursor before browser capture starts. */- hideOsCursor: () => Promise<{- success: boolean;- unsupported?: boolean;- platform?: string;- }>;+ hideOsCursor: () => Promise<{ success: boolean }>;/** Recording preferences (mic, system audio) */getRecordingPreferences: () => Promise<{success: boolean;diff --git a/electron/ipc/register/project.ts b/electron/ipc/register/project.tsindex 7af983b0..a65fd907 100644--- a/electron/ipc/register/project.ts+++ b/electron/ipc/register/project.ts@@ -533,7 +533,7 @@ export function registerProjectHandlers() {return { success: false, error: String(error), message: 'Failed to open projects folder.' }}})- ipcMain.handle('set-current-video-path', async (_, path: string, options?: { preserveProjectPath?: boolean; hideOverlayCursorByDefault?: boolean; nativeCaptureUnavailable?: boolean }) => {+ ipcMain.handle('set-current-video-path', async (_, path: string, options?: { preserveProjectPath?: boolean; hideOverlayCursorByDefault?: boolean }) => {setCurrentVideoPath(normalizeVideoSourcePath(path) ?? path)approveUserPath(currentVideoPath)const resolvedSession = await resolveRecordingSession(currentVideoPath)@@ -548,10 +548,6 @@ export function registerProjectHandlers() {hideOverlayCursorByDefault:normalizeBoolean(options?.hideOverlayCursorByDefault) ||normalizeBoolean(resolvedSession.hideOverlayCursorByDefault),- nativeCaptureUnavailable:- normalizeBoolean(- options?.nativeCaptureUnavailable ?? resolvedSession.nativeCaptureUnavailable,- ),}setCurrentRecordingSession(nextSession)@@ -577,7 +573,7 @@ export function registerProjectHandlers() {return { success: true, webcamPath: nextSession.webcamPath ?? null }})- ipcMain.handle('set-current-recording-session', async (_, session: { videoPath: string; webcamPath?: string | null; timeOffsetMs?: number; hideOverlayCursorByDefault?: boolean; nativeCaptureUnavailable?: boolean }, options?: { preserveProjectPath?: boolean }) => {+ ipcMain.handle('set-current-recording-session', async (_, session: { videoPath: string; webcamPath?: string | null; timeOffsetMs?: number; hideOverlayCursorByDefault?: boolean }, options?: { preserveProjectPath?: boolean }) => {const normalizedVideoPath = normalizeVideoSourcePath(session.videoPath) ?? session.videoPathsetCurrentVideoPath(normalizedVideoPath)setCurrentRecordingSession({@@ -585,7 +581,6 @@ export function registerProjectHandlers() {webcamPath: normalizeVideoSourcePath(session.webcamPath ?? null),timeOffsetMs: normalizeRecordingTimeOffsetMs(session.timeOffsetMs),hideOverlayCursorByDefault: normalizeBoolean(session.hideOverlayCursorByDefault),- nativeCaptureUnavailable: normalizeBoolean(session.nativeCaptureUnavailable),});await rememberApprovedLocalReadPath(currentRecordingSession!.videoPath)await rememberApprovedLocalReadPath(currentRecordingSession!.webcamPath)diff --git a/electron/ipc/register/settings.ts b/electron/ipc/register/settings.tsindex 5b4498a8..e84f6317 100644--- a/electron/ipc/register/settings.ts+++ b/electron/ipc/register/settings.ts@@ -114,7 +114,7 @@ export function registerSettingsHandlers() {// ---------------------------------------------------------------------------ipcMain.handle("hide-cursor", () => {if (process.platform !== "win32") {- return { success: false, unsupported: true, platform: process.platform };+ return { success: true };}return { success: hideCursor() };diff --git a/electron/ipc/types.ts b/electron/ipc/types.tsindex 9680da73..58f5425b 100644--- a/electron/ipc/types.ts+++ b/electron/ipc/types.ts@@ -48,7 +48,6 @@ export type RecordingSessionData = {webcamPath?: string | null;timeOffsetMs?: number;hideOverlayCursorByDefault?: boolean;- nativeCaptureUnavailable?: boolean;};export type PauseSegment = {diff --git a/electron/preload.ts b/electron/preload.tsindex 9943095b..04695d6b 100644--- a/electron/preload.ts+++ b/electron/preload.ts@@ -690,7 +690,6 @@ contextBridge.exposeInMainWorld("electronAPI", {options?: {preserveProjectPath?: boolean;hideOverlayCursorByDefault?: boolean;- nativeCaptureUnavailable?: boolean;},) => {return ipcRenderer.invoke("set-current-video-path", path, options);@@ -701,7 +700,6 @@ contextBridge.exposeInMainWorld("electronAPI", {webcamPath?: string | null;timeOffsetMs?: number;hideOverlayCursorByDefault?: boolean;- nativeCaptureUnavailable?: boolean;},options?: { preserveProjectPath?: boolean },) => {diff --git a/src/components/video-editor/SettingsPanel.tsx b/src/components/video-editor/SettingsPanel.tsxindex 1a4c1955..1fa52661 100644--- a/src/components/video-editor/SettingsPanel.tsx+++ b/src/components/video-editor/SettingsPanel.tsx@@ -3587,7 +3587,6 @@ export function SettingsPanel({<Switchchecked={showCursor}onCheckedChange={onShowCursorChange}- disabled={nativeCaptureUnavailableSession}className="data-[state=checked]:bg-[#2563EB] scale-75"/></label>@@ -3596,20 +3595,11 @@ export function SettingsPanel({<Switchchecked={loopCursor}onCheckedChange={onLoopCursorChange}- disabled={nativeCaptureUnavailableSession}className="data-[state=checked]:bg-[#2563EB] scale-75"/></label></div></div>- {nativeCaptureUnavailableSession ? (- <div className="rounded-lg border border-amber-400/25 bg-amber-400/10 px-3 py-2 text-[10px] leading-4 text-muted-foreground">- {tSettings(- "effects.cursorOverlayUnavailable",- "Cursor overlay is unavailable for this recording because the captured video already contains the system cursor.",- )}- </div>- ) : null}<div className="flex flex-col gap-1.5"><div className="space-y-1.5"><ToggleGroupdiff --git a/src/components/video-editor/VideoEditor.tsx b/src/components/video-editor/VideoEditor.tsxindex 12908a6d..9ed08752 100644--- a/src/components/video-editor/VideoEditor.tsx+++ b/src/components/video-editor/VideoEditor.tsx@@ -1259,18 +1259,10 @@ export default function VideoEditor() {setExportProgress(resolveSavingExportProgress);}, []);- const handleShowCursorChange = useCallback(- (nextShowCursor: boolean) => {- if (nextShowCursor && sessionNativeCaptureUnavailable) {- setNativeCaptureUnavailableModalOpen(true);- return;- }-- setSessionShowCursorOverride(null);- setShowCursor(nextShowCursor);- },- [sessionNativeCaptureUnavailable],- );+ const handleShowCursorChange = useCallback((nextShowCursor: boolean) => {+ setSessionShowCursorOverride(null);+ setShowCursor(nextShowCursor);+ }, []);const remountPreview = useCallback(() => {setIsPreviewReady(false);diff --git a/src/hooks/useScreenRecorder.test.ts b/src/hooks/useScreenRecorder.test.tsindex 509b049b..85811467 100644--- a/src/hooks/useScreenRecorder.test.ts+++ b/src/hooks/useScreenRecorder.test.ts@@ -3,10 +3,8 @@ import { beforeEach, describe, expect, it, vi } from "vitest";import {createBrowserRecordingOptions,createProcessedMicrophoneConstraints,- getScreenCaptureCursorSetting,normalizeBrowserMicrophoneProfile,resolveBrowserCaptureCursorPolicy,- resolveLinuxPortalCursorPresentation,shouldUseNativeWindowsCaptureForSource,} from "./useScreenRecorder";@@ -147,7 +145,6 @@ describe("resolveBrowserCaptureCursorPolicy", () => {streamCursor: "never",hideOsCursorBeforeRecording: true,hideEditorOverlayCursorByDefault: true,- nativeCaptureUnavailable: false,});});@@ -158,64 +155,8 @@ describe("resolveBrowserCaptureCursorPolicy", () => {streamCursor: "always",hideOsCursorBeforeRecording: false,hideEditorOverlayCursorByDefault: true,- nativeCaptureUnavailable: true,});});-- it("does not fake OS cursor hiding on Linux portal capture", () => {- expect(resolveBrowserCaptureCursorPolicy({ platform: "linux" })).toEqual({- streamCursor: "never",- hideOsCursorBeforeRecording: false,- hideEditorOverlayCursorByDefault: true,- nativeCaptureUnavailable: true,- });- });-});--describe("resolveLinuxPortalCursorPresentation", () => {- it("enables the Recordly overlay only when the portal confirms cursor-hidden capture", () => {- expect(- resolveLinuxPortalCursorPresentation({- requestedCursor: "never",- actualCursor: "never",- }),- ).toEqual({- hideEditorOverlayCursorByDefault: false,- nativeCaptureUnavailable: false,- });- });-- it("keeps the overlay disabled when the portal embeds or omits cursor settings", () => {- expect(- resolveLinuxPortalCursorPresentation({- requestedCursor: "never",- actualCursor: "always",- }),- ).toEqual({- hideEditorOverlayCursorByDefault: true,- nativeCaptureUnavailable: true,- });- expect(- resolveLinuxPortalCursorPresentation({- requestedCursor: "never",- actualCursor: null,- }),- ).toEqual({- hideEditorOverlayCursorByDefault: true,- nativeCaptureUnavailable: true,- });- });-});--describe("getScreenCaptureCursorSetting", () => {- it("normalizes only supported screen-capture cursor settings", () => {- expect(getScreenCaptureCursorSetting({ cursor: "motion" } as MediaTrackSettings)).toBe(- "motion",- );- expect(- getScreenCaptureCursorSetting({ cursor: "hidden" } as MediaTrackSettings),- ).toBeNull();- });});describe("shouldUseNativeWindowsCaptureForSource", () => {diff --git a/src/hooks/useScreenRecorder.ts b/src/hooks/useScreenRecorder.tsindex 9be2ff4f..a382ea3d 100644--- a/src/hooks/useScreenRecorder.ts+++ b/src/hooks/useScreenRecorder.ts@@ -46,12 +46,10 @@ export type BrowserMicrophoneProfile =| "no-noise-suppression"| "raw";type BrowserCaptureCursorMode = "always" | "never";-type BrowserCaptureCursorSetting = BrowserCaptureCursorMode | "motion";export type BrowserCaptureCursorPolicy = {streamCursor: BrowserCaptureCursorMode;hideOsCursorBeforeRecording: boolean;hideEditorOverlayCursorByDefault: boolean;- nativeCaptureUnavailable: boolean;};const DEFAULT_BROWSER_MICROPHONE_PROFILE: BrowserMicrophoneProfile = "processed";const BROWSER_MICROPHONE_PROFILES = new Set<BrowserMicrophoneProfile>([@@ -192,10 +190,8 @@ export function normalizeBrowserMicrophoneProfile(value?: string | null): Browseexport function resolveBrowserCaptureCursorPolicy({nativeWindowsCaptureStartFailed = false,- platform,}: {nativeWindowsCaptureStartFailed?: boolean;- platform?: string;} = {}): BrowserCaptureCursorPolicy {if (nativeWindowsCaptureStartFailed) {// If WGC already failed, avoid the telemetry overlay path that can lag on@@ -204,19 +200,6 @@ export function resolveBrowserCaptureCursorPolicy({streamCursor: "always",hideOsCursorBeforeRecording: false,hideEditorOverlayCursorByDefault: true,- nativeCaptureUnavailable: true,- };- }-- if (platform === "linux") {- // Linux screen capture runs through xdg-desktop-portal/PipeWire. Ask the- // portal to omit the cursor, but do not pretend we can globally hide the- // OS cursor from Electron when the portal/compositor ignores that request.- return {- streamCursor: "never",- hideOsCursorBeforeRecording: false,- hideEditorOverlayCursorByDefault: true,- nativeCaptureUnavailable: true,};}@@ -224,37 +207,6 @@ export function resolveBrowserCaptureCursorPolicy({streamCursor: "never",hideOsCursorBeforeRecording: true,hideEditorOverlayCursorByDefault: true,- nativeCaptureUnavailable: false,- };-}--export function getScreenCaptureCursorSetting(- settings: MediaTrackSettings | null | undefined,-): BrowserCaptureCursorSetting | null {- const cursor = (settings as { cursor?: unknown } | null | undefined)?.cursor;- return cursor === "always" || cursor === "never" || cursor === "motion" ? cursor : null;-}--export function resolveLinuxPortalCursorPresentation({- actualCursor,- requestedCursor,-}: {- actualCursor: BrowserCaptureCursorSetting | null;- requestedCursor: BrowserCaptureCursorMode;-}): Pick<- BrowserCaptureCursorPolicy,- "hideEditorOverlayCursorByDefault" | "nativeCaptureUnavailable"-> {- if (requestedCursor === "never" && actualCursor === "never") {- return {- hideEditorOverlayCursorByDefault: false,- nativeCaptureUnavailable: false,- };- }-- return {- hideEditorOverlayCursorByDefault: true,- nativeCaptureUnavailable: true,};}@@ -420,7 +372,6 @@ export function useScreenRecorder(): UseScreenRecorderReturn {);const requestedBrowserMicrophoneProfile = useRef<string | null>(null);const hideEditorOverlayCursorByDefault = useRef(false);- const nativeCaptureUnavailableForCursorOverlay = useRef(false);const notifyRecordingFinalizationFailure = useCallback(async (message: string) => {setFinalizing(false);@@ -729,7 +680,6 @@ export function useScreenRecorder(): UseScreenRecorderReturn {const start = performance.now();console.log("[PERF:RENDERER] Finalize Session & Switch to Editor: STARTED");const shouldHideOverlayCursor = hideEditorOverlayCursorByDefault.current;- const nativeCaptureUnavailable = nativeCaptureUnavailableForCursorOverlay.current;try {if (webcamPath) {await window.electronAPI.setCurrentRecordingSession({@@ -737,12 +687,10 @@ export function useScreenRecorder(): UseScreenRecorderReturn {webcamPath,timeOffsetMs: webcamTimeOffsetMs.current,hideOverlayCursorByDefault: shouldHideOverlayCursor,- nativeCaptureUnavailable,});} else {await window.electronAPI.setCurrentVideoPath(videoPath, {hideOverlayCursorByDefault: shouldHideOverlayCursor,- nativeCaptureUnavailable,});}} catch (error) {@@ -751,7 +699,6 @@ export function useScreenRecorder(): UseScreenRecorderReturn {try {await window.electronAPI.setCurrentVideoPath(videoPath, {hideOverlayCursorByDefault: shouldHideOverlayCursor,- nativeCaptureUnavailable,});} catch (fallbackError) {console.error("Failed to persist fallback video path:", fallbackError);@@ -1219,8 +1166,6 @@ export function useScreenRecorder(): UseScreenRecorderReturn {webcamPath,timeOffsetMs: webcamTimeOffsetMs.current,hideOverlayCursorByDefault: hideEditorOverlayCursorByDefault.current,- nativeCaptureUnavailable:- nativeCaptureUnavailableForCursorOverlay.current,});console.log(@@ -1429,7 +1374,6 @@ export function useScreenRecorder(): UseScreenRecorderReturn {try {const platform = await window.electronAPI.getPlatform();hideEditorOverlayCursorByDefault.current = false;- nativeCaptureUnavailableForCursorOverlay.current = false;const existingSource = await window.electronAPI.getSelectedSource();const selectedSource =existingSource ?? (platform === "linux" ? LINUX_PORTAL_SOURCE : null);@@ -1636,12 +1580,9 @@ export function useScreenRecorder(): UseScreenRecorderReturn {const browserCursorPolicy = resolveBrowserCaptureCursorPolicy({nativeWindowsCaptureStartFailed,- platform,});hideEditorOverlayCursorByDefault.current =browserCursorPolicy.hideEditorOverlayCursorByDefault;- nativeCaptureUnavailableForCursorOverlay.current =- browserCursorPolicy.nativeCaptureUnavailable;const wantsAudioCapture = microphoneEnabled || systemAudioEnabled;const browserCaptureSource = await resolveBrowserCaptureSource(selectedSource);@@ -1825,27 +1766,6 @@ export function useScreenRecorder(): UseScreenRecorderReturn {throw new Error("Media stream is not available.");}- if (useLinuxPortal) {- const actualCursor = getScreenCaptureCursorSetting(videoTrack.getSettings());- const cursorPresentation = resolveLinuxPortalCursorPresentation({- actualCursor,- requestedCursor: browserCursorPolicy.streamCursor,- });- hideEditorOverlayCursorByDefault.current =- cursorPresentation.hideEditorOverlayCursorByDefault;- nativeCaptureUnavailableForCursorOverlay.current =- cursorPresentation.nativeCaptureUnavailable;- if (cursorPresentation.nativeCaptureUnavailable) {- console.warn(- "Linux portal did not confirm cursor-hidden capture; disabling Recordly cursor overlay for this recording.",- {- actualCursor,- requestedCursor: browserCursorPolicy.streamCursor,- },- );- }- }-try {await videoTrack.applyConstraints({frameRate: { ideal: TARGET_FRAME_RATE, max: TARGET_FRAME_RATE },@@ -1951,8 +1871,6 @@ export function useScreenRecorder(): UseScreenRecorderReturn {timeOffsetMs: webcamTimeOffsetMs.current,hideOverlayCursorByDefault:hideEditorOverlayCursorByDefault.current,- nativeCaptureUnavailable:- nativeCaptureUnavailableForCursorOverlay.current,});}} finally {