Create polished demo videos without editing skills. Mac/Windows/Linux
fix(recording): persist microphone and system-audio preferences
webadderall6d1e55a8e16a
diff --git a/electron/electron-env.d.ts b/electron/electron-env.d.tsindex 4469e6e7..3d7c2922 100644--- a/electron/electron-env.d.ts+++ b/electron/electron-env.d.ts@@ -360,6 +360,9 @@ interface Window {getAppVersion: () => Promise<string>;/** Hide the OS cursor before browser capture starts. */hideOsCursor: () => Promise<{ success: boolean }>;+ /** Recording preferences (mic, system audio) */+ getRecordingPreferences: () => Promise<{ success: boolean; microphoneEnabled: boolean; microphoneDeviceId?: string; systemAudioEnabled: boolean }>;+ setRecordingPreferences: (prefs: { microphoneEnabled?: boolean; microphoneDeviceId?: string; systemAudioEnabled?: boolean }) => Promise<{ success: boolean; error?: string }>;/** Countdown timer before recording */getCountdownDelay: () => Promise<{ success: boolean; delay: number }>;setCountdownDelay: (delay: number) => Promise<{ success: boolean; error?: string }>;diff --git a/electron/ipc/handlers.ts b/electron/ipc/handlers.tsindex dc87872a..c5308430 100644--- a/electron/ipc/handlers.ts+++ b/electron/ipc/handlers.ts@@ -4811,6 +4811,39 @@ body{background:transparent;overflow:hidden;width:100vw;height:100vh}// ---------------------------------------------------------------------------// Countdown timer before recording// ---------------------------------------------------------------------------+ ipcMain.handle('get-recording-preferences', async () => {+ try {+ const content = await fs.readFile(RECORDINGS_SETTINGS_FILE, 'utf-8')+ const parsed = JSON.parse(content) as Record<string, unknown>+ return {+ success: true,+ microphoneEnabled: parsed.microphoneEnabled === true,+ microphoneDeviceId: typeof parsed.microphoneDeviceId === 'string' ? parsed.microphoneDeviceId : undefined,+ systemAudioEnabled: parsed.systemAudioEnabled !== false,+ }+ } catch {+ return { success: true, microphoneEnabled: false, microphoneDeviceId: undefined, systemAudioEnabled: true }+ }+ })++ ipcMain.handle('set-recording-preferences', async (_, prefs: { microphoneEnabled?: boolean; microphoneDeviceId?: string; systemAudioEnabled?: boolean }) => {+ try {+ let existing: Record<string, unknown> = {}+ try {+ const content = await fs.readFile(RECORDINGS_SETTINGS_FILE, 'utf-8')+ existing = JSON.parse(content) as Record<string, unknown>+ } catch {+ // file doesn't exist yet+ }+ const merged = { ...existing, ...prefs }+ await fs.writeFile(RECORDINGS_SETTINGS_FILE, JSON.stringify(merged, null, 2), 'utf-8')+ return { success: true }+ } catch (error) {+ console.error('Failed to save recording preferences:', error)+ return { success: false, error: String(error) }+ }+ })+ipcMain.handle('get-countdown-delay', async () => {try {const content = await fs.readFile(COUNTDOWN_SETTINGS_FILE, 'utf-8')diff --git a/electron/preload.ts b/electron/preload.tsindex 94ea61ce..be1932d3 100644--- a/electron/preload.ts+++ b/electron/preload.ts@@ -379,6 +379,8 @@ contextBridge.exposeInMainWorld("electronAPI", {muxNativeWindowsRecording: () => ipcRenderer.invoke("mux-native-windows-recording"),hideOsCursor: () => ipcRenderer.invoke("hide-cursor"),getAppVersion: () => ipcRenderer.invoke("app:getVersion"),+ getRecordingPreferences: () => ipcRenderer.invoke("get-recording-preferences"),+ setRecordingPreferences: (prefs: { microphoneEnabled?: boolean; microphoneDeviceId?: string; systemAudioEnabled?: boolean }) => ipcRenderer.invoke("set-recording-preferences", prefs),getCountdownDelay: () => ipcRenderer.invoke("get-countdown-delay"),setCountdownDelay: (delay: number) => ipcRenderer.invoke("set-countdown-delay", delay),startCountdown: (seconds: number) => ipcRenderer.invoke("start-countdown", seconds),diff --git a/src/hooks/useScreenRecorder.ts b/src/hooks/useScreenRecorder.tsindex f5db2efa..7f391316 100644--- a/src/hooks/useScreenRecorder.ts+++ b/src/hooks/useScreenRecorder.ts@@ -88,6 +88,7 @@ export function useScreenRecorder(): UseScreenRecorderReturn {const hasPromptedForReselect = useRef(false);const hasShownNativeWindowsFallbackToast = useRef(false);const countdownDelayLoaded = useRef(false);+ const recordingPrefsLoaded = useRef(false);const pendingWebcamPathPromise = useRef<Promise<string | null> | null>(null);const webcamStopPromise = useRef<Promise<string | null> | null>(null);const webcamStopResolver = useRef<((path: string | null) => void) | null>(null);@@ -557,6 +558,37 @@ export function useScreenRecorder(): UseScreenRecorderReturn {void window.electronAPI.setCountdownDelay(delay);}, []);+ useEffect(() => {+ if (recordingPrefsLoaded.current) return;+ recordingPrefsLoaded.current = true;++ void (async () => {+ const result = await window.electronAPI.getRecordingPreferences();+ if (result.success) {+ setMicrophoneEnabled(result.microphoneEnabled);+ if (result.microphoneDeviceId) {+ setMicrophoneDeviceId(result.microphoneDeviceId);+ }+ setSystemAudioEnabled(result.systemAudioEnabled);+ }+ })();+ }, []);++ const persistMicrophoneEnabled = useCallback((enabled: boolean) => {+ setMicrophoneEnabled(enabled);+ void window.electronAPI.setRecordingPreferences({ microphoneEnabled: enabled });+ }, []);++ const persistMicrophoneDeviceId = useCallback((deviceId: string | undefined) => {+ setMicrophoneDeviceId(deviceId);+ void window.electronAPI.setRecordingPreferences({ microphoneDeviceId: deviceId });+ }, []);++ const persistSystemAudioEnabled = useCallback((enabled: boolean) => {+ setSystemAudioEnabled(enabled);+ void window.electronAPI.setRecordingPreferences({ systemAudioEnabled: enabled });+ }, []);+useEffect(() => {let cleanup: (() => void) | undefined;@@ -1113,11 +1145,11 @@ export function useScreenRecorder(): UseScreenRecorderReturn {preparePermissions,isMacOS,microphoneEnabled,- setMicrophoneEnabled,+ setMicrophoneEnabled: persistMicrophoneEnabled,microphoneDeviceId,- setMicrophoneDeviceId,+ setMicrophoneDeviceId: persistMicrophoneDeviceId,systemAudioEnabled,- setSystemAudioEnabled,+ setSystemAudioEnabled: persistSystemAudioEnabled,webcamEnabled,setWebcamEnabled,webcamDeviceId,