Create polished demo videos without editing skills. Mac/Windows/Linux
refactor(pixi): centralize initialization timeout
wiiiii12370a33a30d132
diff --git a/src/components/video-editor/VideoPlayback.tsx b/src/components/video-editor/VideoPlayback.tsxindex 653e6161..7490f454 100644--- a/src/components/video-editor/VideoPlayback.tsx+++ b/src/components/video-editor/VideoPlayback.tsx@@ -17,7 +17,10 @@ import {enablePitchPreservingPlayback,getMediaSyncPlaybackRate,} from "@/lib/mediaTiming";-import { destroyPixiApplication, initializePixiApplication } from "@/lib/pixiApplicationLifecycle";+import {+ destroyPixiApplication,+ initializePixiApplicationWithTimeout,+} from "@/lib/pixiApplicationLifecycle";import {DEFAULT_WALLPAPER_PATH,DEFAULT_WALLPAPER_RELATIVE_PATH,@@ -260,30 +263,6 @@ function summarizeRendererAttempts(attempts: readonly PixiRendererAttempt[]): streturn `No supported Pixi preview renderer was available. Attempted: ${details}`;}-type PixiInitOptions = Parameters<Application["init"]>[0];--async function initApplicationWithTimeout(- app: Application,- options: PixiInitOptions,- backend: PixiPreviewBackend,-): Promise<void> {- const timeoutErrorMessage = `Initialization timed out after ${PIXI_RENDERER_INIT_TIMEOUT_MS}ms for ${backend} renderer`;- let timeoutId: ReturnType<typeof setTimeout> | undefined;- const timeoutPromise = new Promise<never>((_, reject) => {- timeoutId = setTimeout(() => {- reject(new Error(timeoutErrorMessage));- }, PIXI_RENDERER_INIT_TIMEOUT_MS);- });-- try {- await Promise.race([initializePixiApplication(app, options), timeoutPromise]);- } finally {- if (timeoutId !== undefined) {- clearTimeout(timeoutId);- }- }-}-function getCursorPositionAtTime(telemetry: CursorTelemetryPoint[],timeMs: number,@@ -681,7 +660,7 @@ const VideoPlayback = forwardRef<VideoPlaybackRef, VideoPlaybackProps>(const initStarted =typeof performance === "undefined" ? Date.now() : performance.now();try {- await initApplicationWithTimeout(+ await initializePixiApplicationWithTimeout(rendererApp,{width: container.clientWidth,@@ -695,6 +674,7 @@ const VideoPlayback = forwardRef<VideoPlaybackRef, VideoPlaybackProps>(autoStart: true,sharedTicker: false,},+ PIXI_RENDERER_INIT_TIMEOUT_MS,backend,);const elapsed = Math.round(diff --git a/src/lib/exporter/frameRenderer.ts b/src/lib/exporter/frameRenderer.tsindex 6f891628..018bd176 100644--- a/src/lib/exporter/frameRenderer.ts+++ b/src/lib/exporter/frameRenderer.ts@@ -72,7 +72,10 @@ import {clampMediaTimeToDuration,getEffectiveVideoStreamDurationSeconds,} from "@/lib/mediaTiming";-import { destroyPixiApplication, initializePixiApplication } from "@/lib/pixiApplicationLifecycle";+import {+ destroyPixiApplication,+ initializePixiApplicationWithTimeout,+} from "@/lib/pixiApplicationLifecycle";import { isVideoWallpaperSource } from "@/lib/wallpapers";import { renderAnnotations } from "./annotationRenderer";import { renderCaptions } from "./captionRenderer";@@ -174,30 +177,6 @@ function toErrorMessage(error: unknown): string {return error instanceof Error ? error.message : String(error ?? "Unknown renderer init error");}-type PixiInitOptions = Parameters<Application["init"]>[0];--async function initApplicationWithTimeout(- app: Application,- options: PixiInitOptions,- backend: ExportRenderBackend,-): Promise<void> {- const timeoutErrorMessage = `Initialization timed out after ${PIXI_RENDERER_INIT_TIMEOUT_MS}ms for ${backend} renderer`;- let timeoutId: ReturnType<typeof setTimeout> | undefined;- const timeoutPromise = new Promise<never>((_, reject) => {- timeoutId = setTimeout(() => {- reject(new Error(timeoutErrorMessage));- }, PIXI_RENDERER_INIT_TIMEOUT_MS);- });-- try {- await Promise.race([initializePixiApplication(app, options), timeoutPromise]);- } finally {- if (timeoutId !== undefined) {- clearTimeout(timeoutId);- }- }-}-function summarizeRendererAttempts(attempts: readonly PixiRendererAttempt[]): string {const details = attempts.map((attempt) => `${attempt.backend}: ${attempt.message}`).join(" | ");return `No supported Pixi export backend was available. Attempted: ${details}`;@@ -359,12 +338,13 @@ export class FrameRenderer {const app = new Application();const initStarted = typeof performance === "undefined" ? Date.now() : performance.now();try {- await initApplicationWithTimeout(+ await initializePixiApplicationWithTimeout(app,{...baseOptions,preference: backend,},+ PIXI_RENDERER_INIT_TIMEOUT_MS,backend,);const elapsed = Math.round(diff --git a/src/lib/exporter/modernFrameRenderer.ts b/src/lib/exporter/modernFrameRenderer.tsindex 892a5338..33aad0dd 100644--- a/src/lib/exporter/modernFrameRenderer.ts+++ b/src/lib/exporter/modernFrameRenderer.ts@@ -82,7 +82,10 @@ import {clampMediaTimeToDuration,getEffectiveVideoStreamDurationSeconds,} from "@/lib/mediaTiming";-import { destroyPixiApplication, initializePixiApplication } from "@/lib/pixiApplicationLifecycle";+import {+ destroyPixiApplication,+ initializePixiApplicationWithTimeout,+} from "@/lib/pixiApplicationLifecycle";import { isVideoWallpaperSource } from "@/lib/wallpapers";import {type AnnotationRenderAssets,@@ -285,30 +288,6 @@ function isKnownRendererUnavailableError(error: unknown): boolean {);}-type PixiInitOptions = Parameters<Application["init"]>[0];--async function initApplicationWithTimeout(- app: Application,- options: PixiInitOptions,- backend: ExportRenderBackend,-): Promise<void> {- const timeoutErrorMessage = `Initialization timed out after ${PIXI_RENDERER_INIT_TIMEOUT_MS}ms for ${backend} renderer`;- let timeoutId: ReturnType<typeof setTimeout> | undefined;- const timeoutPromise = new Promise<never>((_, reject) => {- timeoutId = setTimeout(() => {- reject(new Error(timeoutErrorMessage));- }, PIXI_RENDERER_INIT_TIMEOUT_MS);- });-- try {- await Promise.race([initializePixiApplication(app, options), timeoutPromise]);- } finally {- if (timeoutId !== undefined) {- clearTimeout(timeoutId);- }- }-}-interface RenderSnapshot {timeMs: number;cursorTimeMs: number;@@ -721,12 +700,13 @@ export class FrameRenderer {const app = new Application();const initStarted = typeof performance === "undefined" ? Date.now() : performance.now();try {- await initApplicationWithTimeout(+ await initializePixiApplicationWithTimeout(app,{...baseOptions,preference: backend,},+ PIXI_RENDERER_INIT_TIMEOUT_MS,backend,);const elapsed = Math.round(diff --git a/src/lib/pixiApplicationLifecycle.test.ts b/src/lib/pixiApplicationLifecycle.test.tsindex 53fd09ee..6b576242 100644--- a/src/lib/pixiApplicationLifecycle.test.ts+++ b/src/lib/pixiApplicationLifecycle.test.ts@@ -1,6 +1,10 @@import type { Application } from "pixi.js";import { describe, expect, it, vi } from "vitest";-import { destroyPixiApplication, initializePixiApplication } from "./pixiApplicationLifecycle";+import {+ destroyPixiApplication,+ initializePixiApplication,+ initializePixiApplicationWithTimeout,+} from "./pixiApplicationLifecycle";function createApplication(init: () => Promise<void> = async () => undefined) {return {@@ -89,4 +93,21 @@ describe("Pixi application lifecycle", () => {);warn.mockRestore();});++ it("reports the backend when initialization times out", async () => {+ vi.useFakeTimers();+ try {+ const app = createApplication(() => new Promise<void>(() => undefined));+ const initialization = initializePixiApplicationWithTimeout(app, {}, 250, "webgpu");+ const rejection = initialization.catch((error: unknown) => error);++ await vi.advanceTimersByTimeAsync(250);++ await expect(rejection).resolves.toEqual(+ new Error("Initialization timed out after 250ms for webgpu renderer"),+ );+ } finally {+ vi.useRealTimers();+ }+ });});diff --git a/src/lib/pixiApplicationLifecycle.ts b/src/lib/pixiApplicationLifecycle.tsindex 87fdb648..62a0f743 100644--- a/src/lib/pixiApplicationLifecycle.ts+++ b/src/lib/pixiApplicationLifecycle.ts@@ -77,6 +77,28 @@ export async function initializePixiApplication(if (destroyRequests.has(app)) completeDestroy(app);}+export async function initializePixiApplicationWithTimeout(+ app: Application,+ options: PixiInitOptions,+ timeoutMs: number,+ backendLabel: string,+): Promise<void> {+ let timeoutId: ReturnType<typeof setTimeout> | undefined;+ const timeoutPromise = new Promise<never>((_, reject) => {+ timeoutId = setTimeout(() => {+ reject(+ new Error(`Initialization timed out after ${timeoutMs}ms for ${backendLabel} renderer`),+ );+ }, timeoutMs);+ });++ try {+ await Promise.race([initializePixiApplication(app, options), timeoutPromise]);+ } finally {+ if (timeoutId !== undefined) clearTimeout(timeoutId);+ }+}+export function destroyPixiApplication(app: Application | null, context: string): void {if (!app || destroyRequests.has(app) || completedCleanups.has(app)) return;