Skip to content

Create polished demo videos without editing skills. Mac/Windows/Linux

fix(ci): use v143 toolset on Visual Studio 2026

wiiiii123a8449d9bcbfd
diff --git a/electron/windowsCmakeGenerators.test.mjs b/electron/windowsCmakeGenerators.test.mjs
index cfded966..2f651ba9 100644
--- a/electron/windowsCmakeGenerators.test.mjs
+++ b/electron/windowsCmakeGenerators.test.mjs
@@ -19,7 +19,7 @@ describe("configureWithWindowsCmakeGenerator", () => {
expect(selected).toBe("Visual Studio 18 2026");
expect(WINDOWS_VISUAL_STUDIO_INSTALL_DIRS[0]).toBe("18");
- expect(configure).toHaveBeenCalledTimes(1);
+ expect(configure).toHaveBeenCalledWith("Visual Studio 18 2026", "v143");
expect(clearCache).toHaveBeenCalledTimes(1);
});
@@ -32,15 +32,17 @@ describe("configureWithWindowsCmakeGenerator", () => {
prefix: "test",
clearCache,
log,
- configure: (generator) => {
- attempted.push(generator);
+ configure: (generator, toolset) => {
+ attempted.push({ name: generator, toolset });
if (generator !== "Visual Studio 16 2019") {
throw new Error(`${generator} unavailable`);
}
},
});
- expect(attempted).toEqual(WINDOWS_CMAKE_GENERATORS.map(({ name }) => name));
+ expect(attempted).toEqual(
+ WINDOWS_CMAKE_GENERATORS.map(({ name, toolset }) => ({ name, toolset })),
+ );
expect(clearCache).toHaveBeenCalledTimes(3);
expect(log).toHaveBeenCalledTimes(2);
expect(selected).toBe("Visual Studio 16 2019");
diff --git a/scripts/build-cursor-monitor.mjs b/scripts/build-cursor-monitor.mjs
index f051adab..37fea5a4 100644
--- a/scripts/build-cursor-monitor.mjs
+++ b/scripts/build-cursor-monitor.mjs
@@ -124,8 +124,8 @@ try {
configureWithWindowsCmakeGenerator({
prefix: "build-cursor-monitor",
clearCache: clearCmakeCache,
- configure: (generator) =>
- execSync(`${cmake} .. -G "${generator}" -A x64`, {
+ configure: (generator, toolset) =>
+ execSync(`${cmake} .. -G "${generator}" -A x64${toolset ? ` -T ${toolset}` : ""}`, {
cwd: buildDir,
stdio: "inherit",
timeout: 120000,
diff --git a/scripts/build-nvidia-cuda-compositor.mjs b/scripts/build-nvidia-cuda-compositor.mjs
index 080a7526..f1447c4b 100644
--- a/scripts/build-nvidia-cuda-compositor.mjs
+++ b/scripts/build-nvidia-cuda-compositor.mjs
@@ -244,9 +244,9 @@ try {
configureWithWindowsCmakeGenerator({
prefix: "build-nvidia-cuda-compositor",
clearCache: clearCmakeCache,
- configure: (generator) =>
+ configure: (generator, toolset) =>
execSync(
- `${cmake} .. -G "${generator}" -A ${generatorArch} -DRECORDLY_NVIDIA_VIDEO_CODEC_SDK_ROOT="${videoCodecSdkRoot}"`,
+ `${cmake} .. -G "${generator}" -A ${generatorArch}${toolset ? ` -T ${toolset}` : ""} -DRECORDLY_NVIDIA_VIDEO_CODEC_SDK_ROOT="${videoCodecSdkRoot}"`,
{
cwd: buildDir,
stdio: "inherit",
diff --git a/scripts/build-whisper-runtime.mjs b/scripts/build-whisper-runtime.mjs
index 7bd08e39..e5e46c99 100644
--- a/scripts/build-whisper-runtime.mjs
+++ b/scripts/build-whisper-runtime.mjs
@@ -274,7 +274,7 @@ async function shouldSkipBuild(target) {
}
}
-function getConfigureArgs(sourceDir, target, generator) {
+function getConfigureArgs(sourceDir, target, generator, toolset) {
const args = [
"-S",
sourceDir,
@@ -284,6 +284,7 @@ function getConfigureArgs(sourceDir, target, generator) {
"-DWHISPER_BUILD_SERVER=OFF",
"-DBUILD_SHARED_LIBS=OFF",
...(generator ? ["-G", generator] : []),
+ ...(toolset ? ["-T", toolset] : []),
...target.configureArgs,
];
@@ -437,8 +438,8 @@ async function main() {
force: true,
});
},
- configure: (generator) =>
- execFileSync(cmake, getConfigureArgs(sourceDir, target, generator), {
+ configure: (generator, toolset) =>
+ execFileSync(cmake, getConfigureArgs(sourceDir, target, generator, toolset), {
stdio: "inherit",
timeout: 300000,
}),
diff --git a/scripts/build-windows-capture.mjs b/scripts/build-windows-capture.mjs
index 06aacdf8..82f9c939 100644
--- a/scripts/build-windows-capture.mjs
+++ b/scripts/build-windows-capture.mjs
@@ -127,8 +127,8 @@ try {
configureWithWindowsCmakeGenerator({
prefix: "build-windows-capture",
clearCache: clearCmakeCache,
- configure: (generator) =>
- execSync(`${cmake} .. -G "${generator}" -A ${generatorArch}`, {
+ configure: (generator, toolset) =>
+ execSync(`${cmake} .. -G "${generator}" -A ${generatorArch}${toolset ? ` -T ${toolset}` : ""}`, {
cwd: buildDir,
stdio: "inherit",
timeout: 120000,
diff --git a/scripts/build-windows-gpu-export.mjs b/scripts/build-windows-gpu-export.mjs
index 4530e892..27730fbf 100644
--- a/scripts/build-windows-gpu-export.mjs
+++ b/scripts/build-windows-gpu-export.mjs
@@ -122,8 +122,8 @@ try {
configureWithWindowsCmakeGenerator({
prefix: "build-windows-gpu-export",
clearCache: clearCmakeCache,
- configure: (generator) =>
- execSync(`${cmake} .. -G "${generator}" -A ${generatorArch}`, {
+ configure: (generator, toolset) =>
+ execSync(`${cmake} .. -G "${generator}" -A ${generatorArch}${toolset ? ` -T ${toolset}` : ""}`, {
cwd: buildDir,
stdio: "inherit",
timeout: 120000,
diff --git a/scripts/windows-cmake-generators.mjs b/scripts/windows-cmake-generators.mjs
index d832f570..13262163 100644
--- a/scripts/windows-cmake-generators.mjs
+++ b/scripts/windows-cmake-generators.mjs
@@ -1,5 +1,5 @@
export const WINDOWS_CMAKE_GENERATORS = Object.freeze([
- { name: "Visual Studio 18 2026", label: "VS 2026" },
+ { name: "Visual Studio 18 2026", label: "VS 2026", toolset: "v143" },
{ name: "Visual Studio 17 2022", label: "VS 2022" },
{ name: "Visual Studio 16 2019", label: "VS 2019" },
]);
@@ -19,7 +19,7 @@ export function configureWithWindowsCmakeGenerator({
clearCache();
try {
- configure(generator.name);
+ configure(generator.name, generator.toolset);
return generator.name;
} catch (error) {
lastError = error;