Skip to content

Create polished demo videos without editing skills. Mac/Windows/Linux

Address validated CodeRabbit findings for project saves and HUD lifecycle

webadderallb7997e902b4d
diff --git a/electron/electron-env.d.ts b/electron/electron-env.d.ts
index 55b4594f..5409fcbe 100644
--- a/electron/electron-env.d.ts
+++ b/electron/electron-env.d.ts
@@ -1014,6 +1014,7 @@ interface Window {
/** Countdown timer before recording */
getCountdownDelay: () => Promise<{ success: boolean; delay: number }>;
setCountdownDelay: (delay: number) => Promise<{ success: boolean; error?: string }>;
+ finishRecordingStartup: () => Promise<void>;
startCountdown: (seconds: number) => Promise<{ success: boolean; cancelled?: boolean }>;
cancelCountdown: () => Promise<{ success: boolean }>;
getActiveCountdown: () => Promise<{ success: boolean; seconds: number | null }>;
diff --git a/electron/hudCaptureProtection.test.ts b/electron/hudCaptureProtection.test.ts
index 30b0e2b9..28f80722 100644
--- a/electron/hudCaptureProtection.test.ts
+++ b/electron/hudCaptureProtection.test.ts
@@ -2,6 +2,7 @@ import { describe, expect, it } from "vitest";
import {
getHudCaptureExcludedProcessIds,
+ shouldProtectHudCapture,
supportsHudCaptureProtection,
} from "../src/lib/hudCaptureProtection";
@@ -19,3 +20,11 @@ describe("HUD capture protection lifecycle", () => {
expect(getHudCaptureExcludedProcessIds("linux", true, 734)).toEqual([]);
});
});
+
+it("protects initial capture frames while keeping idle and failed starts visible", () => {
+ expect(shouldProtectHudCapture(true, false, false)).toBe(false);
+ expect(shouldProtectHudCapture(true, false, true)).toBe(true);
+ expect(shouldProtectHudCapture(true, true, false)).toBe(true);
+ expect(shouldProtectHudCapture(true, false, false)).toBe(false);
+ expect(shouldProtectHudCapture(false, true, true)).toBe(false);
+});
diff --git a/electron/ipc/project/recentMetadata.test.ts b/electron/ipc/project/recentMetadata.test.ts
new file mode 100644
index 00000000..c20f49de
--- /dev/null
+++ b/electron/ipc/project/recentMetadata.test.ts
@@ -0,0 +1,17 @@
+import { expect, it, vi } from "vitest";
+import { persistRecentMetadata } from "./recentMetadata";
+it("reports a metadata warning without rejecting an already committed operation", async () => {
+ const log = vi.spyOn(console, "warn").mockImplementation(() => undefined);
+ const result = await persistRecentMetadata(async () => {
+ throw Error("disk full");
+ });
+ expect(result).toContain("operation completed");
+ expect(result).toContain("disk full");
+ expect(log).toHaveBeenCalledOnce();
+ log.mockRestore();
+});
+it("has no warning after a successful metadata update", async () => {
+ const update = vi.fn().mockResolvedValue(undefined);
+ await expect(persistRecentMetadata(update)).resolves.toBeUndefined();
+ expect(update).toHaveBeenCalledOnce();
+});
diff --git a/electron/ipc/project/recentMetadata.ts b/electron/ipc/project/recentMetadata.ts
new file mode 100644
index 00000000..174bf365
--- /dev/null
+++ b/electron/ipc/project/recentMetadata.ts
@@ -0,0 +1,13 @@
+/** Library history is secondary to a filesystem operation that already committed. */
+export async function persistRecentMetadata(
+ action: () => Promise<void>,
+): Promise<string | undefined> {
+ try {
+ await action();
+ return undefined;
+ } catch (error) {
+ const warning = `Project operation completed, but recent-project history could not be updated: ${String(error)}`;
+ console.warn(warning);
+ return warning;
+ }
+}
diff --git a/electron/ipc/register/project.ts b/electron/ipc/register/project.ts
index 2f974c6b..27767ba6 100644
--- a/electron/ipc/register/project.ts
+++ b/electron/ipc/register/project.ts
@@ -1,3 +1,4 @@
+import { persistRecentMetadata } from "../project/recentMetadata";
import { renameLibraryProject } from "../project/renameLibraryProject";
import { createUntitledProject } from "../project/createUntitledProject";
import { trashLibraryProjects } from "../project/trashProjects";
@@ -45,6 +46,7 @@ import {
getTelemetryPathForVideo,
isAutoRecordingPath,
normalizeVideoSourcePath,
+ normalizePath,
parseJsonWithByteOrderMark,
} from "../utils";
@@ -227,9 +229,10 @@ export function registerProjectHandlers() {
entries.entries.map((entry) => entry.path),
(value) => [getProjectThumbnailPath(value), getProjectBackupPath(value)],
);
- if (currentProjectPath === source) setCurrentProjectPath(target);
- await rememberRecentProject(target);
- return { success: true, path: target };
+ if (currentProjectPath && normalizePath(currentProjectPath) === normalizePath(source))
+ setCurrentProjectPath(target);
+ const warning = await persistRecentMetadata(() => rememberRecentProject(target));
+ return { success: true, path: target, warning };
} catch (error) {
return { success: false, error: String(error) };
}
@@ -711,13 +714,13 @@ export function registerProjectHandlers() {
JSON.stringify(prepared.projectData, null, 2),
);
setCurrentProjectPath(target);
- await rememberRecentProject(target);
+ const warning = await persistRecentMetadata(() => rememberRecentProject(target));
try {
await saveProjectThumbnail(target, thumbnailDataUrl);
} catch (error) {
console.warn("Could not save project thumbnail", error);
}
- return { success: true, path: target, projectId: prepared.projectId };
+ return { success: true, path: target, projectId: prepared.projectId, warning };
} catch (error) {
return { success: false, message: String(error) };
}
@@ -732,12 +735,14 @@ export function registerProjectHandlers() {
});
if (currentProjectPath && result.deleted.includes(path.resolve(currentProjectPath)))
setCurrentProjectPath(null);
- await saveRecentProjectPaths(
- (await loadRecentProjectPaths()).filter(
- (p) => !result.deleted.includes(path.resolve(p)),
+ const warning = await persistRecentMetadata(async () =>
+ saveRecentProjectPaths(
+ (await loadRecentProjectPaths()).filter(
+ (p) => !result.deleted.includes(path.resolve(p)),
+ ),
),
);
- return { success: result.errors.length === 0, ...result };
+ return { success: result.errors.length === 0, ...result, warning };
} catch (error) {
return { success: false, deleted: [], errors: [String(error)] };
}
diff --git a/electron/ipc/register/recording.ts b/electron/ipc/register/recording.ts
index 2262da37..797f8bad 100644
--- a/electron/ipc/register/recording.ts
+++ b/electron/ipc/register/recording.ts
@@ -14,10 +14,7 @@ import {
} from "electron";
import { getHudCaptureExcludedProcessIds } from "../../../src/lib/hudCaptureProtection";
import { showCursor } from "../../cursorHider";
-import {
- getHudOverlayCaptureProtectionEnabled,
- reassertHudOverlayCaptureProtection,
-} from "../../windows";
+import { getHudOverlayCaptureProtectionEnabled, beginHudCaptureProtection } from "../../windows";
import { ALLOW_RECORDLY_WINDOW_CAPTURE } from "../constants";
import { startWindowBoundsCapture, stopWindowBoundsCapture } from "../cursor/bounds";
import { startInteractionCapture, stopInteractionCapture } from "../cursor/interaction";
@@ -404,8 +401,8 @@ export function registerRecordingHandlers(
ipcMain.handle(
"start-native-screen-recording",
async (_, source: SelectedSource, options?: NativeMacRecordingOptions) => {
- // Refresh window protection; it applies only while recording is active.
- reassertHudOverlayCaptureProtection();
+ // Protect the HUD at the capture boundary, before the renderer publishes recording state.
+ beginHudCaptureProtection();
const visibleWindowBounds = source.id?.startsWith("window:")
? await bringSelectedWindowForward(source)
: null;
diff --git a/electron/main.ts b/electron/main.ts
index 915873c2..417d4a05 100644
--- a/electron/main.ts
+++ b/electron/main.ts
@@ -55,7 +55,7 @@ import {
getUpdateToastWindow,
hideUpdateToastWindow,
isHudOverlayMousePassthroughSupported,
- reassertHudOverlayCaptureProtection,
+ beginHudCaptureProtection,
reassertHudOverlayMousePassthrough as reassertHudOverlayMouseState,
setHudOverlayRecordingActive,
showUpdateToastWindow,
@@ -873,7 +873,9 @@ function createSourceSelectorWindowWrapper() {
app.on("before-quit", () => {
isAppQuitting = true;
authCallbacks.close();
- void clearRecordingTrashUndo().catch((error) => console.warn("Could not clear recording undo cache", error));
+ void clearRecordingTrashUndo().catch((error) =>
+ console.warn("Could not clear recording undo cache", error),
+ );
killWindowsCaptureProcess();
showCursor();
cleanupNativeVideoExportSessions();
@@ -902,7 +904,9 @@ app.on("second-instance", (_event, commandLine) => {
app.whenReady().then(async () => {
authCallbacks.startDevServer();
if (process.defaultApp && process.argv[1]) {
- app.setAsDefaultProtocolClient(authCallbacks.protocol, process.execPath, [path.resolve(process.argv[1])]);
+ app.setAsDefaultProtocolClient(authCallbacks.protocol, process.execPath, [
+ path.resolve(process.argv[1]),
+ ]);
} else {
app.setAsDefaultProtocolClient(authCallbacks.protocol);
}
@@ -1105,7 +1109,7 @@ app.whenReady().then(async () => {
// Browser and Linux portal capture starts as soon as this callback
// resolves, before recording-state-changed is emitted.
- reassertHudOverlayCaptureProtection();
+ beginHudCaptureProtection();
const sourceId = getSelectedSourceId();
// On Linux/Wayland, calling desktopCapturer.getSources() itself
diff --git a/electron/preload.ts b/electron/preload.ts
index cbba00ff..ddfadbfa 100644
--- a/electron/preload.ts
+++ b/electron/preload.ts
@@ -1089,6 +1089,7 @@ contextBridge.exposeInMainWorld("electronAPI", {
}) => ipcRenderer.invoke("set-recording-preferences", prefs),
getCountdownDelay: () => ipcRenderer.invoke("get-countdown-delay"),
setCountdownDelay: (delay: number) => ipcRenderer.invoke("set-countdown-delay", delay),
+ finishRecordingStartup: () => ipcRenderer.invoke("finish-recording-startup"),
startCountdown: (seconds: number) => ipcRenderer.invoke("start-countdown", seconds),
cancelCountdown: () => ipcRenderer.invoke("cancel-countdown"),
getActiveCountdown: () => ipcRenderer.invoke("get-active-countdown"),
diff --git a/electron/windows.ts b/electron/windows.ts
index 719e39aa..ddcc1c2d 100644
--- a/electron/windows.ts
+++ b/electron/windows.ts
@@ -4,7 +4,10 @@ import { createRequire } from "node:module";
import path from "node:path";
import { fileURLToPath } from "node:url";
import { app, BrowserWindow, ipcMain } from "electron";
-import { supportsHudCaptureProtection } from "../src/lib/hudCaptureProtection";
+import {
+ supportsHudCaptureProtection,
+ shouldProtectHudCapture,
+} from "../src/lib/hudCaptureProtection";
import { USER_DATA_PATH } from "./appPaths";
import {
getHudOverlayWindowBounds,
@@ -36,6 +39,7 @@ let hudOverlayIgnoringMouse = true;
let hudOverlaySourceSelectionActive = false;
let hudOverlayMouseReassertTimer: NodeJS.Timeout | null = null;
let hudOverlayRecordingActive = false;
+let hudCaptureStarting = false;
let hudOverlayWebcamPreviewVisible = false;
let countdownWindow: BrowserWindow | null = null;
let updateToastWindow: BrowserWindow | null = null;
@@ -155,12 +159,23 @@ function applyHudOverlayCaptureProtectionToWindow(hud: BrowserWindow, enabled: b
try {
// Keep the idle HUD visible to screenshots and other capture applications.
- hud.setContentProtection(enabled && hudOverlayRecordingActive);
+ hud.setContentProtection(
+ shouldProtectHudCapture(enabled, hudOverlayRecordingActive, hudCaptureStarting),
+ );
} catch (error) {
console.warn("Failed to apply HUD capture protection:", error);
}
}
+export function beginHudCaptureProtection(): void {
+ hudCaptureStarting = true;
+ reassertHudOverlayCaptureProtection();
+}
+ipcMain.handle("finish-recording-startup", () => {
+ hudCaptureStarting = false;
+ reassertHudOverlayCaptureProtection();
+});
+
export function reassertHudOverlayCaptureProtection(): boolean {
const enabled = loadHudOverlayCaptureProtectionSetting();
const hud = getHudOverlayWindow();
@@ -650,6 +665,9 @@ export function createHudOverlayWindow(): BrowserWindow {
screen.removeListener("display-metrics-changed", handleDisplayMetricsChanged);
if (hudOverlayWindow === win) {
hudOverlayWindow = null;
+ recordingPreparationActive = false;
+ hudCaptureStarting = false;
+ hudOverlayRecordingActive = false;
}
});
@@ -703,6 +721,7 @@ export function reassertHudOverlayMousePassthrough(): void {
}
export function setHudOverlayRecordingActive(recording: boolean): void {
+ hudCaptureStarting = false;
hudOverlayRecordingActive = Boolean(recording);
notifyEditorMode();
hudOverlayFallbackExpanded = false;
diff --git a/src/components/launch/LaunchWindow.tsx b/src/components/launch/LaunchWindow.tsx
index 1e92d63b..634fec26 100644
--- a/src/components/launch/LaunchWindow.tsx
+++ b/src/components/launch/LaunchWindow.tsx
@@ -195,8 +195,8 @@ function LaunchWindowContent() {
variant="ghost"
size="icon"
iconSize="lg"
- aria-label="Home"
- title="Home"
+ aria-label={t("recording.home")}
+ title={t("recording.home")}
onClick={openHome}
>
<House weight="fill" className="size-5" />
diff --git a/src/components/launch/RecordingControls.tsx b/src/components/launch/RecordingControls.tsx
index 2e0f9b57..2636b123 100644
--- a/src/components/launch/RecordingControls.tsx
+++ b/src/components/launch/RecordingControls.tsx
@@ -41,7 +41,7 @@ export function RecordingControls({
isIconOnly
variant="ghost"
className={actionClass}
- aria-label="Home"
+ aria-label={t("recording.home")}
onPress={onHome}
>
<House weight="fill" className="size-4" />
diff --git a/src/components/video-editor/dashboard/DashboardAnnouncements.test.tsx b/src/components/video-editor/dashboard/DashboardAnnouncements.test.tsx
index ca0e1c08..7401c34f 100644
--- a/src/components/video-editor/dashboard/DashboardAnnouncements.test.tsx
+++ b/src/components/video-editor/dashboard/DashboardAnnouncements.test.tsx
@@ -30,7 +30,10 @@ describe("announcement configuration", () => {
<DashboardAnnouncements
config={{
enabled: true,
- banners: [{ ...banner, href: "javascript:alert(1)" }, banner],
+ banners: [
+ { ...banner, src: "/banner-1.svg", href: "javascript:alert(1)" },
+ { ...banner, src: "/banner-2.svg" },
+ ],
}}
/>,
);
diff --git a/src/components/video-editor/dashboard/DashboardAnnouncements.tsx b/src/components/video-editor/dashboard/DashboardAnnouncements.tsx
index 81450cc0..7bbd3b1b 100644
--- a/src/components/video-editor/dashboard/DashboardAnnouncements.tsx
+++ b/src/components/video-editor/dashboard/DashboardAnnouncements.tsx
@@ -36,6 +36,7 @@ export function DashboardAnnouncements({
{href ? (
<Link
href={href}
+ onAuxClick={(event) => event.preventDefault()}
className="block w-full"
onClick={(event) => {
event.preventDefault();
@@ -67,7 +68,7 @@ export function DashboardAnnouncements({
>
{banners.map((banner, slide) => (
<Button
- key={banner.src}
+ key={`${slide}:${banner.src}`}
isIconOnly
variant="ghost"
aria-label={`Announcement ${slide + 1}`}
diff --git a/src/components/video-editor/dashboard/ProjectHoverPreview.tsx b/src/components/video-editor/dashboard/ProjectHoverPreview.tsx
index bc52c199..0863736f 100644
--- a/src/components/video-editor/dashboard/ProjectHoverPreview.tsx
+++ b/src/components/video-editor/dashboard/ProjectHoverPreview.tsx
@@ -4,7 +4,7 @@ import VideoPlayback, { type VideoPlaybackRef } from "../VideoPlayback";
import { normalizeProjectEditor } from "../projectPersistence";
import type { CursorTelemetryPoint } from "../types";
-const ignore = () => {};
+const ignore = () => undefined;
/** One muted five-second pass through the saved timeline using the editor renderer. */
export function ProjectHoverPreview({
data,
diff --git a/src/components/video-editor/dashboard/ProjectThumbnail.tsx b/src/components/video-editor/dashboard/ProjectThumbnail.tsx
index 75dd15e4..653946a2 100644
--- a/src/components/video-editor/dashboard/ProjectThumbnail.tsx
+++ b/src/components/video-editor/dashboard/ProjectThumbnail.tsx
@@ -32,7 +32,7 @@ export function ProjectThumbnail({
.then((result) => {
if (active && !document.hidden && result.success) setPreview(result.value);
})
- .catch(() => {});
+ .catch(() => undefined);
}, 300);
const observer = new IntersectionObserver((entries) => {
if (entries.every((entry) => !entry.isIntersecting)) {
diff --git a/src/components/video-editor/dashboard/RawRecordings.tsx b/src/components/video-editor/dashboard/RawRecordings.tsx
index 0349b83f..6f283c68 100644
--- a/src/components/video-editor/dashboard/RawRecordings.tsx
+++ b/src/components/video-editor/dashboard/RawRecordings.tsx
@@ -15,7 +15,7 @@ export function RawThumbnail({ entry, active }: { entry: RecordingLibraryEntry;
.then((result) => {
if (active && result.success) setPoster(result.value);
})
- .catch(() => {});
+ .catch(() => undefined);
return () => {
active = false;
};
@@ -30,7 +30,7 @@ export function RawThumbnail({ entry, active }: { entry: RecordingLibraryEntry;
}
const timer = window.setTimeout(() => {
element.currentTime = 0;
- void element.play().catch(() => {});
+ void element.play().catch(() => undefined);
}, 300);
const stop = () => {
if (document.hidden) element.pause();
diff --git a/src/components/video-editor/dashboard/useDashboardModel.ts b/src/components/video-editor/dashboard/useDashboardModel.ts
index 515c4903..bbe10635 100644
--- a/src/components/video-editor/dashboard/useDashboardModel.ts
+++ b/src/components/video-editor/dashboard/useDashboardModel.ts
@@ -21,6 +21,7 @@ export function useDashboardModel({
setSelected((prev) =>
prev.includes(path) ? prev.filter((p) => p !== path) : [...prev, path],
);
+ const { folders, save } = useProjectFolders();
const assignFolder = (path: string, id: string) =>
save(
folders.map((f) => ({
@@ -52,7 +53,6 @@ export function useDashboardModel({
};
const libraryEntries = isRaw ? raw.entries : entries;
const [busy, setBusy] = useState(false);
- const { folders, save } = useProjectFolders();
const visible = useMemo(
() =>
libraryEntries
diff --git a/src/components/video-editor/dashboard/useProjectFolders.ts b/src/components/video-editor/dashboard/useProjectFolders.ts
index 6fe9330f..94c93e62 100644
--- a/src/components/video-editor/dashboard/useProjectFolders.ts
+++ b/src/components/video-editor/dashboard/useProjectFolders.ts
@@ -42,6 +42,7 @@ export function useProjectFolders() {
try {
localStorage.setItem(KEY, JSON.stringify(next));
setFolders(next);
+ window.dispatchEvent(new CustomEvent("recordly-folders-changed", { detail: next }));
} catch {
toast.error("Could not save folders");
}
diff --git a/src/components/video-editor/layout/EditorShell.tsx b/src/components/video-editor/layout/EditorShell.tsx
index 66d782af..0b3c3949 100644
--- a/src/components/video-editor/layout/EditorShell.tsx
+++ b/src/components/video-editor/layout/EditorShell.tsx
@@ -7,7 +7,7 @@ import { useRecordingLibrary } from "../library/useRecordingLibrary";
import { RecordingLibraryPanel } from "../library/RecordingLibraryPanel";
import { RECORDING_DRAG_TYPE } from "@/types/recordingLibrary";
import { Button } from "@/components/ui/button";
-import { useCallback, useEffect, useRef, useState, type ComponentProps } from "react";
+import { useCallback, useMemo, useEffect, useRef, useState, type ComponentProps } from "react";
import { EditorAnnouncementBanner } from "@/components/announcements/EditorAnnouncementBanner";
import { Toaster } from "@/components/ui/toast";
import type { useI18n } from "@/contexts/I18nContext";
@@ -133,19 +133,21 @@ export function EditorShell(props: Props) {
handleAutoSuggestZoomsConsumed,
} = editing;
const { dialogActions, status: exportStatus, exportMessage } = exportController;
+ const dashboardSettingsContent = useMemo(
+ () => (
+ <SettingsPanel
+ {...settingsPanelProps}
+ activeEffectSection="settings"
+ selectedAnnotationId={null}
+ selectedClipId={null}
+ advanced
+ />
+ ),
+ [settingsPanelProps],
+ );
const editorDialogs = (
<AccountProfileContext.Provider value={auth.user}>
- <DashboardSettingsContext.Provider
- value={
- <SettingsPanel
- {...settingsPanelProps}
- activeEffectSection="settings"
- selectedAnnotationId={null}
- selectedClipId={null}
- advanced
- />
- }
- >
+ <DashboardSettingsContext.Provider value={dashboardSettingsContent}>
<EditorDialogs
t={t}
projectSaveDialogOpen={project.projectSaveDialogOpen}
diff --git a/src/components/video-editor/project/useProjectLibraryController.ts b/src/components/video-editor/project/useProjectLibraryController.ts
index 8b893683..199b15d7 100644
--- a/src/components/video-editor/project/useProjectLibraryController.ts
+++ b/src/components/video-editor/project/useProjectLibraryController.ts
@@ -112,8 +112,8 @@ export function useProjectLibraryController({
}
const canvas = document.createElement("canvas");
- const targetWidth = 1600;
- const targetHeight = 1200;
+ const targetWidth = 640;
+ const targetHeight = 480;
canvas.width = targetWidth;
canvas.height = targetHeight;
diff --git a/src/components/video-editor/project/useProjectOpenActions.ts b/src/components/video-editor/project/useProjectOpenActions.ts
index de098008..33ea8f3f 100644
--- a/src/components/video-editor/project/useProjectOpenActions.ts
+++ b/src/components/video-editor/project/useProjectOpenActions.ts
@@ -180,12 +180,9 @@ export function useProjectOpenActions({
}
videoPlaybackRef.current?.pause();
setIsPlaying(false);
- if (
- project.videoPath &&
- !project.error &&
- !(await saveProject(false, { remountPreviewAfterSave: false }))
- )
- return;
+ if (project.videoPath && !project.error) {
+ await saveProject(false, { remountPreviewAfterSave: false });
+ }
project.setProjectBrowserOpen(true);
void refreshProjectLibrary();
}, [
@@ -236,14 +233,17 @@ export function useProjectOpenActions({
},
[project, refreshProjectLibrary],
);
- const handleRenameLibraryProject = async (path: string, name: string) => {
- const result = await window.electronAPI.renameLibraryProject(path, name);
- if (!result.success || !result.path)
- throw new Error(result.error || "Could not rename project");
- if (project.currentProjectPath === path) project.setCurrentProjectPath(result.path);
- await refreshProjectLibrary();
- return result.path;
- };
+ const handleRenameLibraryProject = useCallback(
+ async (path: string, name: string) => {
+ const result = await window.electronAPI.renameLibraryProject(path, name);
+ if (!result.success || !result.path)
+ throw new Error(result.error || "Could not rename project");
+ if (project.currentProjectPath === path) project.setCurrentProjectPath(result.path);
+ await refreshProjectLibrary();
+ return result.path;
+ },
+ [project, refreshProjectLibrary],
+ );
return {
handleRenameLibraryProject,
diff --git a/src/components/video-editor/project/useProjectSaveActions.ts b/src/components/video-editor/project/useProjectSaveActions.ts
index 504f491f..85a12cbc 100644
--- a/src/components/video-editor/project/useProjectSaveActions.ts
+++ b/src/components/video-editor/project/useProjectSaveActions.ts
@@ -1,6 +1,6 @@
import { moveProjectFolderReferences } from "../dashboard/useProjectFolders";
import { moveProjectShareLink } from "../cloud/projectShareLinks";
-import { type RefObject, useCallback, useEffect, useRef } from "react";
+import { type RefObject, useCallback, useEffect, useLayoutEffect, useRef } from "react";
import { toast } from "@/components/ui/toast";
import { createProjectData, type EditorProjectData } from "../projectPersistence";
import type { useProjectState } from "../state/useProjectState";
@@ -61,9 +61,13 @@ export function useProjectSaveActions({
} = project;
const savingNameRef = useRef(false);
const activePathRef = useRef(currentProjectPath);
- activePathRef.current = currentProjectPath;
const activeSourceRef = useRef(currentSourcePath);
- activeSourceRef.current = currentSourcePath;
+ useLayoutEffect(() => {
+ activePathRef.current = currentProjectPath;
+ }, [currentProjectPath]);
+ useLayoutEffect(() => {
+ activeSourceRef.current = currentSourcePath;
+ }, [currentSourcePath]);
const autosaveTimeoutRef = useRef<number | null>(null);
const saveQueueRef = useRef<Promise<unknown>>(Promise.resolve());
const clearPendingAutosave = useCallback(() => {
diff --git a/src/components/video-editor/project/useProjectSnapshotModel.ts b/src/components/video-editor/project/useProjectSnapshotModel.ts
index aab65ffa..c01ef86e 100644
--- a/src/components/video-editor/project/useProjectSnapshotModel.ts
+++ b/src/components/video-editor/project/useProjectSnapshotModel.ts
@@ -41,13 +41,12 @@ export function useProjectSnapshotModel({
[project.videoPath, project.videoSourcePath],
);
const projectDisplayName = useMemo(() => {
- const fileName =
- project.currentProjectPath?.split(/[\\/]/).pop() ?? "Untitled Project";
+ const fileName = project.currentProjectPath?.split(/[\\/]/).pop() ?? "Untitled Project";
return (
fileName.replace(/\.recordly$/i, "").replace(/\.[^.]+$/, "") ||
t("editor.project.untitled", "Untitled Project")
);
- }, [project.currentProjectPath, currentSourcePath, t]);
+ }, [project.currentProjectPath, t]);
useEffect(() => {
if (!project.isEditingProjectName) project.setProjectNameDraft(projectDisplayName);
diff --git a/src/hooks/useScreenRecorder.ts b/src/hooks/useScreenRecorder.ts
index 184f939f..dc6b7032 100644
--- a/src/hooks/useScreenRecorder.ts
+++ b/src/hooks/useScreenRecorder.ts
@@ -2273,6 +2273,11 @@ export function useScreenRecorder(): UseScreenRecorderReturn {
await stopWebcamRecorder();
}
} finally {
+ try {
+ await window.electronAPI.finishRecordingStartup();
+ } catch (error) {
+ console.warn("Failed to release recording startup protection:", error);
+ }
setHudSourceSelectionActive(false);
startInFlight.current = false;
setStarting(false);
diff --git a/src/i18n/locales/de/launch.json b/src/i18n/locales/de/launch.json
index bae51237..68e009b1 100644
--- a/src/i18n/locales/de/launch.json
+++ b/src/i18n/locales/de/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "Startseite",
"disableSystemAudio": "System-Audio deaktivieren",
"enableSystemAudio": "System-Audio aktivieren",
"disableMicrophone": "Mikrofon deaktivieren",
diff --git a/src/i18n/locales/en/launch.json b/src/i18n/locales/en/launch.json
index d4f7aba9..5b9b9cc2 100644
--- a/src/i18n/locales/en/launch.json
+++ b/src/i18n/locales/en/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "Home",
"disableSystemAudio": "Disable system audio",
"enableSystemAudio": "Enable system audio",
"disableMicrophone": "Disable microphone",
diff --git a/src/i18n/locales/es/launch.json b/src/i18n/locales/es/launch.json
index 4edc2d9c..b9e2bfa6 100644
--- a/src/i18n/locales/es/launch.json
+++ b/src/i18n/locales/es/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "Inicio",
"disableSystemAudio": "Desactivar audio del sistema",
"enableSystemAudio": "Activar audio del sistema",
"disableMicrophone": "Desactivar micrófono",
diff --git a/src/i18n/locales/fr/launch.json b/src/i18n/locales/fr/launch.json
index 2969355f..793ba285 100644
--- a/src/i18n/locales/fr/launch.json
+++ b/src/i18n/locales/fr/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "Accueil",
"disableSystemAudio": "Désactiver l’audio système",
"enableSystemAudio": "Activer l’audio système",
"disableMicrophone": "Désactiver le microphone",
diff --git a/src/i18n/locales/it/launch.json b/src/i18n/locales/it/launch.json
index 0dbdbea3..f607b768 100644
--- a/src/i18n/locales/it/launch.json
+++ b/src/i18n/locales/it/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "Home",
"disableSystemAudio": "Disabilita audio di sistema",
"enableSystemAudio": "Abilita audio di sistema",
"disableMicrophone": "Disabilita microfono",
diff --git a/src/i18n/locales/ko/launch.json b/src/i18n/locales/ko/launch.json
index 2e4683a5..3ce4af82 100644
--- a/src/i18n/locales/ko/launch.json
+++ b/src/i18n/locales/ko/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "홈",
"disableSystemAudio": "시스템 오디오 끄기",
"enableSystemAudio": "시스템 오디오 켜기",
"disableMicrophone": "마이크 끄기",
diff --git a/src/i18n/locales/nl/launch.json b/src/i18n/locales/nl/launch.json
index 774c7335..2843ca28 100644
--- a/src/i18n/locales/nl/launch.json
+++ b/src/i18n/locales/nl/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "Start",
"disableSystemAudio": "Systeemaudio uitschakelen",
"enableSystemAudio": "Systeemaudio inschakelen",
"disableMicrophone": "Microfoon uitschakelen",
diff --git a/src/i18n/locales/pt-BR/launch.json b/src/i18n/locales/pt-BR/launch.json
index cc8c35c7..51f26e23 100644
--- a/src/i18n/locales/pt-BR/launch.json
+++ b/src/i18n/locales/pt-BR/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "Início",
"disableSystemAudio": "Desativar áudio do sistema",
"enableSystemAudio": "Ativar áudio do sistema",
"disableMicrophone": "Desativar microfone",
diff --git a/src/i18n/locales/ru/launch.json b/src/i18n/locales/ru/launch.json
index 47531cfa..f6bca7cd 100644
--- a/src/i18n/locales/ru/launch.json
+++ b/src/i18n/locales/ru/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "Главная",
"disableSystemAudio": "Отключить системные звуки",
"enableSystemAudio": "Включить системные звуки",
"disableMicrophone": "Отключить микрофон",
diff --git a/src/i18n/locales/zh-CN/launch.json b/src/i18n/locales/zh-CN/launch.json
index 2b88c6d7..e0c5ed7b 100644
--- a/src/i18n/locales/zh-CN/launch.json
+++ b/src/i18n/locales/zh-CN/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "主页",
"disableSystemAudio": "禁用系统音频",
"enableSystemAudio": "启用系统音频",
"disableMicrophone": "禁用麦克风",
diff --git a/src/i18n/locales/zh-TW/launch.json b/src/i18n/locales/zh-TW/launch.json
index 9d44d321..fb489486 100644
--- a/src/i18n/locales/zh-TW/launch.json
+++ b/src/i18n/locales/zh-TW/launch.json
@@ -1,5 +1,6 @@
{
"recording": {
+ "home": "首頁",
"disableSystemAudio": "停用系統音訊",
"enableSystemAudio": "啟用系統音訊",
"disableMicrophone": "停用麥克風",
diff --git a/src/index.css b/src/index.css
index e4ee7cb9..a2ebe361 100644
--- a/src/index.css
+++ b/src/index.css
@@ -188,6 +188,7 @@
color: inherit;
}
.inline-project-name:focus { outline: none; box-shadow: none; }
+.inline-project-name:focus-visible { outline: 2px solid var(--accent); outline-offset: 3px; }
.dashboard-shell {
background-color: color-mix(in srgb, var(--background) 92%, var(--foreground) 8%);
diff --git a/src/lib/hudCaptureProtection.ts b/src/lib/hudCaptureProtection.ts
index 980bcbc6..bd3ddb7c 100644
--- a/src/lib/hudCaptureProtection.ts
+++ b/src/lib/hudCaptureProtection.ts
@@ -13,3 +13,11 @@ export function getHudCaptureExcludedProcessIds(
return [processId];
}
+
+export function shouldProtectHudCapture(
+ enabled: boolean,
+ recording: boolean,
+ starting: boolean,
+): boolean {
+ return enabled && (recording || starting);
+}
diff --git a/tests/ui/bridge.ts b/tests/ui/bridge.ts
index c0bcf8c7..477a6e17 100644
--- a/tests/ui/bridge.ts
+++ b/tests/ui/bridge.ts
@@ -12,6 +12,7 @@ export async function installDesktopBridge(page: Page, videoFixture = "preview.m
Object.assign(window, {
electronAPI: {
getAppSetting: () => null,
+ finishRecordingStartup: async () => undefined,
showProjectDashboard: async () => {
document.documentElement.dataset.dashboardOpened = "true";
},
diff --git a/tests/ui/hud-layout.spec.ts b/tests/ui/hud-layout.spec.ts
index 11dfd9cc..8116374d 100644
--- a/tests/ui/hud-layout.spec.ts
+++ b/tests/ui/hud-layout.spec.ts
@@ -33,7 +33,7 @@ test("recording HUD uses uniform controls and a readable timer", async ({ page }
await installDesktopBridge(page);
await page.addInitScript(() => {
window.electronAPI.onRecordingStateChanged = (callback) => {
- const listener = () => callback({ recording: true });
+ const listener = () => callback({ recording: true, sourceName: "Built-in Display" });
window.addEventListener("test-recording-started", listener);
return () => window.removeEventListener("test-recording-started", listener);
};