Create polished demo videos without editing skills. Mac/Windows/Linux
fix: avoid duplicate mic audio in native mac recordings
webadderalld95686ffccc9
diff --git a/electron/ipc/recording/diagnostics.test.ts b/electron/ipc/recording/diagnostics.test.tsindex 21192e91..9f7ddeb0 100644--- a/electron/ipc/recording/diagnostics.test.ts+++ b/electron/ipc/recording/diagnostics.test.ts@@ -134,6 +134,32 @@ describe("getCompanionAudioFallbackPaths", () => {]);});+ it("prefers the mac mic companion alone when embedded audio already exists and no system sidecar is present", async () => {+ const videoPath = path.join(tempRoot, "recording.mp4");+ const micPath = path.join(tempRoot, "recording.mic.m4a");++ await Promise.all([fs.writeFile(videoPath, "video"), fs.writeFile(micPath, "mic")]);++ execFileMock.mockImplementation(+ (+ _file: string,+ _args: string[],+ _options: Record<string, unknown>,+ callback: ExecFileCallback,+ ) => {+ const error = new Error("ffmpeg probe found embedded audio") as Error & {+ stderr?: string;+ };+ error.stderr = "Stream #0:1: Audio: aac";+ callback(error, "", error.stderr);+ },+ );++ const { getCompanionAudioFallbackPaths } = await import("./diagnostics");++ await expect(getCompanionAudioFallbackPaths(videoPath)).resolves.toEqual([micPath]);+ });+it("loads saved sidecar timing metadata alongside companion audio paths", async () => {const videoPath = path.join(tempRoot, "recording.mp4");const micPath = path.join(tempRoot, "recording.mic.webm");diff --git a/electron/ipc/recording/diagnostics.ts b/electron/ipc/recording/diagnostics.tsindex 811e0920..1f0003a9 100644--- a/electron/ipc/recording/diagnostics.ts+++ b/electron/ipc/recording/diagnostics.ts@@ -508,20 +508,41 @@ export async function getCompanionAudioFallbackInfo(videoPath: string) {let paths: string[];if (await hasEmbeddedAudioStream(videoPath)) {- const companionPaths = Array.from(+ const hasUsableMacSystemCompanion = companionCandidates.some(+ (candidate) =>+ candidate.platform === "mac" &&+ candidate.usablePaths.includes(candidate.systemPath),+ );+ const usableMacMicOnlyCompanions = Array.from(new Set(companionCandidates.flatMap((candidate) =>- candidate.usablePaths.filter(- (companionPath) => companionPath === candidate.micPath,- ),+ candidate.platform === "mac" &&+ !candidate.usablePaths.includes(candidate.systemPath) &&+ candidate.usablePaths.includes(candidate.micPath)+ ? [candidate.micPath]+ : [],),),);- if (companionPaths.length === 0) {- return { paths: [], startDelayMsByPath: {} };- }- paths = [videoPath, ...companionPaths];+ if (!hasUsableMacSystemCompanion && usableMacMicOnlyCompanions.length > 0) {+ paths = usableMacMicOnlyCompanions;+ } else {+ const companionPaths = Array.from(+ new Set(+ companionCandidates.flatMap((candidate) =>+ candidate.usablePaths.filter(+ (companionPath) => companionPath === candidate.micPath,+ ),+ ),+ ),+ );+ if (companionPaths.length === 0) {+ return { paths: [], startDelayMsByPath: {} };+ }++ paths = [videoPath, ...companionPaths];+ }} else {paths = Array.from(new Set(companionCandidates.flatMap((candidate) => candidate.usablePaths)),diff --git a/electron/native/ScreenCaptureKitRecorder.swift b/electron/native/ScreenCaptureKitRecorder.swiftindex c5cd8fab..1e2a397a 100644--- a/electron/native/ScreenCaptureKitRecorder.swift+++ b/electron/native/ScreenCaptureKitRecorder.swift@@ -77,9 +77,6 @@ final class ScreenCaptureRecorder: NSObject, SCStreamOutput, SCStreamDelegate {}writesSystemAudioToSeparateTrack = capturesSystemAudiowritesMicrophoneToSeparateTrack = capturesSystemAudio && capturesMicrophone- if capturesMicrophone && !capturesSystemAudio {- writesMicrophoneToSeparateTrack = true- }let requestedFPS = max(targetCaptureFPS, config.fps ?? targetCaptureFPS)streamConfig.minimumFrameInterval = CMTime(value: 1, timescale: CMTimeScale(requestedFPS))streamConfig.queueDepth = 6diff --git a/electron/native/bin/darwin-arm64/recordly-screencapturekit-helper b/electron/native/bin/darwin-arm64/recordly-screencapturekit-helperindex 91b54570..259f1884 100755Binary files a/electron/native/bin/darwin-arm64/recordly-screencapturekit-helper and b/electron/native/bin/darwin-arm64/recordly-screencapturekit-helper differdiff --git a/electron/native/bin/darwin-x64/recordly-screencapturekit-helper b/electron/native/bin/darwin-x64/recordly-screencapturekit-helperindex 3696e45d..09e0ed5d 100755Binary files a/electron/native/bin/darwin-x64/recordly-screencapturekit-helper and b/electron/native/bin/darwin-x64/recordly-screencapturekit-helper differ