Skip to content

SWE-agent takes a GitHub issue and tries to automatically fix it, using your LM of choice. It can also be employed for offensive cybersecurity or competitive coding challenges. [NeurIPS 2024]

Critical fix: WindowedFile last line display bug (#1187)

bouhoulaae8ded6f9e7e
diff --git a/tests/tools/test_default_utils.py b/tests/tools/test_default_utils.py
index 0a1c52f2..65c33645 100644
--- a/tests/tools/test_default_utils.py
+++ b/tests/tools/test_default_utils.py
@@ -72,6 +72,8 @@ def test_windowed_file_goto(windowed_file):
wfile.goto(50, mode="top")
# first line is 50 - 10//4 = 47
assert wfile.line_range[0] == 47
+ wfile.goto(100, mode="top")
+ assert wfile.line_range[1] == 99
def test_windowed_file_scroll(windowed_file):
@@ -85,6 +87,8 @@ def test_windowed_file_scroll(windowed_file):
wfile.scroll(-100)
# Can't go lower than the middle of the lowest window
assert wfile.first_line == 0
+ wfile.scroll(100)
+ assert wfile.line_range[1] == 99
# def test_goto_command(windowed_file):
diff --git a/tools/windowed/lib/windowed_file.py b/tools/windowed/lib/windowed_file.py
index fcff90aa..fcebbefc 100644
--- a/tools/windowed/lib/windowed_file.py
+++ b/tools/windowed/lib/windowed_file.py
@@ -121,7 +121,7 @@ class WindowedFile:
def first_line(self, value: Union[int, float]):
self._original_first_line = self.first_line
value = int(value)
- self._first_line = max(0, min(value, self.n_lines - 1 - self.window))
+ self._first_line = max(0, min(value, self.n_lines - self.window))
registry["FIRST_LINE"] = self.first_line
@property