SWE-agent takes a GitHub issue and tries to automatically fix it, using your LM of choice. It can also be employed for offensive cybersecurity or competitive coding challenges. [NeurIPS 2024]
Fix(reviewer): Save review
Kilian Lieretb8d1d384634e
diff --git a/sweagent/agent/agents.py b/sweagent/agent/agents.pyindex 8375bba6..6edd59c3 100644--- a/sweagent/agent/agents.py+++ b/sweagent/agent/agents.py@@ -317,21 +317,20 @@ class RetryAgent(AbstractAgent):step_output = self.step()self.save_trajectory()if step_output.done:- self._finalize_agent_run()- if self._rloop is not None:- self._rloop.on_submit(- ReviewSubmission(- trajectory=self._agent.trajectory,- info=self._agent.info,- model_stats=self._agent.model.stats,- )+ self._rloop.on_submit(+ ReviewSubmission(+ trajectory=self._agent.trajectory,+ info=self._agent.info,+ model_stats=self._agent.model.stats,)- self._agent.info["review"] = self._rloop.reviews[-1].model_dump() # type: ignore- self.save_trajectory()- if self._rloop.retry():- assert self._env is not None- self._next_attempt()- step_output.done = False+ )+ self._agent.info["review"] = self._rloop.reviews[-1].model_dump() # type: ignore+ self._finalize_agent_run()+ self.save_trajectory()+ if self._rloop.retry():+ assert self._env is not None+ self._next_attempt()+ step_output.done = Falseself.save_trajectory() # call again after we finalizedself._chook.on_run_done(trajectory=self._agent.trajectory, info=self._agent.info)diff --git a/sweagent/agent/reviewer.py b/sweagent/agent/reviewer.pyindex e43ec042..5924a091 100644--- a/sweagent/agent/reviewer.py+++ b/sweagent/agent/reviewer.py@@ -424,9 +424,5 @@ class ScoreRetryLoop(AbstractRetryLoop):return best_indices[0]-def get_retry_loop_from_config(- config: RetryLoopConfig | None, problem_statement: ProblemStatement-) -> ScoreRetryLoop | None:- if config is None:- return None+def get_retry_loop_from_config(config: RetryLoopConfig, problem_statement: ProblemStatement) -> ScoreRetryLoop:return config.get_retry_loop(problem_statement=problem_statement)