Skip to content

🕷️ The BEST Web Scraping framework that handles everything from a single request to a full-scale crawl! Don't be shy, join here: https://discord.gg/EMgGbDceNQ and follow here for daily tips and tricks: https://x.com/Scrapling_dev

refactor(parser/find_by_regex): Better implementation for ~60% speed boost

Karim shoair37a31a120e47
diff --git a/scrapling/parser.py b/scrapling/parser.py
index f5765ca..d92ce53 100644
--- a/scrapling/parser.py
+++ b/scrapling/parser.py
@@ -943,23 +943,16 @@ class Adaptor(SelectorsGeneration):
"""
results = Adaptors([])
- def _traverse(node: Adaptor) -> None:
+ # This selector gets all elements with text content
+ for node in self.__handle_elements(self._root.xpath('//*[normalize-space(text())]')):
"""Check if element matches given regex otherwise, traverse the children tree and iterate"""
node_text = node.text
- # if there's already no text in this node, dodge it to save CPU cycles and time
- if node_text:
- if node_text.re(query, check_match=True, clean_match=clean_match, case_sensitive=case_sensitive):
- results.append(node)
+ if node_text.re(query, check_match=True, clean_match=clean_match, case_sensitive=case_sensitive):
+ results.append(node)
- if results and first_match:
+ if first_match and results:
# we got an element so we should stop
- return
-
- for branch in node.children:
- _traverse(branch)
-
- # This will block until we traverse all children/branches
- _traverse(self)
+ break
if results and first_match:
return results[0]