Skip to content

🕷️ The BEST Web Scraping framework that handles everything from a single request to a full-scale crawl! Don't be shy, join here: https://discord.gg/EMgGbDceNQ and follow here for daily tips and tricks: https://x.com/Scrapling_dev

fix(validators): Fix overriding session values with request ones

Karim shoair9e85311ff61a
diff --git a/scrapling/engines/_browsers/_validators.py b/scrapling/engines/_browsers/_validators.py
index 2b5ba0a..5442102 100644
--- a/scrapling/engines/_browsers/_validators.py
+++ b/scrapling/engines/_browsers/_validators.py
@@ -213,12 +213,12 @@ def validate_fetch(
for f in fields(_fetch_params)
if hasattr(validated_config, f.name)
}
- # solve_cloudflare defaults to False for models that don't have it (PlaywrightConfig)
validated_dict.setdefault("solve_cloudflare", False)
- validated_dict.update(result)
- return _fetch_params(**validated_dict)
+ # Start with session defaults, then overwrite with validated overrides
+ result.update(validated_dict)
+ # solve_cloudflare defaults to False for models that don't have it (PlaywrightConfig)
result.setdefault("solve_cloudflare", False)
return _fetch_params(**result)