Skip to content

ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.

fix(styles): one definition per @keyframes name

Juan Denis0b3854824dfc
diff --git a/frontend/scripts/check-frontend-boundaries.mjs b/frontend/scripts/check-frontend-boundaries.mjs
index e67ead1c..bc226660 100644
--- a/frontend/scripts/check-frontend-boundaries.mjs
+++ b/frontend/scripts/check-frontend-boundaries.mjs
@@ -171,6 +171,28 @@ for (const file of LEGACY_POLLERS.keys()) {
}
}
+// A @keyframes name is global and last-definition-wins, across every partial
+// main.scss pulls in. Two partials defining the same name is therefore not
+// duplication that merely wastes bytes: one of them is silently dead, and which
+// one depends on import order. `pulse-dot` was defined twice with genuinely
+// different animations, so the uptime dot had been running the services one for
+// as long as pages/_services was imported after components/_uptime.
+const styleFiles = walk(resolve(src, 'styles')).filter((path) => extname(path) === '.scss');
+const keyframeOwners = new Map();
+for (const path of styleFiles) {
+ const source = readFileSync(path, 'utf8');
+ for (const match of source.matchAll(/@keyframes\s+([A-Za-z0-9_-]+)/g)) {
+ const name = match[1];
+ if (!keyframeOwners.has(name)) keyframeOwners.set(name, []);
+ keyframeOwners.get(name).push(rel(path));
+ }
+}
+for (const [name, owners] of keyframeOwners) {
+ if (owners.length > 1) {
+ failures.push(`@keyframes ${name} is defined in ${owners.length} places (${owners.join(', ')}); the last one imported silently wins for all of them. Give each a scoped name or move the shared one to base/_utilities.scss.`);
+ }
+}
+
const mainStylesPath = resolve(src, 'styles', 'main.scss');
const mainStyles = readFileSync(mainStylesPath, 'utf8');
for (const ownership of EXTENSION_OWNED_STYLES) {
@@ -213,4 +235,4 @@ if (failures.length) {
process.exit(1);
}
-console.log(`✓ frontend boundaries: browser/API/dialog boundaries and ${EXTENSION_OWNED_STYLES.length} extension style ownership rule(s) hold (${LEGACY_CLIPBOARD.size} clipboard / ${LEGACY_POLLERS.size} poller files remain ratcheted).`);
+console.log(`✓ frontend boundaries: browser/API/dialog boundaries and ${EXTENSION_OWNED_STYLES.length} extension style ownership rule(s) hold (${LEGACY_CLIPBOARD.size} clipboard / ${LEGACY_POLLERS.size} poller files remain ratcheted, ${keyframeOwners.size} unique @keyframes).`);
diff --git a/frontend/src/styles/base/_utilities.scss b/frontend/src/styles/base/_utilities.scss
index 3bb8ee7b..4bca40df 100644
--- a/frontend/src/styles/base/_utilities.scss
+++ b/frontend/src/styles/base/_utilities.scss
@@ -188,6 +188,16 @@
to { transform: rotate(360deg); }
}
+@keyframes drawer-fade {
+ from { opacity: 0; }
+ to { opacity: 1; }
+}
+
+@keyframes drawer-slide {
+ from { transform: translateX(100%); }
+ to { transform: translateX(0); }
+}
+
@keyframes pulse {
0%, 100% { opacity: 1; }
50% { opacity: .5; }
diff --git a/frontend/src/styles/components/_services.scss b/frontend/src/styles/components/_services.scss
index e515240d..05a57460 100644
--- a/frontend/src/styles/components/_services.scss
+++ b/frontend/src/styles/components/_services.scss
@@ -59,7 +59,3 @@
}
}
-@keyframes pulse {
- 0%, 100% { opacity: 1; }
- 50% { opacity: 0.5; }
-}
diff --git a/frontend/src/styles/components/_uptime.scss b/frontend/src/styles/components/_uptime.scss
index 273de69f..0c0131c2 100644
--- a/frontend/src/styles/components/_uptime.scss
+++ b/frontend/src/styles/components/_uptime.scss
@@ -67,7 +67,7 @@
.status-dot {
background: $success;
box-shadow: 0 0 8px $success;
- animation: pulse-dot 2s ease-in-out infinite;
+ animation: uptime-pulse-dot 2s ease-in-out infinite;
}
}
@@ -88,7 +88,10 @@
}
}
-@keyframes pulse-dot {
+// Scoped: the panel-wide `pulse-dot` (pages/_services) is opacity-only,
+// and being imported later it silently replaced this one for every user
+// of the name. This dot wants the scale too.
+@keyframes uptime-pulse-dot {
0%, 100% {
opacity: 1;
transform: scale(1);
diff --git a/frontend/src/styles/pages/_auth.scss b/frontend/src/styles/pages/_auth.scss
index 04f0bb34..b029f888 100644
--- a/frontend/src/styles/pages/_auth.scss
+++ b/frontend/src/styles/pages/_auth.scss
@@ -169,11 +169,6 @@
}
}
-@keyframes spin {
- from { transform: rotate(0deg); }
- to { transform: rotate(360deg); }
-}
-
// Demo mode hint on the login card
.demo-hint {
margin-bottom: $space-6;
diff --git a/frontend/src/styles/pages/_cron.scss b/frontend/src/styles/pages/_cron.scss
index cffd0108..229d63e7 100644
--- a/frontend/src/styles/pages/_cron.scss
+++ b/frontend/src/styles/pages/_cron.scss
@@ -224,12 +224,6 @@
animation: spin 0.8s linear infinite;
}
-@keyframes spin {
- to {
- transform: rotate(360deg);
- }
-}
-
// ── Job drawer (row click) ──────────────────────────────────
.cron-drawer__headeractions {
display: flex;
diff --git a/frontend/src/styles/pages/_docker.scss b/frontend/src/styles/pages/_docker.scss
index 672b2038..13cc31fe 100644
--- a/frontend/src/styles/pages/_docker.scss
+++ b/frontend/src/styles/pages/_docker.scss
@@ -1916,15 +1916,6 @@
animation: drawer-slide 0.24s cubic-bezier(0.32, 0.72, 0.24, 1);
}
-@keyframes drawer-fade {
- from { opacity: 0; }
- to { opacity: 1; }
-}
-
-@keyframes drawer-slide {
- from { transform: translateX(100%); }
- to { transform: translateX(0); }
-}
@media (max-width: $breakpoint-xl) {
.dx-workspace {
diff --git a/frontend/src/styles/pages/_downloads.scss b/frontend/src/styles/pages/_downloads.scss
index 2449b7e6..4d37ba09 100644
--- a/frontend/src/styles/pages/_downloads.scss
+++ b/frontend/src/styles/pages/_downloads.scss
@@ -434,8 +434,3 @@
}
}
-@keyframes spin {
- to {
- transform: rotate(360deg);
- }
-}
diff --git a/frontend/src/styles/pages/_file-manager.scss b/frontend/src/styles/pages/_file-manager.scss
index 7b1a2ee7..db3ae7ac 100644
--- a/frontend/src/styles/pages/_file-manager.scss
+++ b/frontend/src/styles/pages/_file-manager.scss
@@ -1413,7 +1413,6 @@ $ft-default: #646b7a;
// ─── Misc ───────────────────────────────────────────
.spinning { animation: spin 1s linear infinite; }
- @keyframes spin { from { transform: rotate(0); } to { transform: rotate(360deg); } }
}
// ============================================
@@ -1450,14 +1449,6 @@ $drawer-width: 520px;
}
}
-@keyframes drawer-fade {
- from { opacity: 0; }
- to { opacity: 1; }
-}
-@keyframes drawer-slide {
- from { transform: translateX(100%); }
- to { transform: translateX(0); }
-}
.preview-drawer-header {
display: flex;
diff --git a/frontend/src/styles/pages/_migration-wizard.scss b/frontend/src/styles/pages/_migration-wizard.scss
index 7712c0f7..ec067e05 100644
--- a/frontend/src/styles/pages/_migration-wizard.scss
+++ b/frontend/src/styles/pages/_migration-wizard.scss
@@ -359,10 +359,6 @@
}
// Spin animation for loader
-@keyframes spin {
- from { transform: rotate(0deg); }
- to { transform: rotate(360deg); }
-}
.spin {
animation: spin 1s linear infinite;
diff --git a/frontend/src/styles/pages/_settings.scss b/frontend/src/styles/pages/_settings.scss
index d64432aa..2fe1c1c8 100644
--- a/frontend/src/styles/pages/_settings.scss
+++ b/frontend/src/styles/pages/_settings.scss
@@ -950,11 +950,6 @@
}
}
-@keyframes spin {
- from { transform: rotate(0deg); }
- to { transform: rotate(360deg); }
-}
-
// Star Prompt Card
.star-prompt-card {
position: relative;
diff --git a/frontend/src/styles/pages/_terminal.scss b/frontend/src/styles/pages/_terminal.scss
index bf45bef4..330ebfdc 100644
--- a/frontend/src/styles/pages/_terminal.scss
+++ b/frontend/src/styles/pages/_terminal.scss
@@ -49,7 +49,6 @@ $lk-default: #646b7a;
// Spinning animation reused by the various refresh icons
.terminal-page .spinning,
.lv-page .spinning { animation: spin 1s linear infinite; }
-@keyframes spin { from { transform: rotate(0); } to { transform: rotate(360deg); } }
// ─── Interactive terminal tab (demo console: target rail + shell pane) ───
.term-shell {