Skip to content

ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.

Truncate large telemetry payloads & UI robustness fixes

Juan Denis0e29978e7bca
diff --git a/backend/app/api/secrets_webhooks.py b/backend/app/api/secrets_webhooks.py
index 1c6c0960..0267d877 100644
--- a/backend/app/api/secrets_webhooks.py
+++ b/backend/app/api/secrets_webhooks.py
@@ -7,7 +7,8 @@ from flask_jwt_extended import get_jwt_identity, jwt_required
from app.services.secret_vault_service import SecretService, SecretVaultService
from app.services.webhook_gateway_service import WebhookGatewayService
-from app.models import Workspace
+from app.services.workspace_service import WorkspaceService
+from app.models import User, Workspace
bp = Blueprint('secrets_webhooks', __name__)
diff --git a/backend/app/services/telemetry_service.py b/backend/app/services/telemetry_service.py
index cd69aa37..8d411ef5 100644
--- a/backend/app/services/telemetry_service.py
+++ b/backend/app/services/telemetry_service.py
@@ -111,6 +111,8 @@ class TelemetryService:
severity = SystemEvent.SEVERITY_INFO
sanitized_payload = _sanitize_payload(payload) if payload is not None else None
+ if sanitized_payload is not None and _payload_too_large(sanitized_payload):
+ sanitized_payload = {'_truncated': True}
# Truncate very long messages
if message is not None and len(message) > 4000:
diff --git a/backend/tests/test_telemetry.py b/backend/tests/test_telemetry.py
index dc91174d..1caa6597 100644
--- a/backend/tests/test_telemetry.py
+++ b/backend/tests/test_telemetry.py
@@ -54,6 +54,19 @@ class TestTelemetryService:
)
assert event.severity == 'info'
+ def test_emit_truncates_oversized_payload(self, app):
+ # After sanitization each string is capped at MAX_STRING_LENGTH and each
+ # dict at MAX_DICT_ITEMS, so many large entries still exceed 32 KiB.
+ large_payload = {f'key_{i}': 'x' * 2000 for i in range(50)}
+ event = TelemetryService.emit(
+ source='test',
+ event_type='test.large',
+ payload=large_payload,
+ commit=True,
+ )
+ payload = event.get_payload()
+ assert payload == {'_truncated': True}
+
def test_emit_does_not_raise_on_failure(self, app, monkeypatch):
monkeypatch.setattr(db.session, 'commit', lambda: (_ for _ in ()).throw(Exception('boom')))
event = TelemetryService.emit(
diff --git a/frontend/src/components/Sidebar.jsx b/frontend/src/components/Sidebar.jsx
index 4418d3ec..c1eec932 100644
--- a/frontend/src/components/Sidebar.jsx
+++ b/frontend/src/components/Sidebar.jsx
@@ -158,7 +158,14 @@ const Sidebar = ({ mobileOpen = false, isMobile = false, onMobileClose = () => {
// and it defines a nav map. This lets a workspace restrict which sidebar
// items its members see based on their effective workspace role.
const activeWorkspaceRaw = localStorage.getItem('active_workspace');
- const activeWorkspace = activeWorkspaceRaw ? JSON.parse(activeWorkspaceRaw) : null;
+ let activeWorkspace = null;
+ if (activeWorkspaceRaw) {
+ try {
+ activeWorkspace = JSON.parse(activeWorkspaceRaw);
+ } catch {
+ activeWorkspace = null;
+ }
+ }
return applyWorkspaceNavPermissions(items, activeWorkspace, user);
}, [user?.sidebar_config, pluginNav, wpInstalled, gpuAvailable, user]);
diff --git a/frontend/src/contexts/NotificationsContext.jsx b/frontend/src/contexts/NotificationsContext.jsx
index c8847032..d766d7bd 100644
--- a/frontend/src/contexts/NotificationsContext.jsx
+++ b/frontend/src/contexts/NotificationsContext.jsx
@@ -37,6 +37,7 @@ export function NotificationsProvider({ children }) {
useEffect(() => {
if (!isAuthenticated) {
+ socketService.disconnect();
setItems([]);
setUnreadCount(0);
return undefined;