Skip to content

ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.

Let extensions listen for core events in process

Juan Denis0e497f6def0d
diff --git a/backend/app/services/deployment_service.py b/backend/app/services/deployment_service.py
index c1afea17..6628af66 100644
--- a/backend/app/services/deployment_service.py
+++ b/backend/app/services/deployment_service.py
@@ -218,6 +218,21 @@ class DeploymentService:
if log_callback:
log_callback(f"Deployment successful! Version {deployment.version} is now live.")
+ # app.deployed was in the event catalog but nothing emitted it.
+ # Webhook subscribers and in-process listeners (a CDN purge,
+ # plan 86 §B4) hear it now. Best-effort: never fails the deploy.
+ try:
+ from app.services.event_service import EventService
+ EventService.emit('app.deployed', {
+ 'event': 'app.deployed',
+ 'timestamp': datetime.utcnow().isoformat(),
+ 'app_id': app.id, 'app_name': app.name,
+ 'version': deployment.version, 'deployment_id': deployment.id,
+ 'domains': [d.name for d in app.live_domains if d.name],
+ }, user_id)
+ except Exception as exc: # noqa: BLE001
+ logger.warning('app.deployed emit failed for app %s: %s', app.id, exc)
+
return {
'success': True,
'deployment': deployment.to_dict()
diff --git a/backend/app/services/event_service.py b/backend/app/services/event_service.py
index edc651bf..dcc8dc96 100644
--- a/backend/app/services/event_service.py
+++ b/backend/app/services/event_service.py
@@ -112,6 +112,40 @@ def unregister_event_types(source):
return len(doomed)
+# In-process listeners (plan 86 §B4): the extension-to-core event path. An
+# extension's core_hooks registers a callable for an event type; every emit of
+# that type calls it with the payload, best-effort, whether or not any webhook
+# subscription exists. event type -> [(fn, source slug)].
+_LISTENERS = {}
+
+
+def register_listener(event_type, fn, source=None):
+ """Call ``fn(payload)`` on every ``event_type`` emit. Idempotent per
+ (event type, fn) so per-boot re-registration never doubles a call."""
+ entries = _LISTENERS.setdefault(event_type, [])
+ if any(existing is fn for existing, _ in entries):
+ return
+ entries.append((fn, source))
+
+
+def unregister_listeners(source):
+ """Drop every listener ``source`` registered (disable/uninstall)."""
+ removed = 0
+ for event_type in list(_LISTENERS):
+ kept = [(fn, s) for fn, s in _LISTENERS[event_type] if s != source]
+ removed += len(_LISTENERS[event_type]) - len(kept)
+ _LISTENERS[event_type] = kept
+ return removed
+
+
+def _notify_listeners(event_type, payload):
+ for fn, source in list(_LISTENERS.get(event_type, [])):
+ try:
+ fn(payload)
+ except Exception as e: # noqa: BLE001 - a listener never breaks the emitter
+ logger.warning(f'Event listener from {source} failed on {event_type}: {e}')
+
+
def clear_registered_event_types():
"""Drop every extension-registered event type. Tests only."""
_EXTENSION_EVENT_TYPES.clear()
@@ -144,7 +178,8 @@ class EventService:
@staticmethod
def emit(event_type, payload, user_id=None):
- """Emit an event to all matching subscriptions."""
+ """Emit an event to in-process listeners and all matching subscriptions."""
+ _notify_listeners(event_type, payload)
subscriptions = EventSubscription.query.filter_by(is_active=True).all()
matching = [s for s in subscriptions if s.matches_event(event_type)]
diff --git a/backend/app/services/extension_lifecycle.py b/backend/app/services/extension_lifecycle.py
index 7231e029..2af64b1a 100644
--- a/backend/app/services/extension_lifecycle.py
+++ b/backend/app/services/extension_lifecycle.py
@@ -220,6 +220,7 @@ def unregister_capabilities(plugin):
try:
from app.services import event_service
event_service.unregister_event_types(slug)
+ event_service.unregister_listeners(slug)
except Exception as e:
logger.warning(f'Event-type teardown failed for {slug}: {e}')
try:
diff --git a/backend/tests/test_event_listeners.py b/backend/tests/test_event_listeners.py
new file mode 100644
index 00000000..aa6e3c9d
--- /dev/null
+++ b/backend/tests/test_event_listeners.py
@@ -0,0 +1,55 @@
+"""In-process event listeners: the extension-to-core event path (plan 86 §B4)."""
+from app.services import event_service
+from app.services.event_service import EventService
+
+
+def test_listeners_hear_emits_without_any_webhook_subscription(app):
+ heard = []
+ event_service.register_listener('app.deployed', heard.append, source='ext-a')
+ try:
+ EventService.emit('app.deployed', {'app_id': 7})
+ EventService.emit('app.other', {'app_id': 8})
+ finally:
+ event_service.unregister_listeners('ext-a')
+ assert heard == [{'app_id': 7}]
+
+
+def test_registering_twice_calls_once(app):
+ heard = []
+ fn = heard.append
+ event_service.register_listener('app.deployed', fn, source='ext-a')
+ event_service.register_listener('app.deployed', fn, source='ext-a')
+ try:
+ EventService.emit('app.deployed', {'n': 1})
+ finally:
+ event_service.unregister_listeners('ext-a')
+ assert heard == [{'n': 1}]
+
+
+def test_a_failing_listener_never_breaks_the_emit(app):
+ heard = []
+
+ def boom(payload):
+ raise RuntimeError('listener bug')
+ event_service.register_listener('app.deployed', boom, source='ext-a')
+ event_service.register_listener('app.deployed', heard.append, source='ext-b')
+ try:
+ EventService.emit('app.deployed', {'n': 1})
+ finally:
+ event_service.unregister_listeners('ext-a')
+ event_service.unregister_listeners('ext-b')
+ assert heard == [{'n': 1}]
+
+
+def test_teardown_drops_only_that_extensions_listeners(app):
+ from types import SimpleNamespace
+ from app.services.extension_lifecycle import unregister_capabilities
+ heard_a, heard_b = [], []
+ event_service.register_listener('app.deployed', heard_a.append, source='ext-a')
+ event_service.register_listener('app.deployed', heard_b.append, source='ext-b')
+ try:
+ unregister_capabilities(SimpleNamespace(slug='ext-a'))
+ EventService.emit('app.deployed', {'n': 1})
+ finally:
+ event_service.unregister_listeners('ext-b')
+ assert heard_a == [] and heard_b == [{'n': 1}]
diff --git a/backend/tests/test_git_compose_deploy.py b/backend/tests/test_git_compose_deploy.py
index 07644d15..2e22445c 100644
--- a/backend/tests/test_git_compose_deploy.py
+++ b/backend/tests/test_git_compose_deploy.py
@@ -212,3 +212,22 @@ def test_pull_reaches_a_branch_the_single_branch_clone_never_fetched(tmp_path, m
result = GitService.pull_changes(str(work), 'next')
assert result['success'], result
assert (work / 'VERSION').read_text() == '1.0.1\n'
+
+
+def test_a_successful_deploy_emits_app_deployed(app, calls):
+ """The extension-to-core path (plan 86 §B4): listeners hear every deploy."""
+ from app.models.domain import Domain
+ from app.services import event_service
+ heard = []
+ row = _app()
+ db.session.add(Domain(name='bench.lvh.me', application_id=row.id, is_primary=True))
+ db.session.commit()
+ listener = heard.append
+ event_service.register_listener('app.deployed', listener, source='test-ext')
+ try:
+ assert DeploymentService.deploy(row.id)['success']
+ finally:
+ event_service.unregister_listeners('test-ext')
+ (payload,) = heard
+ assert payload['app_id'] == row.id and payload['domains'] == ['bench.lvh.me']
+ assert payload['version'] >= 1