ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.
Python astracloudflarecontrol-panelcyberpaneldnsfablehosting-control-panelhosting-panelkimi-k3server-managementserverkitubuntu-web-panelwebserver
refactor(themes): registry install raises typed errors
Juan Denis28dcd63f4d14
diff --git a/backend/app/api/themes.py b/backend/app/api/themes.pyindex a8927e9e..304a3f2f 100644--- a/backend/app/api/themes.py+++ b/backend/app/api/themes.py@@ -153,10 +153,7 @@ def install_registry(slug):validates it server-side, and stores it — no zips, no checksums."""user = require_admin_user()from app.services import theme_registry_service- theme, ierr = theme_registry_service.install(slug)- if ierr:- code = 404 if 'not found' in ierr.lower() else 400- return jsonify({'error': ierr}), code+ theme = theme_registry_service.install(slug)AuditService.log(action=AuditLog.ACTION_RESOURCE_CREATE,user_id=user.id,diff --git a/backend/app/services/theme_registry_service.py b/backend/app/services/theme_registry_service.pyindex 555759c6..157d5007 100644--- a/backend/app/services/theme_registry_service.py+++ b/backend/app/services/theme_registry_service.py@@ -22,6 +22,11 @@ from urllib.parse import urljoinimport requests+from app.exceptions import (+ DependencyUnavailableError,+ NotFoundError,+ ValidationError,+)from app.models.theme import Themefrom app.services import theme_service@@ -188,13 +193,13 @@ def registry_source_label():def install(slug):"""Fetch a registry theme's full theme.json, validate it, and store it.- Returns ``(theme_dict, error)``."""+ Returns the theme dict; raises typed application errors."""entry = get_entry(slug)if entry is None:- return None, 'Theme not found in the registry'+ raise NotFoundError('Theme not found in the registry')theme_url = entry.get('_theme_url')if not theme_url:- return None, 'Registry entry has no theme file'+ raise ValidationError('Registry entry has no theme file')try:resp = requests.get(theme_url, timeout=15, headers={'Accept': 'application/json',@@ -204,8 +209,12 @@ def install(slug):raw = resp.json()except Exception as e:logger.warning('Fetching theme %s failed (%s): %s', slug, theme_url, e)- return None, 'Could not download the theme from the registry'+ raise DependencyUnavailableError(+ 'Could not download the theme from the registry') from e# The registry index and the theme file must agree on the slug.if isinstance(raw, dict) and raw.get('slug') and raw['slug'] != slug:- return None, 'Registry theme slug mismatch'- return theme_service.import_theme(raw, source='registry')+ raise ValidationError('Registry theme slug mismatch')+ theme, err = theme_service.import_theme(raw, source='registry')+ if err:+ raise ValidationError(err)+ return themediff --git a/backend/tests/STATUS_SNIFFING_CEILING b/backend/tests/STATUS_SNIFFING_CEILINGindex 7f8f011e..1e8b3149 100644--- a/backend/tests/STATUS_SNIFFING_CEILING+++ b/backend/tests/STATUS_SNIFFING_CEILING@@ -1 +1 @@-7+6