ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.
Python astracloudflarecontrol-panelcyberpaneldnsfablehosting-control-panelhosting-panelkimi-k3server-managementserverkitubuntu-web-panelwebserver
fix(env-vars): let an explicit null clear a variable's description
Juan Denis41266dd8ee3a
diff --git a/backend/app/api/env_vars.py b/backend/app/api/env_vars.pyindex 5d8f4e96..ea2f823f 100644--- a/backend/app/api/env_vars.py+++ b/backend/app/api/env_vars.py@@ -132,8 +132,10 @@ def update_env_var(app_id, key):updates['value'] = data['value']if data.get('is_secret') is not None:updates['is_secret'] = data['is_secret']- if data.get('description') is not None:- updates['description'] = data['description']+ # Key-presence, not non-null: an explicit JSON null clears the+ # description (the service's _UNSET sentinel keeps absent = untouched).+ if 'description' in data:+ updates['description'] = data.get('description')if 'target_service' in data:updates['target_service'] = data.get('target_service')diff --git a/backend/tests/test_env_vars_api.py b/backend/tests/test_env_vars_api.pynew file mode 100644index 00000000..bc16ce70--- /dev/null+++ b/backend/tests/test_env_vars_api.py@@ -0,0 +1,45 @@+"""PUT /apps/<id>/env/<key> partial-update semantics at the route boundary.++The service door (EnvService.update_env_var) distinguishes "field absent"+(_UNSET, leave untouched) from "field explicitly null" (clear it). The route+must preserve that distinction for description: a JSON null clears, an omitted+key leaves the stored text alone.+"""+from app import db+from app.models import Application+++def _seed_var(app):+ from app.services.env_service import EnvService+ from factories import make_application, make_user++ user = make_user(db, role='admin')+ application = make_application(db, name='env-api-app', user_id=user.id)+ EnvService.set_env_var(+ application.id, 'API_URL', 'https://api.example.test',+ description='where the API lives', user_id=user.id,+ )+ return application, user+++def test_null_description_clears_but_omitted_leaves_it(app, client):+ from factories import headers_for++ with app.app_context():+ application, user = _seed_var(app)+ headers = headers_for(user)+ app_id = application.id++ # Omitting description entirely must not touch it.+ res = client.put(f'/api/v1/apps/{app_id}/env/API_URL',+ json={'value': 'https://api2.example.test'},+ headers=headers)+ assert res.status_code == 200+ assert res.get_json()['env_var']['description'] == 'where the API lives'++ # An explicit JSON null clears it.+ res = client.put(f'/api/v1/apps/{app_id}/env/API_URL',+ json={'description': None},+ headers=headers)+ assert res.status_code == 200+ assert res.get_json()['env_var']['description'] is None