Skip to content

ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.

fix(buildpack): keep devDependencies when a node app has a build step

Juan Denis4c95a7da9f1e
diff --git a/backend/app/services/buildpack_service.py b/backend/app/services/buildpack_service.py
index 1bdb26f1..b6d8317c 100644
--- a/backend/app/services/buildpack_service.py
+++ b/backend/app/services/buildpack_service.py
@@ -513,10 +513,20 @@ class BuildpackService:
f'# syntax=docker/dockerfile:1',
f'FROM node:{version}-slim',
'WORKDIR /app',
+ # Locally installed CLIs (vite, next, nest, ...) live in
+ # node_modules/.bin, which is not on PATH for RUN/CMD.
+ 'ENV PATH=/app/node_modules/.bin:$PATH',
'COPY package*.json ./',
- 'RUN npm install --omit=dev || npm install',
- 'COPY . .',
]
+ if build:
+ # Build tooling (vite, tsc, webpack) is almost always a
+ # devDependency, and so is the server for preview-style start
+ # commands -- install the full dependency set. `--omit=dev`
+ # exits 0, so a `|| npm install` fallback would never fire.
+ lines.append('RUN npm install')
+ else:
+ lines.append('RUN npm install --omit=dev || npm install')
+ lines.append('COPY . .')
if build:
lines.append(f'RUN {build}')
lines += [
diff --git a/backend/tests/test_buildpacks.py b/backend/tests/test_buildpacks.py
index cd46ce99..45260d1b 100644
--- a/backend/tests/test_buildpacks.py
+++ b/backend/tests/test_buildpacks.py
@@ -143,6 +143,35 @@ def test_generate_dockerfile_node():
assert 'server.js' in df
+def test_generate_dockerfile_node_build_keeps_dev_dependencies():
+ """A build step needs devDependencies (vite, tsc, ...).
+
+ `npm install --omit=dev` exits 0, so an `|| npm install` fallback never
+ fires and `npm run build` dies with `vite: not found`.
+ """
+ plan = {
+ 'builder': 'nixpacks', 'language': 'node', 'framework': 'vite',
+ 'versions': {'node': '24'}, 'build_command': 'npm run build',
+ 'start_command': 'vite preview --host --port 4173', 'port': 4173,
+ }
+ df = BuildpackService.generate_dockerfile(plan)
+ assert '--omit=dev' not in df
+ assert 'RUN npm install\n' in df
+ # Locally installed CLIs are only reachable via node_modules/.bin.
+ assert 'ENV PATH=/app/node_modules/.bin:$PATH' in df
+ assert df.index('RUN npm install\n') < df.index('RUN npm run build')
+
+
+def test_generate_dockerfile_node_without_build_omits_dev():
+ plan = {
+ 'builder': 'nixpacks', 'language': 'node', 'framework': 'express',
+ 'versions': {'node': '20'}, 'start_command': 'node server.js',
+ 'port': 3000,
+ }
+ df = BuildpackService.generate_dockerfile(plan)
+ assert 'RUN npm install --omit=dev || npm install' in df
+
+
def test_generate_dockerfile_python():
plan = {
'builder': 'nixpacks', 'language': 'python', 'framework': 'flask',