Skip to content

ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.

fix(ui): rename the page shell off `.sk-page` (name collision)

Juan Denis4effb201f476
diff --git a/docs/screenshots/terminal-logs.png b/docs/screenshots/terminal-logs.png
index e3bec950..56ce5142 100644
Binary files a/docs/screenshots/terminal-logs.png and b/docs/screenshots/terminal-logs.png differ
diff --git a/frontend/src/layouts/PageLayout.jsx b/frontend/src/layouts/PageLayout.jsx
index 85b1a386..7766a21c 100644
--- a/frontend/src/layouts/PageLayout.jsx
+++ b/frontend/src/layouts/PageLayout.jsx
@@ -33,7 +33,7 @@ export default function PageLayout({
children,
}) {
return (
- <div className={cn('page-container page-container--full-bleed sk-page', className)}>
+ <div className={cn('page-container page-container--full-bleed sk-pageshell', className)}>
<PageTopbar
className={topbarClassName}
icon={icon}
@@ -43,11 +43,11 @@ export default function PageLayout({
navLabel={navLabel}
actions={actions}
/>
- <div className="sk-page__content">
+ <div className="sk-pageshell__content">
{fill ? (
- <div className={cn('sk-page__fill', contentClassName)}>{children}</div>
+ <div className={cn('sk-pageshell__fill', contentClassName)}>{children}</div>
) : (
- <div className={cn('sk-page__inner', contentClassName)}>{children}</div>
+ <div className={cn('sk-pageshell__inner', contentClassName)}>{children}</div>
)}
</div>
</div>
diff --git a/frontend/src/styles/layout/_main-content.scss b/frontend/src/styles/layout/_main-content.scss
index bea6c6b6..102d3cd5 100644
--- a/frontend/src/styles/layout/_main-content.scss
+++ b/frontend/src/styles/layout/_main-content.scss
@@ -80,7 +80,7 @@
// ============================================================
// PAGE SHELL
// The one frame every page gets, in two flavours:
-// .sk-page — a standalone page (layouts/PageLayout.jsx)
+// .sk-pageshell — a standalone page (layouts/PageLayout.jsx)
// .sk-tabgroup — a routed tab group (layouts/TabGroupLayout.jsx)
// Both are full-bleed so the top bar pins flush to the top of the content
// region and the body scrolls beneath it. A page should never hand-roll this:
@@ -125,7 +125,10 @@
}
// Standalone pages (Cron Jobs, Settings, Documentation, …).
-.sk-page {
+// NOT `.sk-page` — components/PageSkeleton.jsx already owns that name for its
+// loading archetypes, and its `gap: 16px` leaked in as a band of page
+// background between the top bar and the content on every shell page.
+.sk-pageshell {
@include page-shell;
&__content {
@@ -133,7 +136,7 @@
// `fill` bodies (terminals, consoles, trees) take the whole region and
// manage their own scroll instead of riding the centered column.
- > .sk-page__fill { flex: 1; min-height: 0; }
+ > .sk-pageshell__fill { flex: 1; min-height: 0; }
}
&__inner { @include page-shell-inner; }