ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.
Python astracloudflarecontrol-panelcyberpaneldnsfablehosting-control-panelhosting-panelkimi-k3server-managementserverkitubuntu-web-panelwebserver
fix(pairing): require developer role for claim/lookup (audit L1)
Juan Denis75db46609654
diff --git a/backend/app/api/pairing.py b/backend/app/api/pairing.pyindex f1248b10..b01d20fe 100644--- a/backend/app/api/pairing.py+++ b/backend/app/api/pairing.py@@ -6,8 +6,8 @@ Endpoints:POST /api/v1/pairing/code/refresh (enrollment auth)POST /api/v1/pairing/code/freeze (enrollment auth)GET /api/v1/pairing/poll (enrollment auth, long-poll)- POST /api/v1/pairing/claim (operator JWT)- GET /api/v1/pairing/lookup (operator JWT — pre-flight code check)+ POST /api/v1/pairing/claim (operator JWT, developer role)+ GET /api/v1/pairing/lookup (operator JWT, developer role — pre-flight code check)"""import time@@ -15,6 +15,7 @@ from flask import Blueprint, request, jsonify, current_appfrom flask_jwt_extended import jwt_required, get_jwt_identityfrom app import limiter+from app.middleware.rbac import developer_requiredfrom app.services import pairing_servicefrom app.services.pairing_service import (PairingError,@@ -145,6 +146,7 @@ def poll():@pairing_bp.route('/lookup', methods=['POST'])@jwt_required()+@developer_required@limiter.limit("20 per minute")def lookup():"""Pre-flight: confirm a code exists (without revealing details)."""@@ -163,6 +165,7 @@ def lookup():@pairing_bp.route('/claim', methods=['POST'])@jwt_required()+@developer_required@limiter.limit("5 per 10 minute")def claim():user_id = int(get_jwt_identity())diff --git a/backend/tests/test_pairing_authz.py b/backend/tests/test_pairing_authz.pynew file mode 100644index 00000000..d8704fa8--- /dev/null+++ b/backend/tests/test_pairing_authz.py@@ -0,0 +1,50 @@+"""+Authorization test for audit L1: pairing claim/lookup create or reveal fleet+servers, so they should require developer role for consistency with+POST /api/v1/servers (@developer_required) — not just any authenticated user.+"""+from flask_jwt_extended import create_access_token+from werkzeug.security import generate_password_hash++from app import db+from app.models import User+++def _user(role):+ u = User(+ email=f"{role}@pair.local",+ username=f"{role}-pair",+ password_hash=generate_password_hash("x"),+ role=role,+ is_active=True,+ )+ db.session.add(u)+ db.session.commit()+ return u+++def _headers(user):+ return {"Authorization": f"Bearer {create_access_token(identity=user.id)}"}+++def test_viewer_cannot_lookup_or_claim(client, app):+ with app.app_context():+ headers = _headers(_user(User.ROLE_VIEWER))++ r1 = client.post("/api/v1/pairing/lookup", headers=headers, json={"code": "ABC123"})+ assert r1.status_code == 403, r1.get_data(as_text=True)++ r2 = client.post("/api/v1/pairing/claim", headers=headers,+ json={"code": "ABC123", "passphrase": "pw"})+ assert r2.status_code == 403, r2.get_data(as_text=True)+++def test_developer_clears_the_role_gate(client, app):+ """A developer passes the role gate; lookup then 404s (no such code),+ which proves the gate let them through rather than blocking with 403."""+ with app.app_context():+ headers = _headers(_user(User.ROLE_DEVELOPER))++ r = client.post("/api/v1/pairing/lookup", headers=headers, json={"code": "NOSUCH"})+ assert r.status_code != 403, r.get_data(as_text=True)+ assert r.status_code == 404, r.get_data(as_text=True)