Skip to content

ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.

Guard the remaining Docker tabs against stale loads

Juan Denis84ac8684e31b
diff --git a/frontend/scripts/docker-tabs-browser.mjs b/frontend/scripts/docker-tabs-browser.mjs
index 73b92f12..45a5ac17 100644
--- a/frontend/scripts/docker-tabs-browser.mjs
+++ b/frontend/scripts/docker-tabs-browser.mjs
@@ -18,19 +18,30 @@ import {MemoryRouter} from 'react-router-dom';
import {ServerContext} from '/src/components/docker/dockerHelpers.js';
import ContainersTab from '/src/components/docker/ContainersTab.jsx';
import ImagesTab from '/src/components/docker/ImagesTab.jsx';
+import VolumesTab from '/src/components/docker/VolumesTab.jsx';
+import NetworksTab from '/src/components/docker/NetworksTab.jsx';
+import ComposeTab from '/src/components/docker/ComposeTab.jsx';
window.pending=[];
const hold=(server,kind)=>new Promise((resolve,reject)=>window.pending.push({server,kind,resolve,reject}));
window.release=(server,kind,ok=true)=>{const i=window.pending.findIndex(p=>p.server===server&&p.kind===kind);const p=window.pending.splice(i,1)[0];
- const row=kind==='containers'?{data:[{id:server+'-c',name:server+'-web',image:'nginx',status:'Up',state:'running'}]}:{data:[{id:server+'-i',repository:server+'-repo',tag:'latest',size:'1MB'}]};
+ const rows={containers:[{id:server+'-c',name:server+'-web',image:'nginx',status:'Up',state:'running'}],
+ images:[{id:server+'-i',repository:server+'-repo',tag:'latest',size:'1MB'}],
+ volumes:[{name:server+'-vol',driver:'local'}],
+ networks:[{id:server+'-n',name:server+'-net',driver:'bridge'}],
+ compose:[{name:server+'-stack',status:'running(1)'}]};
+ const row={data:rows[kind]};
ok?p.resolve({success:true,...row}):p.reject(new Error('Docker is not reachable: daemon down'));};
window.testApi={
getRemoteContainers:(server)=>hold(server,'containers'),
getRemoteImages:(server)=>hold(server,'images'),
+ getRemoteVolumes:(server)=>hold(server,'volumes'),
+ getRemoteNetworks:(server)=>hold(server,'networks'),
+ getRemoteComposeProjects:(server)=>hold(server,'compose'),
getRemoteContainerStats:()=>Promise.resolve({}),
getContainersStats:()=>Promise.resolve({}),
};
function App(){const [server,setServer]=useState('alpha');window.setServer=setServer;const tab=new URLSearchParams(location.search).get('tab');
- return <ServerContext.Provider value={{serverId:server,serverName:server,isRemote:true}}>{tab==='images'?<ImagesTab/>:<ContainersTab/>}</ServerContext.Provider>}
+ return <ServerContext.Provider value={{serverId:server,serverName:server,isRemote:true}}>{({images:<ImagesTab/>,volumes:<VolumesTab/>,networks:<NetworksTab/>,compose:<ComposeTab/>})[tab]||<ContainersTab/>}</ServerContext.Provider>}
createRoot(document.getElementById('root')).render(<MemoryRouter><App/></MemoryRouter>);
`;
const server = await createServer({
@@ -71,7 +82,8 @@ try {
page.on('pageerror', error => errors.push(error.message));
const base = `http://127.0.0.1:${server.httpServer.address().port}/docker-check`;
- for (const [tab, kind, label] of [['containers', 'containers', 'web'], ['images', 'images', 'repo']]) {
+ for (const [tab, kind, label] of [['containers', 'containers', 'web'], ['images', 'images', 'repo'], ['volumes', 'volumes', 'vol'],
+ ['networks', 'networks', 'net'], ['compose', 'compose', 'stack']]) {
await page.goto(`${base}?tab=${tab}`);
await waitPending(page, 'alpha', kind);
await page.evaluate(() => window.setServer('beta'));
diff --git a/frontend/src/components/docker/ComposeTab.jsx b/frontend/src/components/docker/ComposeTab.jsx
index 3ffeadc5..47cb94af 100644
--- a/frontend/src/components/docker/ComposeTab.jsx
+++ b/frontend/src/components/docker/ComposeTab.jsx
@@ -1,8 +1,9 @@
-import { useState, useEffect, useMemo, useCallback } from 'react';
+import { useState, useEffect, useMemo, useCallback, useRef } from 'react';
import api from '../../services/api';
import { useToast } from '../../contexts/useToast.js';
import { useConfirm } from '../../hooks/useConfirm';
import EmptyState from '../EmptyState';
+import { ErrorState } from '../ErrorState';
import Modal from '@/components/Modal';
import { DataTable, DataTableFooter, SearchField } from '@/components/ds';
import {
@@ -106,12 +107,18 @@ const ComposeTab = ({ onStatsChange }) => {
storageKey: 'serverkit-table-docker-compose-cols',
});
+ // Only the newest load may write: see ContainersTab.
+ const loadSeq = useRef(0);
+ const [loadError, setLoadError] = useState(null);
+
useEffect(() => {
loadProjects();
}, [serverId]); // eslint-disable-line react-hooks/exhaustive-deps
async function loadProjects() {
+ const seq = ++loadSeq.current;
setLoading(true);
+ setLoadError(null);
try {
let data;
if (isRemote) {
@@ -119,11 +126,13 @@ const ComposeTab = ({ onStatsChange }) => {
} else {
data = await api.composeList();
}
+ if (seq !== loadSeq.current) return;
setProjects(normalizeListResponse(data, 'projects'));
+ setLoading(false);
} catch (err) {
- console.error('Failed to load compose projects:', err);
+ if (seq !== loadSeq.current) return;
setProjects([]);
- } finally {
+ setLoadError(err);
setLoading(false);
}
}
@@ -395,7 +404,9 @@ const ComposeTab = ({ onStatsChange }) => {
<GridChips {...chrome.chipProps} />
- {filteredProjects.length === 0 ? (
+ {loadError ? (
+ <ErrorState error={loadError} onRetry={loadProjects} />
+ ) : filteredProjects.length === 0 ? (
<EmptyState
icon={Package}
title={projects.length === 0 ? t('app.composeTab.noComposeProjects', 'No compose projects') : t('app.composeTab.noMatchingProjects', 'No matching compose projects')}
diff --git a/frontend/src/components/docker/NetworksTab.jsx b/frontend/src/components/docker/NetworksTab.jsx
index 1069fe74..aec32e74 100644
--- a/frontend/src/components/docker/NetworksTab.jsx
+++ b/frontend/src/components/docker/NetworksTab.jsx
@@ -1,8 +1,9 @@
-import { useState, useEffect, useMemo, useCallback } from 'react';
+import { useState, useEffect, useMemo, useCallback, useRef } from 'react';
import api from '../../services/api';
import { useToast } from '../../contexts/useToast.js';
import { useConfirm } from '../../hooks/useConfirm';
import EmptyState from '../EmptyState';
+import { ErrorState } from '../ErrorState';
import Modal from '@/components/Modal';
import { DataTable, DataTableFooter, Pill, SearchField, SegControl } from '@/components/ds';
import {
@@ -114,12 +115,18 @@ const NetworksTab = ({ onStatsChange }) => {
});
const [groupBy, setGroupBy] = useState(null);
+ // Only the newest load may write: see ContainersTab.
+ const loadSeq = useRef(0);
+ const [loadError, setLoadError] = useState(null);
+
useEffect(() => {
loadNetworks();
}, [serverId]); // eslint-disable-line react-hooks/exhaustive-deps
async function loadNetworks() {
+ const seq = ++loadSeq.current;
setLoading(true);
+ setLoadError(null);
try {
let data;
if (isRemote) {
@@ -128,10 +135,13 @@ const NetworksTab = ({ onStatsChange }) => {
} else {
data = await api.getNetworks();
}
+ if (seq !== loadSeq.current) return;
setNetworks(data.networks || []);
+ setLoading(false);
} catch (err) {
- console.error('Failed to load networks:', err);
- } finally {
+ if (seq !== loadSeq.current) return;
+ setNetworks([]);
+ setLoadError(err);
setLoading(false);
}
}
@@ -314,7 +324,9 @@ const NetworksTab = ({ onStatsChange }) => {
<GridChips {...chrome.chipProps} />
- {filteredNetworks.length === 0 ? (
+ {loadError ? (
+ <ErrorState error={loadError} onRetry={loadNetworks} />
+ ) : filteredNetworks.length === 0 ? (
<EmptyState
icon={NetworkIcon}
title={networks.length === 0 ? t('app.networksTab.noNetworks', 'No networks') : t('app.networksTab.noMatchingNetworks', 'No matching networks')}
diff --git a/frontend/src/components/docker/VolumesTab.jsx b/frontend/src/components/docker/VolumesTab.jsx
index 73b88ef8..d60fe13e 100644
--- a/frontend/src/components/docker/VolumesTab.jsx
+++ b/frontend/src/components/docker/VolumesTab.jsx
@@ -1,8 +1,9 @@
-import { useState, useEffect, useMemo, useCallback } from 'react';
+import { useState, useEffect, useMemo, useCallback, useRef } from 'react';
import api from '../../services/api';
import { useToast } from '../../contexts/useToast.js';
import { useConfirm } from '../../hooks/useConfirm';
import EmptyState from '../EmptyState';
+import { ErrorState } from '../ErrorState';
import Modal from '@/components/Modal';
import { DataTable, DataTableFooter, Pill, SearchField } from '@/components/ds';
import {
@@ -118,12 +119,18 @@ const VolumesTab = ({ onStatsChange }) => {
});
const [groupBy, setGroupBy] = useState(null);
+ // Only the newest load may write: see ContainersTab.
+ const loadSeq = useRef(0);
+ const [loadError, setLoadError] = useState(null);
+
useEffect(() => {
loadVolumes();
}, [serverId]); // eslint-disable-line react-hooks/exhaustive-deps
async function loadVolumes() {
+ const seq = ++loadSeq.current;
setLoading(true);
+ setLoadError(null);
try {
let data;
if (isRemote) {
@@ -132,10 +139,13 @@ const VolumesTab = ({ onStatsChange }) => {
} else {
data = await api.getVolumes();
}
+ if (seq !== loadSeq.current) return;
setVolumes(data.volumes || []);
+ setLoading(false);
} catch (err) {
- console.error('Failed to load volumes:', err);
- } finally {
+ if (seq !== loadSeq.current) return;
+ setVolumes([]);
+ setLoadError(err);
setLoading(false);
}
}
@@ -310,7 +320,9 @@ const VolumesTab = ({ onStatsChange }) => {
<GridChips {...chrome.chipProps} />
- {filteredVolumes.length === 0 ? (
+ {loadError ? (
+ <ErrorState error={loadError} onRetry={loadVolumes} />
+ ) : filteredVolumes.length === 0 ? (
<EmptyState
icon={HardDrive}
title={volumes.length === 0 ? t('app.volumesTab.noVolumes', 'No volumes') : t('app.volumesTab.noMatchingVolumes', 'No matching volumes')}