ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.
Python astracloudflarecontrol-panelcyberpaneldnsfablehosting-control-panelhosting-panelkimi-k3server-managementserverkitubuntu-web-panelwebserver
test(extensions): fail when a bundled extension's two copies diverge
Juan Denis980ec0c3f280
diff --git a/backend/tests/test_builtin_extension_drift.py b/backend/tests/test_builtin_extension_drift.pynew file mode 100644index 00000000..58a654ed--- /dev/null+++ b/backend/tests/test_builtin_extension_drift.py@@ -0,0 +1,123 @@+"""Bundled extensions exist twice on disk. The copies must not diverge.++``builtin-extensions/<ext>/backend/`` is the source of truth;+``backend/app/plugins/<ext>/`` is the live copy the loader imports. A fix+applied to one and not the other ships a repo that looks correct and a panel+that behaves like the old code.++This is not hypothetical: the plan-74 round fixed `dovecot_service.get_status()`+and the identical edit had to be made twice. Nothing but discipline caught it,+which is exactly the kind of guarantee that fails on a busy day.++Written while drift is **zero** (21 file pairs). That is the point — this locks+in a clean invariant rather than repairing a dirty one, and it only stays cheap+while that is true.++Scope note: only pairs present on BOTH sides are compared. Several extensions+legitimately have one side only — cloudflare-ops and localkit ship source with+no materialised live copy, serverkit-git uses a different layout — and most live+copies are gitignored, so a fresh clone sees fewer pairs than a dev machine.+`test_drift_check_is_not_vacuous` stops that from quietly reducing to nothing.+"""++import hashlib+from pathlib import Path++import pytest++REPO = Path(__file__).resolve().parent.parent.parent+SOURCE_ROOT = REPO / 'builtin-extensions'+LIVE_ROOT = REPO / 'backend' / 'app' / 'plugins'+++def _normalised_hash(path):+ """Content hash ignoring line endings — the repo has mixed CRLF/LF."""+ data = path.read_bytes().replace(b'\r\n', b'\n')+ return hashlib.sha256(data).hexdigest()+++def _python_files(root):+ """{relative path: absolute path} for every .py under *root*."""+ if not root.is_dir():+ return {}+ return {+ p.relative_to(root).as_posix(): p+ for p in root.rglob('*.py')+ if '__pycache__' not in p.parts+ }+++def _paired_extensions():+ """Extensions whose source and live copies BOTH exist on this machine."""+ if not SOURCE_ROOT.is_dir():+ return []+ paired = []+ for ext_dir in sorted(p for p in SOURCE_ROOT.iterdir() if p.is_dir()):+ source = ext_dir / 'backend'+ live = LIVE_ROOT / ext_dir.name+ if source.is_dir() and live.is_dir():+ paired.append((ext_dir.name, source, live))+ return paired+++def _pairs():+ """[(ext, relpath, source_file, live_file)] for every comparable file."""+ out = []+ for ext, source, live in _paired_extensions():+ source_files = _python_files(source)+ live_files = _python_files(live)+ for rel in sorted(set(source_files) & set(live_files)):+ out.append((ext, rel, source_files[rel], live_files[rel]))+ return out+++PAIRS = _pairs()++[email protected](not PAIRS, reason='no extension has both copies on disk')+ 'ext,rel,source_file,live_file', PAIRS,+ ids=[f'{ext}/{rel}' for ext, rel, _, _ in PAIRS],+)+def test_live_copy_matches_source(ext, rel, source_file, live_file):+ """A file present in both trees must be byte-identical (modulo CRLF)."""+ assert _normalised_hash(source_file) == _normalised_hash(live_file), (+ f'{ext}/{rel} differs between the source and the live copy.\n'+ f' source: {source_file.relative_to(REPO)}\n'+ f' live: {live_file.relative_to(REPO)}\n'+ 'Edit BOTH — the loader imports the live copy, so a fix applied only to '+ 'builtin-extensions/ ships a repo that reads correct and a panel that '+ 'runs the old code.'+ )+++def test_no_file_is_missing_from_one_side():+ """A file added to one tree and not the other is drift before it is edited."""+ missing = []+ for ext, source, live in _paired_extensions():+ source_files = set(_python_files(source))+ live_files = set(_python_files(live))+ for rel in sorted(source_files - live_files):+ missing.append(f'{ext}/{rel}: in builtin-extensions, not in app/plugins')+ for rel in sorted(live_files - source_files):+ missing.append(f'{ext}/{rel}: in app/plugins, not in builtin-extensions')++ assert not missing, (+ 'Extension files exist on only one side:\n ' + '\n '.join(missing)+ )+++def test_drift_check_is_not_vacuous():+ """Guard the guard.++ Most live copies are gitignored, so a fresh clone sees far fewer pairs than+ a dev machine. serverkit-email's live copy predates that ignore rule and is+ tracked, so at least one extension must always be comparable. Without this,+ a reorganisation could silently reduce the parametrised test above to zero+ cases and it would still report green.+ """+ assert PAIRS, (+ 'No extension had both a builtin-extensions/<ext>/backend and an '+ 'app/plugins/<ext> copy, so the drift check compared nothing. Either '+ 'the layout moved or the tracked serverkit-email copy is gone.'+ )