Skip to content

ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.

fix(workspaces): require admin role to create workspaces

Juan Denisa92d40a042af
diff --git a/backend/app/api/workspaces.py b/backend/app/api/workspaces.py
index af439cae..040d55fb 100644
--- a/backend/app/api/workspaces.py
+++ b/backend/app/api/workspaces.py
@@ -5,7 +5,9 @@ from app.services.audit_service import AuditService
from app.models.audit_log import AuditLog
# The workspace guards now live in middleware/rbac.py so any resource blueprint
# can reuse them (plan 19 Decision 2). Re-exported here for existing callers.
-from app.middleware.rbac import get_current_user, require_workspace_access, require_workspace_role
+from app.middleware.rbac import (
+ admin_required, get_current_user, require_workspace_access, require_workspace_role,
+)
workspaces_bp = Blueprint('workspaces', __name__)
@@ -50,6 +52,7 @@ def get_workspace(workspace_id):
@workspaces_bp.route('/', methods=['POST'])
@jwt_required()
+@admin_required
def create_workspace():
user = get_current_user()
data = request.get_json()
diff --git a/backend/tests/test_workspace_scope.py b/backend/tests/test_workspace_scope.py
index 8eb828b9..301c6cc9 100644
--- a/backend/tests/test_workspace_scope.py
+++ b/backend/tests/test_workspace_scope.py
@@ -509,3 +509,22 @@ def test_list_workspaces_surfaces_effective_role(app, client):
rows = {w['name']: w for w in r.get_json()['workspaces']}
assert rows['LW']['my_role'] == 'viewer'
assert rows['LW']['my_effective_role'] == 'viewer'
+
+
+def test_create_workspace_requires_admin(app, client):
+ """GHSA-r4q7-x795-vr4j: POST /api/v1/workspaces/ was gated only by
+ @jwt_required(), so a read-only viewer could create a workspace, become its
+ owner, then add arbitrary members and mint workspace API keys. It now
+ carries @admin_required like every other panel-wide create."""
+ from app import db
+
+ for role in ('viewer', 'developer'):
+ u = _mk_user(db, f'cw_{role}', role)
+ r = client.post('/api/v1/workspaces/', headers=_token(u.id),
+ json={'name': f'cw-{role}', 'slug': f'cw-{role}'})
+ assert r.status_code == 403, f'{role} reached workspace creation: {r.status_code}'
+
+ admin = _mk_user(db, 'cw_admin', 'admin')
+ r = client.post('/api/v1/workspaces/', headers=_token(admin.id),
+ json={'name': 'cw-ok', 'slug': 'cw-ok'})
+ assert r.status_code == 201