ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.
Python astracloudflarecontrol-panelcyberpaneldnsfablehosting-control-panelhosting-panelkimi-k3server-managementserverkitubuntu-web-panelwebserver
Don't 500 on uptime stop when its data dir is unwritable
Juan Denisb86c03dc6b94
diff --git a/backend/app/services/uptime_service.py b/backend/app/services/uptime_service.pyindex 1541dbf9..4bd4ee62 100644--- a/backend/app/services/uptime_service.py+++ b/backend/app/services/uptime_service.py@@ -65,7 +65,11 @@ class UptimeService:that had stopped being updated. Now the write is atomic and the failureis logged and returned, so a caller can tell "saved" from "could not"."""- cls._ensure_data_dir()+ try:+ cls._ensure_data_dir()+ except OSError as e:+ logger.warning('Could not create uptime data dir %s: %s', cls.DATA_DIR, e)+ return Falseresult = save_json_config(cls.UPTIME_FILE, history)if not result['success']:logger.warning('Could not save uptime history to %s: %s',diff --git a/backend/tests/test_alerting_resumes_at_boot.py b/backend/tests/test_alerting_resumes_at_boot.pyindex 1ae8df43..2e430314 100644--- a/backend/tests/test_alerting_resumes_at_boot.py+++ b/backend/tests/test_alerting_resumes_at_boot.py@@ -99,3 +99,15 @@ def test_resume_does_not_create_an_uncreatable_data_dir(uptime, tmp_path, monkeymonkeypatch.setattr(UptimeService, 'UPTIME_FILE', str(data_dir / 'uptime_history.json'))UptimeService.resume_if_enabled()assert uptime == [] and not data_dir.exists()+++def test_stopping_tracking_survives_an_uncreatable_data_dir(uptime, tmp_path, monkeypatch):+ """Stop persists the tracking flag; an unwritable data dir must cost the+ flag, not turn the request into a 500."""+ blocker = tmp_path / 'not-a-dir'+ blocker.write_text('')+ data_dir = blocker / 'serverkit'+ monkeypatch.setattr(UptimeService, 'DATA_DIR', str(data_dir))+ monkeypatch.setattr(UptimeService, 'UPTIME_FILE', str(data_dir / 'uptime_history.json'))+ UptimeService.start_tracking()+ assert UptimeService.stop_tracking()['success'] is True