Skip to content

ServerKit is a lightweight, modern server control panel for managing web applications, databases, and services on your VPS or dedicated server. Built with Python/Flask backend and React frontend.

ci: run frontend tests and widen the release gate

Juan Denisf5e3816addef
diff --git a/.github/workflows/frontend-ci.yml b/.github/workflows/frontend-ci.yml
index e1f325fe..513c349f 100644
--- a/.github/workflows/frontend-ci.yml
+++ b/.github/workflows/frontend-ci.yml
@@ -9,9 +9,12 @@ name: Frontend CI
# check-theme-tokens the theme-token whitelist stays in 3-way sync
# check-html-sinks every raw-HTML sink is sanitized or annotated (XSS)
#
-# Only `npm run lint` runs here. The frontend is already COMPILED in CI by
-# Release Build Smoke Test, whose scripts/build-release.sh does `npm ci &&
-# npm run build` — adding a build job here would just duplicate that.
+# `npm run lint` and `npm test` run here. The test suite (`node --test`,
+# 141 assertions over pure-logic modules) sat invocable-but-uninvoked the
+# same way lint once did — written insurance no workflow cashed in. The
+# frontend is already COMPILED in CI by Release Build Smoke Test, whose
+# scripts/build-release.sh does `npm ci && npm run build` — adding a build
+# job here would just duplicate that.
#
# backend/app/** is in the paths because check-html-sinks scans it too (for
# `|safe`, `Markup(`, `render_template_string`), so a backend-only commit can
@@ -56,3 +59,7 @@ jobs:
# add --max-warnings=<N> here rather than mass-fixing in one commit.
working-directory: frontend
run: npm run lint
+ - name: Unit tests
+ # node --test over src/**/__tests__ — pure-logic modules, no jsdom.
+ working-directory: frontend
+ run: npm test
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index c158dccc..70d42507 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -47,15 +47,31 @@ jobs:
core.info(`Verified dev → main promotion via PR #${promotion.number}.`);
+ # A release must not ship with a red frontend or drifted builtin
+ # extensions, so those suites gate here alongside backend-ci.
+ # scripts-ci (installer/updater suites incl. the ~45-min update-e2e leg)
+ # supports workflow_call too but is deliberately NOT gated to keep
+ # releases fast — add `uses: ./.github/workflows/scripts-ci.yml` as a
+ # fourth gate job if that trade-off changes.
ci-gate:
name: CI Gate
needs: promotion-gate
uses: ./.github/workflows/backend-ci.yml
+ frontend-gate:
+ name: Frontend Gate
+ needs: promotion-gate
+ uses: ./.github/workflows/frontend-ci.yml
+
+ extensions-gate:
+ name: Extensions Gate
+ needs: promotion-gate
+ uses: ./.github/workflows/extensions-ci.yml
+
version:
name: Resolve Version
runs-on: ubuntu-latest
- needs: ci-gate
+ needs: [ci-gate, frontend-gate, extensions-gate]
outputs:
version: ${{ steps.version.outputs.version }}
tag: ${{ steps.version.outputs.tag }}