Qwen3.8-Flash-Next on any consumer hardware: one-click install for Windows / Linux. Strata inference engine, OpenAI/Anthropic API on localhost, optional image input.
C++
agent: the approval gate fails closed when it cannot read the permission mode (T4)
Niko12214791d6b6761e
diff --git a/apps/host/server/agent/plugins/strata-gate.mjs b/apps/host/server/agent/plugins/strata-gate.mjsindex d25d76c05..dfc75bc9b 100644--- a/apps/host/server/agent/plugins/strata-gate.mjs+++ b/apps/host/server/agent/plugins/strata-gate.mjs@@ -219,8 +219,13 @@ export function apply(ctx, config = {}) {ctx.on('tools/pre-execute', async (exec, next) => {const agent = exec.agent;if (!agent || exec.name === 'run_code') return next();+ // Fail closed (T4): a session whose preset cannot be read (a reset in progress, a helper whose chat is gone) is treated as Manual, so+ // anything this file cannot prove is read-only still asks. It used to run unasked.let preset;- try { preset = effectivePreset(agent.session); } catch { return next(); }+ try { preset = effectivePreset(agent.session); } catch (e) {+ preset = MANUAL_PRESET;+ try { console.warn(`[strata-gate] could not read the permission mode for this call (${e?.message ?? e}); treating it as Manual`); } catch { /* logging must never decide a permission */ }+ }// A helper that was set to ask while the chat was in Manual must stop asking the moment the chat leaves Manual,// so a mode change applies to the very next tool call of a running goal and its helpers.if (preset !== MANUAL_PRESET && agent.session.header?.origin === 'subagent' && ctx.approval.overrideOf(agent.session) === 'ask') {diff --git a/apps/host/tests/gate-fail-closed.test.mjs b/apps/host/tests/gate-fail-closed.test.mjsnew file mode 100644index 000000000..71c0c3754--- /dev/null+++ b/apps/host/tests/gate-fail-closed.test.mjs@@ -0,0 +1,36 @@+// T4 (tools and images review, 2026-10-22): the approval gate fails closed. When the permission mode of a session cannot be read, a call+// that is not provably read-only asks, as in Manual; it used to run without a card.+import test from 'node:test';+import assert from 'node:assert/strict';+import { apply, MANUAL_PRESET } from '../server/agent/plugins/strata-gate.mjs';++function gate(current) {+ let handler;+ apply({ on: (_e, h) => { handler = h; }, inject: () => {}, sessions: new Map(), permissionPresets: { current }, approval: { overrideOf: () => 'never' } });+ return handler;+}+const session = { header: { origin: 'user' } };+const allow = async () => ({ kind: 'allow' });+const quiet = async fn => { const warn = console.warn; const lines = []; console.warn = (...a) => lines.push(a.join(' ')); try { return [await fn(), lines]; } finally { console.warn = warn; } };++test('a call that changes things asks when the preset cannot be resolved', async () => {+ const handler = gate(() => { throw new Error('unknown session'); });+ const [result, lines] = await quiet(() => handler({ name: 'write', agent: { session }, input: { file_path: 'x' } }, allow));+ assert.equal(result.kind, 'ask');+ assert.match(lines.join('\n'), /could not read the permission mode.*unknown session.*Manual/);+});++test('a provably read-only call still goes through, and a shell write asks', async () => {+ const handler = gate(() => { throw new Error('gone'); });+ const [read] = await quiet(() => handler({ name: 'read', agent: { session }, input: { file_path: 'x' } }, allow));+ assert.equal(read.kind, 'allow');+ const [shell] = await quiet(() => handler({ name: 'bash', agent: { session }, input: { command: 'rm -rf x' } }, allow));+ assert.equal(shell.kind, 'ask');+});++test('with a readable preset nothing changes: Bypass runs, Manual asks', async () => {+ const bypass = gate(() => 'strata-bypass');+ assert.equal((await bypass({ name: 'write', agent: { session }, input: { file_path: 'x' } }, allow)).kind, 'allow');+ const manual = gate(() => MANUAL_PRESET);+ assert.equal((await manual({ name: 'write', agent: { session }, input: { file_path: 'x' } }, allow)).kind, 'ask');+});