Skip to content

Qwen3.8-Flash-Next on any consumer hardware: one-click install for Windows / Linux. Strata inference engine, OpenAI/Anthropic API on localhost, optional image input.

C++

setup: use the published size when the download length probes fail (#2287)

Keyan Hua1d2fd7ed179
diff --git a/setup.py b/setup.py
index d72ba3e3e..7f3193a97 100644
--- a/setup.py
+++ b/setup.py
@@ -2885,12 +2885,14 @@ def download(url, dst: Path, what=None):
time.sleep(5)
if not total:
total = range_total(url)
+ meta = ms_meta(*ms) if ms is not None else None
+ if not total: # published size also governs partial-file completion
+ total = pin[0] if pin else (meta[0] if meta else 0)
if pin and total and total != pin[0]: # not the pinned file: stop before the download, not after
fail(f"{what or dst.name} is {total:,} bytes on {url.split('/')[2]}, not the pinned {pin[0]:,}",
"update Strata (the file there has changed since this version pinned it)")
label = what or dst.name
conns = dl_connections()
- meta = ms_meta(*ms) if ms is not None else None
fixed = pin if pin else (meta if meta is not None and meta[1] else None)
again = (lambda: repair_download(url, dst, total, label, conns)) if total >= DL_MIN_PARALLEL and conns > 1 else None
if dst.exists() and total and dst.stat().st_size == total: # finished by an older setup (no mark yet), or stopped before the check
diff --git a/tools/test_setup_download_length.py b/tools/test_setup_download_length.py
new file mode 100644
index 000000000..2ad726b6f
--- /dev/null
+++ b/tools/test_setup_download_length.py
@@ -0,0 +1,109 @@
+"""Published size drives resume when HEAD and the range probe have no length."""
+import contextlib
+import hashlib
+import io
+import tempfile
+import unittest
+from pathlib import Path
+from unittest import mock
+from tools.test_setup_download import DATA, Server, small_pieces, setup
+
+
+class PublishedDownloadLength(unittest.TestCase):
+ def run_download(self, metadata, persistent=False, digest=True, parallel=False):
+ def faults(path, start, end, nth):
+ if (start, end) == (0, 0) and (not parallel or nth == 1):
+ return 'status', 405
+ if start == 0 and nth == 1:
+ return 'cut', 262144
+ if persistent:
+ return 'cut', 0
+
+ with Server(length=False, faults=faults, delay=0) as server, tempfile.TemporaryDirectory() as tmp:
+ dst = Path(tmp) / 'model.gguf'
+ published = (len(DATA), hashlib.sha256(DATA).hexdigest() if digest else '')
+ with contextlib.ExitStack() as stack:
+ stack.enter_context(small_pieces(DL_MIN_PARALLEL=0 if parallel else len(DATA) + 1))
+ stack.enter_context(contextlib.redirect_stdout(io.StringIO()))
+ stack.enter_context(mock.patch.object(setup, 'file_pin', return_value=None if metadata else published))
+ stack.enter_context(mock.patch.object(setup, 'model_source', return_value='modelscope' if metadata else 'huggingface'))
+ stack.enter_context(mock.patch.object(setup, 'ms_file', return_value=('repo', 'model.gguf')))
+ stack.enter_context(mock.patch.object(setup, 'ms_url', return_value=server.url))
+ stack.enter_context(mock.patch.object(setup, 'reachable', return_value=True))
+ meta = stack.enter_context(mock.patch.object(setup, 'ms_meta', return_value=published))
+ if persistent:
+ with self.assertRaises(SystemExit):
+ setup.download(server.url, dst)
+ self.assertFalse(dst.exists())
+ self.assertFalse(dst.with_name(dst.name + '.done').exists())
+ self.assertEqual(dst.with_name(dst.name + '.part').read_bytes(), DATA[:262144])
+ else:
+ setup.download(server.url, dst)
+ self.assertEqual(dst.read_bytes(), DATA)
+ self.assertTrue(dst.with_name(dst.name + '.done').exists())
+ if parallel:
+ self.assertTrue(any(start > 0 and end < len(DATA) - 1 for start, end in server.gets))
+ else:
+ self.assertIn((262144, len(DATA) - 1), server.gets)
+ self.assertEqual(meta.call_count, 1 if metadata else 0)
+
+ def test_pin_size_recovers_clean_early_eof(self):
+ self.run_download(metadata=False)
+
+ def test_modelscope_metadata_size_recovers_clean_early_eof(self):
+ self.run_download(metadata=True)
+
+ def test_exhausted_transfer_keeps_resumable_partial(self):
+ self.run_download(metadata=False, persistent=True)
+
+ def test_metadata_size_without_hash_still_recovers(self):
+ self.run_download(metadata=True, digest=False)
+
+ def test_published_size_also_drives_parallel_download(self):
+ self.run_download(metadata=False, parallel=True)
+
+ def test_complete_partial_is_published_without_downloading_again(self):
+ def faults(path, start, end, nth):
+ return ('status', 405) if (start, end) == (0, 0) else None
+
+ with Server(length=False, faults=faults) as server, tempfile.TemporaryDirectory() as tmp:
+ dst = Path(tmp) / 'model.gguf'
+ dst.with_name(dst.name + '.part').write_bytes(DATA)
+ published = (len(DATA), hashlib.sha256(DATA).hexdigest())
+ with small_pieces(DL_MIN_PARALLEL=len(DATA) + 1), \
+ mock.patch.object(setup, 'file_pin', return_value=published), \
+ contextlib.redirect_stdout(io.StringIO()):
+ setup.download(server.url, dst)
+ self.assertEqual(dst.read_bytes(), DATA)
+ self.assertIn(published[1], dst.with_name(dst.name + '.done').read_text())
+ self.assertEqual(server.gets, [(0, 0)])
+ heads = server.heads
+ setup.download(server.url, dst)
+ self.assertEqual(server.heads, heads)
+ self.assertEqual(server.gets, [(0, 0)])
+
+ def test_transport_size_conflict_is_still_refused_before_transfer(self):
+ with Server() as server, tempfile.TemporaryDirectory() as tmp:
+ dst = Path(tmp) / 'model.gguf'
+ with small_pieces(), mock.patch.object(setup, 'file_pin', return_value=(len(DATA) + 1, '0' * 64)), \
+ contextlib.redirect_stdout(io.StringIO()), self.assertRaises(SystemExit):
+ setup.download(server.url, dst)
+ self.assertEqual(server.gets, [])
+ self.assertEqual(list(Path(tmp).iterdir()), [])
+
+ def test_fallback_size_does_not_bypass_hash_verification(self):
+ def faults(path, start, end, nth):
+ return ('status', 405) if (start, end) == (0, 0) else None
+
+ with Server(length=False, faults=faults) as server, tempfile.TemporaryDirectory() as tmp:
+ dst = Path(tmp) / 'model.gguf'
+ with small_pieces(DL_MIN_PARALLEL=len(DATA) + 1), \
+ mock.patch.object(setup, 'file_pin', return_value=(len(DATA), '0' * 64)), \
+ contextlib.redirect_stdout(io.StringIO()), self.assertRaises(SystemExit):
+ setup.download(server.url, dst)
+ self.assertFalse(dst.exists())
+ self.assertFalse(dst.with_name(dst.name + '.done').exists())
+
+
+if __name__ == '__main__':
+ unittest.main()