Skip to content

Qwen3.8-Flash-Next on any consumer hardware: one-click install for Windows / Linux. Strata inference engine, OpenAI/Anthropic API on localhost, optional image input.

C++

--pool-cores: a list of more than 4096 processors is refused by the parser (with a message; the pool then keeps its default placement)

Niko1221c4f1e05dbd5e
diff --git a/include/strata/kernels/cpu/pool_plan.hpp b/include/strata/kernels/cpu/pool_plan.hpp
index 1c791291f..743ae9e63 100644
--- a/include/strata/kernels/cpu/pool_plan.hpp
+++ b/include/strata/kernels/cpu/pool_plan.hpp
@@ -212,8 +212,10 @@ inline bool parse_pool_cores(const std::string& text, std::vector<int>& out, std
if (!number(step) || step < 1) { err = "'" + text + "' has a step that is not a positive number"; out.clear(); return false; }
}
}
- for (long c = lo; c <= hi; c += step)
+ for (long c = lo; c <= hi; c += step) {
if (std::find(out.begin(), out.end(), (int) c) == out.end()) out.push_back((int) c);
+ if (out.size() > 4096) { err = "the list has more than 4096 logical processors"; out.clear(); return false; }
+ }
skip();
if (i == text.size()) break;
if (text[i] != ',') { err = "'" + text + "' is not a list of logical processor numbers (write it like 0,2,4,6 or 2-14:2)"; out.clear(); return false; }
diff --git a/src/kernels/cpu/pool_plan_test.cpp b/src/kernels/cpu/pool_plan_test.cpp
index 55fcc860f..836d25082 100644
--- a/src/kernels/cpu/pool_plan_test.cpp
+++ b/src/kernels/cpu/pool_plan_test.cpp
@@ -219,6 +219,8 @@ int main() {
expect(!cpu::parse_pool_cores("6-2", v, err), "list: a range that goes down");
expect(!cpu::parse_pool_cores("0-8:0", v, err), "list: a step of 0");
expect(!cpu::parse_pool_cores("-3", v, err), "list: a negative number");
+ expect(!cpu::parse_pool_cores("0-99999", v, err) && v.empty(), "list: a silly range is refused with a message, not expanded");
+ expect(cpu::parse_pool_cores("0-4095", v, err) && v.size() == 4096, "list: 4096 entries are fine");
expect(cpu::format_cpu_list({2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24, 26, 28, 30}) == "2,4,...,30", "format: a stride");
expect(cpu::format_cpu_list({0, 1, 2, 3, 4}) == "0-4", "format: a run");
expect(cpu::format_cpu_list({2, 4, 7}) == "2,4,7", "format: short and irregular lists in full");