Skip to content

Qwen3.8-Flash-Next on any consumer hardware: one-click install for Windows / Linux. Strata inference engine, OpenAI/Anthropic API on localhost, optional image input.

C++

fix: leave the NUMA split plan clean when the split is refused

Baptiste Rajautec841ca1e95d
diff --git a/src/kernels/cpu/pool.cpp b/src/kernels/cpu/pool.cpp
index fc77f9ce4..f39f5efae 100644
--- a/src/kernels/cpu/pool.cpp
+++ b/src/kernels/cpu/pool.cpp
@@ -741,6 +741,11 @@ ExpertPool::ExpertPool(int n_workers, bool pin, bool host_works, PoolAffinity af
}
plan.why = why;
plan.on = plan.why.empty();
+ if (!plan.on) { // a refusal after the slices were planned (unbalanced) leaves no half-filled plan behind
+ plan.nodes[0] = plan.nodes[1] = -1;
+ plan.cores[0].clear();
+ plan.cores[1].clear();
+ }
if (plan.on) {
numa_n_ = 2;
nsync_.reset(new NodeSync[2]);
diff --git a/src/kernels/cpu/pool_tasks_test.cpp b/src/kernels/cpu/pool_tasks_test.cpp
index d04d8fca2..8267e52fe 100644
--- a/src/kernels/cpu/pool_tasks_test.cpp
+++ b/src/kernels/cpu/pool_tasks_test.cpp
@@ -234,7 +234,8 @@ int main(int argc, char** argv) {
cpu::ExpertPool pool(4, true, true);
const auto& plan = cpu::active_numa_split();
ok = plan.on ? plan.nodes[0] != plan.nodes[1] && !plan.cores[0].empty() && !plan.cores[1].empty()
- : !plan.why.empty();
+ : !plan.why.empty() && plan.nodes[0] == -1 && plan.nodes[1] == -1 && plan.cores[0].empty() &&
+ plan.cores[1].empty();
std::printf("pool tasks: real split %s%s\n", plan.on ? "on" : "off: ", plan.why.c_str());
}
unset_env("STRATA_NUMA_SPLIT");