Skip to content

Build your personal knowledge base with Trilium Notes

fix(pdf): stop logging a SyntaxError on every editable PDF

Elian Doran058bed2a2fa2
diff --git a/packages/pdfjs-viewer/src/persistence.spec.ts b/packages/pdfjs-viewer/src/persistence.spec.ts
index 28246549f9..ab1e39e635 100644
--- a/packages/pdfjs-viewer/src/persistence.spec.ts
+++ b/packages/pdfjs-viewer/src/persistence.spec.ts
@@ -185,6 +185,17 @@ describe("preferences and pass-through reads", () => {
expect(readThroughPatch("unrelated")).toBe("kept");
expect(readThroughPatch("never-written")).toBeNull();
});
+
+ it("still answers with parseable JSON when no options were injected", () => {
+ // How bootstrap.ts calls it. pdf.js hands whatever comes back straight to JSON.parse, and
+ // `undefined` made that throw on every editable document — caught by the viewer, but left
+ // a SyntaxError in the console for a document that was perfectly fine.
+ interceptPersistence();
+
+ const stored = readThroughPatch("pdfjs.preferences");
+ expect(typeof stored).toBe("string");
+ expect(() => JSON.parse(stored ?? "")).not.toThrow();
+ });
});
describe("view-history persistence", () => {
diff --git a/packages/pdfjs-viewer/src/persistence.ts b/packages/pdfjs-viewer/src/persistence.ts
index 7168b2cd88..c1db294136 100644
--- a/packages/pdfjs-viewer/src/persistence.ts
+++ b/packages/pdfjs-viewer/src/persistence.ts
@@ -22,7 +22,9 @@ export default function interceptViewHistory(customOptions?: object) {
const originalGetItem = Storage.prototype.getItem;
Storage.prototype.getItem = function (key: string) {
if (key === "pdfjs.preferences") {
- return JSON.stringify(customOptions);
+ // Defaulted because pdf.js parses the result unguarded, and `JSON.stringify(undefined)`
+ // is `undefined` rather than a string.
+ return JSON.stringify(customOptions ?? {});
}
if (key === "pdfjs.history") {