Skip to content

Build your personal knowledge base with Trilium Notes

fix(search): prefer compatibility path values

Amp0ee0eab8dbf3
diff --git a/packages/trilium-core/src/routes/api/search.spec.ts b/packages/trilium-core/src/routes/api/search.spec.ts
index 9e645d67e7..fc8379930c 100644
--- a/packages/trilium-core/src/routes/api/search.spec.ts
+++ b/packages/trilium-core/src/routes/api/search.spec.ts
@@ -163,12 +163,15 @@ describe("Search API (core)", () => {
});
it("keeps path parameters compatible with existing clients", async () => {
- const full = await api.get<string[]>(`/api/search/${UNIQUE_TOKEN}`);
+ const full = await api.get<string[]>(`/api/search/${UNIQUE_TOKEN}`, {
+ query: { searchString: "" }
+ });
expect(full.status).toBe(200);
expect(full.body).toContain(createdNoteId);
const quick = await api.get<{ searchResultNoteIds: string[] }>(
- `/api/quick-search/${UNIQUE_TOKEN}`
+ `/api/quick-search/${UNIQUE_TOKEN}`,
+ { query: { searchString: "" } }
);
expect(quick.status).toBe(200);
expect(quick.body.searchResultNoteIds).toContain(createdNoteId);
diff --git a/packages/trilium-core/src/routes/api/search.ts b/packages/trilium-core/src/routes/api/search.ts
index f1231e2518..fb2bd34092 100644
--- a/packages/trilium-core/src/routes/api/search.ts
+++ b/packages/trilium-core/src/routes/api/search.ts
@@ -170,7 +170,7 @@ function search(
}
function getSearchString(req: Request<{ searchString?: string }>): string {
- const searchString = req.query.searchString ?? req.params.searchString;
+ const searchString = req.params.searchString ?? req.query.searchString;
if (typeof searchString !== "string" || searchString.length === 0) {
throw new ValidationError("Search string must be a string.");