Build your personal knowledge base with Trilium Notes
TypeScript electronelectron-appknowledge-baseknowledge-graphknowledge-managementknowledge-management-graphlocal-firstnote-managmentnote-takernote-takingnotebooknotesnotes-apppersonal-knowledge-basepersonal-wikiscriptableself-hostedself-hostingwiki
fix(share): let the current note's external tree link open
Elian Doran123e587355cd
diff --git a/packages/share-theme/src/page/tree_state.spec.ts b/packages/share-theme/src/page/tree_state.spec.tsindex 6efaf974fe..8b2404fd4e 100644--- a/packages/share-theme/src/page/tree_state.spec.ts+++ b/packages/share-theme/src/page/tree_state.spec.ts@@ -148,6 +148,10 @@ describe("setupTreeState", () => {cloneLink("x").dispatchEvent(event);expect(event.preventDefault).not.toHaveBeenCalled();}+ // The external link of a note with `#shareExternalLink` opens in a new tab.+ cloneLink("x").setAttribute("target", "_blank");+ expect(click(cloneLink("x"))).toBe(false);+ expect(selected()).toStrictEqual([ "y/row", "y/link" ]);document.body.dataset.noteId = "other";const event = new MouseEvent("click", { bubbles: true, cancelable: true });event.preventDefault = vi.fn();diff --git a/packages/share-theme/src/page/tree_state.ts b/packages/share-theme/src/page/tree_state.tsindex d002a90c7c..a65534fa8c 100644--- a/packages/share-theme/src/page/tree_state.ts+++ b/packages/share-theme/src/page/tree_state.ts@@ -51,7 +51,8 @@ export default function setupTreeState() {}activePath = getItemPath(item);// An entry of the page shown, maybe another clone of it, is selected in place.- const opensNewTab = e.ctrlKey || e.metaKey || e.shiftKey || e.altKey || e.button !== 0;+ const opensNewTab = e.ctrlKey || e.metaKey || e.shiftKey || e.altKey || e.button !== 0+ || link.getAttribute("target") === "_blank";if (!opensNewTab && item.getAttribute("data-note-id") === document.body.dataset.noteId) {e.preventDefault();selectItem(pane, item);