Skip to content

Build your personal knowledge base with Trilium Notes

fix(bulk_actions): list a note selected through two clones once

Elian Doran3d1a7e7865bc
diff --git a/apps/client/src/widgets/dialogs/bulk_actions.spec.tsx b/apps/client/src/widgets/dialogs/bulk_actions.spec.tsx
index 61b7958355..548c3261c3 100644
--- a/apps/client/src/widgets/dialogs/bulk_actions.spec.tsx
+++ b/apps/client/src/widgets/dialogs/bulk_actions.spec.tsx
@@ -259,4 +259,14 @@ describe("BulkActionsDialog", () => {
expect(lastAffectedNotesRequest()).toStrictEqual({ noteIds: [ "n2" ], includeDescendants: false });
expect(container.querySelector<HTMLButtonElement>(".tn-chip-remove")?.disabled).toBe(true);
});
+
+ it("lists a note selected through two of its clones once", async () => {
+ await open([ "n1", "n1", "n2" ]);
+ expect(chipNoteIds()).toStrictEqual([ "n1", "n2" ]);
+ expect(lastAffectedNotesRequest()).toStrictEqual({ noteIds: [ "n1", "n2" ], includeDescendants: false });
+
+ await open([ "n1", "n1" ]);
+ expect(chipNoteIds()).toStrictEqual([ "n1" ]);
+ expect(container.querySelector<HTMLButtonElement>(".tn-chip-remove")?.disabled).toBe(true);
+ });
});
diff --git a/apps/client/src/widgets/dialogs/bulk_actions.tsx b/apps/client/src/widgets/dialogs/bulk_actions.tsx
index 8105a9652d..70775183c6 100644
--- a/apps/client/src/widgets/dialogs/bulk_actions.tsx
+++ b/apps/client/src/widgets/dialogs/bulk_actions.tsx
@@ -32,7 +32,8 @@ export default function BulkActionsDialog() {
const [ shown, setShown ] = useState(false);
useTriliumEvent("openBulkActionsDialog", async ({ selectedOrActiveNoteIds }) => {
- setSelectedOrActiveNoteIds(selectedOrActiveNoteIds);
+ // Clones of one note share its ID.
+ setSelectedOrActiveNoteIds([ ...new Set(selectedOrActiveNoteIds) ]);
setBulkActionNote(await froca.getNote("_bulkAction"));
setShown(true);
});