Build your personal knowledge base with Trilium Notes
TypeScript electronelectron-appknowledge-baseknowledge-graphknowledge-managementknowledge-management-graphlocal-firstnote-managmentnote-takernote-takingnotebooknotesnotes-apppersonal-knowledge-basepersonal-wikiscriptableself-hostedself-hostingwiki
fix(clipper): answer the popup's messages in Chrome
Elian Doran4586682376e6
diff --git a/.claude/skills/developing-web-clipper/SKILL.md b/.claude/skills/developing-web-clipper/SKILL.mdindex 22cd8bf007..111adf3d52 100644--- a/.claude/skills/developing-web-clipper/SKILL.md+++ b/.claude/skills/developing-web-clipper/SKILL.md@@ -38,6 +38,13 @@ Everything goes through `browser.runtime.sendMessage` / `browser.tabs.sendMessag(`message`, `noteId`, `tabIds`).- **background → offscreen:** `{ type: "CROP_IMAGE" }`, the one message keyed by `type`.+**A listener answers through `sendResponse()` and returns `true`, never by returning a promise.**+WXT 0.20 dropped `webextension-polyfill`, and Chrome ignores a promise an `onMessage` listener+returns, so the sender gets `undefined` while Firefox works. The popup showed "the extension's+background script gave no answer" after every successful save in Chrome for that reason. The+background spec's `sendRuntimeMessage()` delivers messages the Chrome way and fails on a listener+that does not return `true`.+The readable page is not a message: the popup and the background call`extractPage(tabId, variant)` (`utils.ts`), which injects `/readable-page.js` with`browser.scripting.executeScript()` (the `scripting` permission, in both builds), so Defuddle staysdiff --git a/apps/web-clipper/entrypoints/background/index.spec.ts b/apps/web-clipper/entrypoints/background/index.spec.tsindex fb8cd5b3dd..95e38392d3 100644--- a/apps/web-clipper/entrypoints/background/index.spec.ts+++ b/apps/web-clipper/entrypoints/background/index.spec.ts@@ -1232,9 +1232,16 @@ function connect(name: string) {return port;}+/**+ * Sends a message as Chrome delivers it: Chrome ignores a promise the listener returns, and waits for+ * `sendResponse()` only when the listener returns `true`.+ */async function sendRuntimeMessage(message: object) {- const [ result ] = await fakeBrowser.runtime.onMessage.trigger(message, {}, () => {});- return result;+ let sendResponse: (response: unknown) => void = () => {};+ const response = new Promise((resolve) => sendResponse = resolve);+ const [ result ] = await fakeBrowser.runtime.onMessage.trigger(message, {}, sendResponse);+ expect(result).toBe(true);+ return await response;}function lastPayload() {diff --git a/apps/web-clipper/entrypoints/background/index.ts b/apps/web-clipper/entrypoints/background/index.tsindex 8b9e5ff957..f1aebc21e3 100644--- a/apps/web-clipper/entrypoints/background/index.ts+++ b/apps/web-clipper/entrypoints/background/index.ts@@ -769,7 +769,13 @@ export default defineBackground(() => {}}));- browser.runtime.onMessage.addListener((request) => showFailures(async () => {+ // Chrome ignores a promise the listener returns: it answers through `sendResponse()`, after `true`.+ browser.runtime.onMessage.addListener((request, _sender, sendResponse) => {+ void showFailures(() => handleMessage(request)).then(sendResponse);+ return true;+ });++ async function handleMessage(request: any) {console.log("Received", request);if (request.name === 'openNoteInTrilium') {@@ -835,7 +841,7 @@ export default defineBackground(() => {triliumServerFacade.triggerSearchNoteByUrl(activeTab.url);}}- }));+ }});function savedMessage(subject: string, failedImages: number) {