Skip to content

Build your personal knowledge base with Trilium Notes

fix(client): apply preview style stripping in rich content postprocess

Allan Zyne68eed9f78ab9
diff --git a/apps/client/src/services/content_renderer_text.spec.ts b/apps/client/src/services/content_renderer_text.spec.ts
index e710ddc17d..6c1ee500b2 100644
--- a/apps/client/src/services/content_renderer_text.spec.ts
+++ b/apps/client/src/services/content_renderer_text.spec.ts
@@ -3,6 +3,7 @@
// mishandles it and strips valid markup (surfaced by dompurify 3.4.8). Run the
// sanitization-dependent specs under jsdom, which matches real-browser behavior.
import { KATEX_MACROS, trimIndentation } from "@triliumnext/commons";
+import DOMPurify from "dompurify";
import { beforeEach, describe, expect, it, vi } from "vitest";
import FAttachment from "../entities/fattachment";
@@ -245,6 +246,23 @@ describe("Text content renderer", () => {
await expect(renderText(note, $(contentEl))).resolves.toBeUndefined();
expect(contentEl.querySelector("a.reference-link")).not.toBeNull();
});
+
+ it("removes non-leading style tags from trimmed markdown previews", async () => {
+ const note = buildNote({ title: "Imported Markdown note" });
+ const markdownHtml = DOMPurify.sanitize(`
+ <p>Preview text</p>
+ <style>li { margin-bottom: 8pt; }</style>
+ `);
+ const $renderedContent = $("<div>").append(
+ $("<div class=\"ck-content\">").html(markdownHtml)
+ );
+ expect($renderedContent[0].querySelector("style")).not.toBeNull();
+
+ await postProcessRichContent(note, $renderedContent, { trim: true });
+
+ expect($renderedContent[0].querySelector("style")).toBeNull();
+ expect($renderedContent[0].textContent).toContain("Preview text");
+ });
});
describe("Nested include notes (single-level display vs recursive print)", () => {
diff --git a/apps/client/src/services/content_renderer_text.ts b/apps/client/src/services/content_renderer_text.ts
index b6df80deda..ad35822601 100644
--- a/apps/client/src/services/content_renderer_text.ts
+++ b/apps/client/src/services/content_renderer_text.ts
@@ -69,6 +69,10 @@ export async function postProcessRichContent(note: FNote | FAttachment, $rendere
applyLinkEmbeds($renderedContent[0]);
await rewriteMermaidDiagramsInContainer($renderedContent[0] as HTMLDivElement);
await formatCodeBlocks($renderedContent);
+
+ if (options.trim) {
+ $renderedContent.find("style").remove();
+ }
}
async function renderIncludedNotes(contentEl: HTMLElement, seenNoteIds: Set<string>, expandNested: boolean) {