Build your personal knowledge base with Trilium Notes
TypeScript electronelectron-appknowledge-baseknowledge-graphknowledge-managementknowledge-management-graphlocal-firstnote-managmentnote-takernote-takingnotebooknotesnotes-apppersonal-knowledge-basepersonal-wikiscriptableself-hostedself-hostingwiki
fix(sync): bypass the HTTP cache for sync requests (closes #5251)
Elian Doran720f14ed34b7
diff --git a/apps/server/src/services/request.spec.ts b/apps/server/src/services/request.spec.tsindex dc767e9598..bb10243289 100644--- a/apps/server/src/services/request.spec.ts+++ b/apps/server/src/services/request.spec.ts@@ -173,6 +173,7 @@ describe("NodeRequestProvider.exec", () => {expect(sent.host).toBe("sync.example.com");expect(sent.port).toBe("8080");expect(sent.headers["Content-Type"]).toBe("application/json");+ expect(sent.cache).toBe("no-store");});it("selects the https client based on the URL scheme", async () => {diff --git a/apps/server/src/services/request.ts b/apps/server/src/services/request.tsindex 11e62afca2..d8fcf46ed5 100644--- a/apps/server/src/services/request.ts+++ b/apps/server/src/services/request.ts@@ -27,6 +27,8 @@ export interface ClientOpts {* address that has already been vetted, rather than on whatever DNS answers at connect time.*/lookup?: unknown;+ /** Chromium HTTP cache mode, read by `electron.net` and ignored by the node clients. */+ cache?: "default" | "no-store";}type RequestEvent = "error" | "response" | "abort";@@ -129,7 +131,9 @@ export default class NodeRequestProvider implements RequestProvider {path: parsedTargetUrl.path,timeout: opts.timeout, // works only for node.js clientheaders,- agent: proxyAgent+ agent: proxyAgent,+ // Chromium caches a 301 indefinitely, so a cached redirect would outlive a fixed sync host.+ cache: "no-store"});request.on("error", (err) => reject(generateError(opts, err)));