Skip to content

Build your personal knowledge base with Trilium Notes

build(nix): trim the tolerateMissingAngleLibs comment

Claude74e008fafa8e
diff --git a/flake.nix b/flake.nix
index 774e65e4c3..1f9c4b6910 100644
--- a/flake.nix
+++ b/flake.nix
@@ -62,15 +62,9 @@
# exits with "missing filename". Let that one command tolerate an empty match; it
# still patches the libraries on releases that do ship them.
#
- # nixpkgs fixed this itself in NixOS/nixpkgs@b3041dc18a ("electron_44-bin: fix
- # build", on nixpkgs-unstable and nixos-26.05), which skips that patchelf for
- # Electron >= 44. Against such a nixpkgs the glob is gone and the replacement below
- # is a no-op, on purpose: consumers who point this flake at their own nixpkgs via
- # `inputs.nixpkgs.follows` get the fixed builder long before flake.lock does, and
- # must still evaluate. Nothing can break silently this way — if nixpkgs ever
- # reworded the command but kept it unguarded, patchelf would still fail the build
- # with "missing filename". Drop this override once flake.lock's nixpkgs includes
- # b3041dc18a.
+ # NixOS/nixpkgs@b3041dc18a skips that patchelf for Electron >= 44, so against a
+ # newer nixpkgs (e.g. via `inputs.nixpkgs.follows`) the replacement is a no-op.
+ # Drop this override once flake.lock's nixpkgs includes that commit.
angleLibGlob = "$out/libexec/electron/lib*GL*";
tolerateMissingAngleLibs =
drv: