Skip to content

Build your personal knowledge base with Trilium Notes

fix(transcription): segment audio even without a level listener

Elian Doran91bb0d440528
diff --git a/apps/desktop/src/services/transcription/session.spec.ts b/apps/desktop/src/services/transcription/session.spec.ts
index 6c7c9b7131..6fac1fde07 100644
--- a/apps/desktop/src/services/transcription/session.spec.ts
+++ b/apps/desktop/src/services/transcription/session.spec.ts
@@ -30,7 +30,7 @@ function speechChunk(speaking: boolean) {
return samples;
}
-function createHarness(extraSinks: TranscriptSink[] = [], taps: AudioTap[] = []) {
+function createHarness(extraSinks: TranscriptSink[] = [], taps: AudioTap[] = [], reportsLevels = true) {
let clock = 1000;
let onSamples: SamplesListener = () => {};
const capture = {
@@ -82,7 +82,9 @@ function createHarness(extraSinks: TranscriptSink[] = [], taps: AudioTap[] = [])
const onPendingChanged = vi.fn();
const onLevel = vi.fn();
const session = new RecordingSession({
- capture, engine, sinks, taps, log, onPendingChanged, onLevel, now: () => clock
+ capture, engine, sinks, taps, log, onPendingChanged,
+ onLevel: reportsLevels ? onLevel : undefined,
+ now: () => clock
});
return {
@@ -293,6 +295,17 @@ describe("RecordingSession", () => {
await session.stop();
});
+ it("transcribes without a level listener", async () => {
+ const { session, deliver, written } = createHarness([], [], false);
+ await session.start();
+ deliver("microphone", utteranceChunk(1, 8000), 3000);
+ await session.stop();
+
+ expect(written).toEqual([
+ { source: "microphone", offsetMs: 1500, durationMs: 1000, text: "utterance 1" }
+ ]);
+ });
+
it("logs a failed transcription or tap, and still finishes the rest", async () => {
const tap = { write: vi.fn(), close: vi.fn(() => {
throw new Error("disk full");
diff --git a/apps/desktop/src/services/transcription/session.ts b/apps/desktop/src/services/transcription/session.ts
index ed5f4dbb5d..fae26ee848 100644
--- a/apps/desktop/src/services/transcription/session.ts
+++ b/apps/desktop/src/services/transcription/session.ts
@@ -89,7 +89,8 @@ export class RecordingSession {
try {
const pipeline = this.pipelineFor(source, samples);
this.tap(source, samples, pipeline.firstSampleOffsetMs);
- this.options.onLevel?.(source, pipeline.accept(samples));
+ const level = pipeline.accept(samples);
+ this.options.onLevel?.(source, level);
this.updatePending();
} catch (e) {
this.log.error(`Transcription: ${source} failed: ${(e as Error)?.message ?? e}`);