Build your personal knowledge base with Trilium Notes
TypeScript electronelectron-appknowledge-baseknowledge-graphknowledge-managementknowledge-management-graphlocal-firstnote-managmentnote-takernote-takingnotebooknotesnotes-apppersonal-knowledge-basepersonal-wikiscriptableself-hostedself-hostingwiki
fix(web-clipper): show the link note's Ctrl+Enter on its Save button
Elian Doranba99089e8e35
diff --git a/apps/web-clipper/entrypoints/popup/main.tsx b/apps/web-clipper/entrypoints/popup/main.tsxindex 9705e6d90b..25288bbfdf 100644--- a/apps/web-clipper/entrypoints/popup/main.tsx+++ b/apps/web-clipper/entrypoints/popup/main.tsx@@ -329,10 +329,10 @@ function LinkWithNoteForm({ onBack }: { onBack: () => void }) {{" "}Keep page title as note title</label>- <div className="save-link-with-note-buttons">- <span className="hint"><kbd>Ctrl</kbd>+<kbd>Enter</kbd> to save</span>- <button type="submit" className="btn btn-primary" onClick={save}>Save</button>- </div>+ <button type="submit" className="btn btn-primary primary-action" onClick={save}>+ <span className="action-label">Save</span>+ <Shortcut keys="Ctrl+Enter" />+ </button></div>);}diff --git a/apps/web-clipper/entrypoints/popup/popup.css b/apps/web-clipper/entrypoints/popup/popup.cssindex ed0db1fcdb..44ec6bf956 100644--- a/apps/web-clipper/entrypoints/popup/popup.css+++ b/apps/web-clipper/entrypoints/popup/popup.css@@ -194,18 +194,6 @@ body {}}- .save-link-with-note-buttons {- display: flex;- align-items: center;- justify-content: space-between;- gap: 6px;-- .hint {- color: var(--muted-text-color);- font-size: 0.9em;- }- }-.connection {display: flex;align-items: center;diff --git a/apps/web-clipper/entrypoints/popup/popup.spec.tsx b/apps/web-clipper/entrypoints/popup/popup.spec.tsxindex 5a8587ffc5..7316591e16 100644--- a/apps/web-clipper/entrypoints/popup/popup.spec.tsx+++ b/apps/web-clipper/entrypoints/popup/popup.spec.tsx@@ -234,7 +234,9 @@ describe("popup", () => {expect(captureButtons()).toHaveLength(0);expect(container.querySelector(".view-header h4")?.textContent).toBe("Link with a note");expect(textArea?.placeholder).toBe("The first sentence becomes the note's title, the rest its text.");- expect(container.querySelector(".hint")?.textContent).toBe("Ctrl+Enter to save");+ expect(shortcutOf("Save")).toBe("Ctrl+Enter");+ expect(button("Save")?.querySelectorAll("kbd")).toHaveLength(1);+ expect(container.querySelector(".hint")).toBeNull();await click("Back");expect(container.querySelector("textarea")).toBeNull();