Skip to content

Build your personal knowledge base with Trilium Notes

client/text editor: fix an issue

Adorian Doranbbf595a87491
diff --git a/apps/client/src/stylesheets/style.css b/apps/client/src/stylesheets/style.css
index a6e0a351da..748bfb1b10 100644
--- a/apps/client/src/stylesheets/style.css
+++ b/apps/client/src/stylesheets/style.css
@@ -2583,7 +2583,9 @@ body.zen:not(.experimental-feature-new-layout) {
transition: opacity 100ms linear;
}
- .note-split:focus-within .ribbon-container {
+ /* A group's submenu pins its panel outside the note split, where `:focus-within` cannot see it. */
+ .note-split:focus-within .ribbon-container,
+ &:has(.ck-toolbar-group-menu__panel) .ribbon-container {
opacity: 1; /* Show when the note split is focused */
}
@@ -2606,7 +2608,8 @@ body.zen:not(.experimental-feature-new-layout) {
display: none;
}
- .note-split:focus-within .ribbon-container .classic-toolbar-widget {
+ .note-split:focus-within .ribbon-container .classic-toolbar-widget,
+ &:has(.ck-toolbar-group-menu__panel) .ribbon-container .classic-toolbar-widget {
pointer-events: all;
}
@@ -2651,8 +2654,10 @@ body.zen.experimental-feature-new-layout {
backdrop-filter: blur(6px);
}
+ /* A group's submenu pins its panel outside the note split, where `:focus-within` cannot see it. */
#root-widget:has(.note-split.type-text:focus-within) .classic-toolbar-widget,
- .classic-toolbar-widget:focus-within {
+ .classic-toolbar-widget:focus-within,
+ &:has(.ck-toolbar-group-menu__panel) .classic-toolbar-widget {
opacity: 1; /* Show when the note split is focused */
pointer-events: all;
}
diff --git a/packages/ckeditor5/src/plugins/toolbar_group_menu.spec.ts b/packages/ckeditor5/src/plugins/toolbar_group_menu.spec.ts
index bbc48f30cc..bb2f919da0 100644
--- a/packages/ckeditor5/src/plugins/toolbar_group_menu.spec.ts
+++ b/packages/ckeditor5/src/plugins/toolbar_group_menu.spec.ts
@@ -143,6 +143,9 @@ describe("ToolbarGroupMenu", () => {
const submenu = openSubmenu(dropdown);
expect(submenu.buttonView.label).toBe("Insert sample");
expect(submenu.buttonView.icon).toBe("<svg />");
+ // The panel is pinned into the editor's body, so the client's stylesheet finds it by this
+ // class alone — Zen mode reads it to keep the toolbar up while the submenu is open.
+ expect(submenu.panelView.class).toBe("ck-toolbar-group-menu__panel");
expect(itemLabels(submenu.listView.items)).toStrictEqual(["Flowchart", "Sequence"]);
});