Skip to content

Build your personal knowledge base with Trilium Notes

feat(share): keep the table of contents column on pages without one

Elian Doranc64cb82cafdf
diff --git a/packages/share-theme/src/page/toc.css b/packages/share-theme/src/page/toc.css
index 14d489aa72..78408f2742 100644
--- a/packages/share-theme/src/page/toc.css
+++ b/packages/share-theme/src/page/toc.css
@@ -14,6 +14,10 @@
background: var(--background-primary);
}
+#split-pane:has(#content.full-content-width) #toc-pane:empty {
+ display: none;
+}
+
#toc-pane h3 {
text-transform: uppercase;
}
@@ -127,4 +131,8 @@
.toc-open #toc-pane {
transform: translateX(0);
}
+
+ #toc-pane:empty {
+ display: none;
+ }
}
diff --git a/packages/share-theme/src/templates/page.ejs b/packages/share-theme/src/templates/page.ejs
index 33e03eb9b0..90a73ca6e6 100644
--- a/packages/share-theme/src/templates/page.ejs
+++ b/packages/share-theme/src/templates/page.ejs
@@ -124,6 +124,8 @@
<% } %>
</ul>
</div>
+ <% } else { %>
+ <div id="toc-pane"></div>
<% } %>
</div>
</div>
diff --git a/packages/trilium-core/src/share/content_renderer.spec.ts b/packages/trilium-core/src/share/content_renderer.spec.ts
index 3bd8c49f72..88e5cd44a5 100644
--- a/packages/trilium-core/src/share/content_renderer.spec.ts
+++ b/packages/trilium-core/src/share/content_renderer.spec.ts
@@ -368,6 +368,18 @@ describe("content_renderer", () => {
]);
});
+ it("keeps an empty table of contents pane, and its toggle out, for fewer than two headings", () => {
+ const shareRootNote = buildShareNote({
+ id: shareRoot.SHARE_ROOT_NOTE_ID,
+ children: [{ id: "oneHeading", content: `<h2>Only</h2><p>a</p>` }]
+ });
+
+ const page = parse(String(renderNoteContent(shareRootNote.getChildNotes()[0])));
+
+ expect(page.querySelector("#toc-pane")?.innerHTML).toBe("");
+ expect(page.querySelector("#toc-pane-toggle-button") === null).toBe(true);
+ });
+
it("prints only the OpenGraph tags that have a value, with an absolute image", () => {
const shareRootNote = buildShareNote({
id: shareRoot.SHARE_ROOT_NOTE_ID,