Build your personal knowledge base with Trilium Notes
TypeScript electronelectron-appknowledge-baseknowledge-graphknowledge-managementknowledge-management-graphlocal-firstnote-managmentnote-takernote-takingnotebooknotesnotes-apppersonal-knowledge-basepersonal-wikiscriptableself-hostedself-hostingwiki
feat(mobile/text): mark the Aa button as opening a row
Elian Dorand602530fc61e
diff --git a/apps/client/src/widgets/type_widgets/text/mobile_editor_toolbar.css b/apps/client/src/widgets/type_widgets/text/mobile_editor_toolbar.cssindex 1a8553df8d..9d0a23d09f 100644--- a/apps/client/src/widgets/type_widgets/text/mobile_editor_toolbar.css+++ b/apps/client/src/widgets/type_widgets/text/mobile_editor_toolbar.css@@ -253,6 +253,16 @@ body.mobile {}}+ .ck-toolbar__items > .ck.ck-button.ck-opens-row::after {+ content: "›";+ margin-inline-start: 1px;+ opacity: 0.6;+ }++ .ck-toolbar__items > .ck.ck-button.ck-opens-row:dir(rtl)::after {+ content: "‹";+ }+.ck-toolbar__items > .ck-context-toolbar-title {--ck-icon-size: 18px;display: flex;diff --git a/packages/ckeditor5/src/plugins/text_formatting_toolbar.spec.ts b/packages/ckeditor5/src/plugins/text_formatting_toolbar.spec.tsindex a03c9b28b7..db24acad12 100644--- a/packages/ckeditor5/src/plugins/text_formatting_toolbar.spec.ts+++ b/packages/ckeditor5/src/plugins/text_formatting_toolbar.spec.ts@@ -39,7 +39,8 @@ describe("TextFormattingToolbar", () => {const { editor, plugin } = await createEditor();const focus = vi.spyOn(editor.editing.view, "focus");const button = getToolbarButton(editor, 0);- expect(button).toMatchObject({ label: "Text formatting", icon: IconText, tooltip: true });+ // Marked as opening a row of its own, which the host draws a chevron for.+ expect(button).toMatchObject({ label: "Text formatting", icon: IconText, tooltip: true, class: "ck-opens-row" });expect(plugin.isActive).toBe(false);button.fire("execute");diff --git a/packages/ckeditor5/src/plugins/text_formatting_toolbar.ts b/packages/ckeditor5/src/plugins/text_formatting_toolbar.tsindex 8661321c3c..42e0489c06 100644--- a/packages/ckeditor5/src/plugins/text_formatting_toolbar.ts+++ b/packages/ckeditor5/src/plugins/text_formatting_toolbar.ts@@ -40,7 +40,8 @@ export default class TextFormattingToolbar extends Plugin {editor.ui.componentFactory.add("textFormatting", (locale) => {const button = new ButtonView(locale);- button.set({ label: t("Text formatting"), icon: IconText, tooltip: true });+ // The host marks a button that opens a row of its own (`ck-opens-row`).+ button.set({ label: t("Text formatting"), icon: IconText, tooltip: true, class: "ck-opens-row" });button.on("execute", () => this.setActive(true));return button;});