Skip to content

Build your personal knowledge base with Trilium Notes

fix(print): load the ~printCss stylesheet relative to the app base

Alex Castilloe110b3d70215
diff --git a/apps/client/src/print.spec.tsx b/apps/client/src/print.spec.tsx
index 2be45867fa..ea9f040aed 100644
--- a/apps/client/src/print.spec.tsx
+++ b/apps/client/src/print.spec.tsx
@@ -246,18 +246,20 @@ describe("loadCustomCss", () => {
const promise = loadCustomCss(note);
const codeLink = await vi.waitFor(() => {
- const link = document.head.querySelector<HTMLLinkElement>('link[href="/api/notes/css-code/download"]');
+ const link = document.head.querySelector<HTMLLinkElement>('link[href="api/notes/css-code/download"]');
expect(link).toBeTruthy();
return link;
});
- expect(document.head.querySelector('link[href="/api/notes/css-mime/download"]')).toBeTruthy();
+ expect(document.head.querySelector('link[href="api/notes/css-mime/download"]')).toBeTruthy();
await promise;
expect(warn).toHaveBeenCalledWith(expect.stringContaining("css-code"));
expect(warn).toHaveBeenCalledWith(expect.stringContaining("css-mime"));
warn.mockRestore();
expect(codeLink?.rel).toBe("stylesheet");
- expect(document.head.querySelector('link[href="/api/notes/css-text/download"]')).toBeNull();
+ // Relative, so it resolves against the app base when Trilium is served from a subpath
+ expect(codeLink?.getAttribute("href")).toBe("api/notes/css-code/download");
+ expect(document.head.querySelector('link[href="api/notes/css-text/download"]')).toBeNull();
});
});
diff --git a/apps/client/src/print.tsx b/apps/client/src/print.tsx
index 638834c482..e334fd7a20 100644
--- a/apps/client/src/print.tsx
+++ b/apps/client/src/print.tsx
@@ -258,7 +258,8 @@ export async function loadCustomCss(note: FNote) {
if (!printCssNote || (printCssNote.type !== "code" && printCssNote.mime !== "text/css")) continue;
const linkEl = document.createElement("link");
- linkEl.href = `/api/notes/${printCssNote.noteId}/download`;
+ // Relative like the fonts link above, so it resolves under a subpath deployment
+ linkEl.href = `api/notes/${printCssNote.noteId}/download`;
linkEl.rel = "stylesheet";
const promise = $.Deferred();