Skip to content

Build your personal knowledge base with Trilium Notes

client/text editor: add icons to the "Attach file" dropdown

Adorian Doranea70435eedb6
diff --git a/packages/ckeditor5/src/plugins/file_upload/file_upload_ui.spec.ts b/packages/ckeditor5/src/plugins/file_upload/file_upload_ui.spec.ts
index 079f1dcb85..5bec498ade 100644
--- a/packages/ckeditor5/src/plugins/file_upload/file_upload_ui.spec.ts
+++ b/packages/ckeditor5/src/plugins/file_upload/file_upload_ui.spec.ts
@@ -10,6 +10,8 @@ import {
Paragraph,
SplitButtonView
} from "ckeditor5";
+import bxLink from "boxicons/svg/regular/bx-link.svg?raw";
+import bxShapeSquare from "boxicons/svg/regular/bx-shape-square.svg?raw";
import { beforeEach, describe, expect, it, vi } from "vitest";
import { createTestEditor } from "../../../test/editor-kit.js";
@@ -93,11 +95,12 @@ describe("FileUploadUI", () => {
.mockImplementation(() => undefined);
const files = pickFiles();
- expect(items.map((item) => [ item.label, item.withText, item.allowMultipleFiles ]))
- .toEqual([
- [ "Attach file as a link", true, true ],
- [ "Attach and embed file", true, true ]
- ]);
+ expect(items.map((item) => [
+ item.label, item.icon, item.withText, item.allowMultipleFiles
+ ])).toEqual([
+ [ "Attach file as a link", bxLink, true, true ],
+ [ "Attach and embed file", bxShapeSquare, true, true ]
+ ]);
const [ linkItem, embedItem ] = items;
dropdown.render();
diff --git a/packages/ckeditor5/src/plugins/file_upload/file_upload_ui.ts b/packages/ckeditor5/src/plugins/file_upload/file_upload_ui.ts
index 4b0fdae3b7..faaad671c7 100644
--- a/packages/ckeditor5/src/plugins/file_upload/file_upload_ui.ts
+++ b/packages/ckeditor5/src/plugins/file_upload/file_upload_ui.ts
@@ -10,6 +10,8 @@ import {
type FileInputViewDoneEvent,
type Locale
} from "ckeditor5";
+import bxLink from "boxicons/svg/regular/bx-link.svg?raw";
+import bxShapeSquare from "boxicons/svg/regular/bx-shape-square.svg?raw";
import type { FileUploadOptions } from "./fileuploadcommand.js";
@@ -45,13 +47,15 @@ export default class FileUploadUI extends Plugin {
dropdownView.bind("isEnabled").to(command);
}
- const buttons = [ this.createListButton(locale, t("Attach file as a link"), {}) ];
+ const buttons = [
+ this.createListButton(locale, t("Attach file as a link"), bxLink, {})
+ ];
// Embedding goes wherever the "Include note" button can insert an include.
const includeCommand = editor.commands.get("insertIncludeNote");
if (includeCommand) {
const embedButton = this.createListButton(
- locale, t("Attach and embed file"), { asEmbed: true }
+ locale, t("Attach and embed file"), bxShapeSquare, { asEmbed: true }
);
embedButton.bind("isEnabled").to(includeCommand);
buttons.push(embedButton);
@@ -70,9 +74,14 @@ export default class FileUploadUI extends Plugin {
});
}
- private createListButton(locale: Locale, label: string, options: Partial<FileUploadOptions>) {
+ private createListButton(
+ locale: Locale,
+ label: string,
+ icon: string,
+ options: Partial<FileUploadOptions>
+ ) {
const button = new FileDialogListItemButtonView(locale);
- button.set({ label, withText: true, allowMultipleFiles: true });
+ button.set({ label, icon, withText: true, allowMultipleFiles: true });
this.attachOnDone(button, options);
return button;