Skip to content

Build your personal knowledge base with Trilium Notes

ci: pin the wrangler the deploy workflows install

Elian Doranecf3fd56711d
diff --git a/.github/actions/deploy-to-cloudflare-pages/action.yml b/.github/actions/deploy-to-cloudflare-pages/action.yml
index 9f0529f5a4..03ff4dca37 100644
--- a/.github/actions/deploy-to-cloudflare-pages/action.yml
+++ b/.github/actions/deploy-to-cloudflare-pages/action.yml
@@ -15,10 +15,12 @@ inputs:
runs:
using: composite
steps:
- # Install wrangler globally to avoid workspace issues
+ # Installed globally to avoid workspace issues, and at a fixed version so a
+ # production deploy cannot change under the repository. Renovate moves the
+ # pin (see customManagers in renovate.json).
- name: Install Wrangler
shell: bash
- run: npm install -g wrangler
+ run: npm install -g [email protected]
# Deploy using Wrangler (use pre-installed wrangler)
- name: Deploy to Cloudflare Pages
diff --git a/.github/workflows/cloudflare-preview.yml b/.github/workflows/cloudflare-preview.yml
index d24426f709..069e9e113b 100644
--- a/.github/workflows/cloudflare-preview.yml
+++ b/.github/workflows/cloudflare-preview.yml
@@ -111,10 +111,12 @@ jobs:
exit 1
fi
- # Install wrangler globally to avoid workspace issues
+ # Installed globally to avoid workspace issues, and at a fixed version:
+ # this job holds the Cloudflare token, so whatever npm resolves here runs
+ # beside it. Renovate moves the pin (see customManagers in renovate.json).
- name: Install Wrangler
shell: bash
- run: npm install -g wrangler
+ run: npm install -g [email protected]
- name: Deploy preview to Cloudflare Pages
uses: cloudflare/wrangler-action@ebbaa1584979971c8614a24965b4405ff95890e0 # v4.0.0
diff --git a/renovate.json b/renovate.json
index 8d788f78cc..91a67402f0 100644
--- a/renovate.json
+++ b/renovate.json
@@ -31,6 +31,20 @@
"nix": {
"enabled": true
},
+ "customManagers": [
+ {
+ "description": "The deploy workflows install wrangler globally instead of from the lockfile, so the version is pinned inline and Renovate moves the pin",
+ "customType": "regex",
+ "managerFilePatterns": [
+ "/^\\.github/(workflows|actions)/.+\\.ya?ml$/"
+ ],
+ "matchStrings": [
+ "npm install -g wrangler@(?<currentValue>\\S+)"
+ ],
+ "depNameTemplate": "wrangler",
+ "datasourceTemplate": "npm"
+ }
+ ],
"packageRules": [
{
"description": "Never auto-update the Android Gradle Plugin; it must track the installed Android Studio, not the latest release",