Skip to content

Build your personal knowledge base with Trilium Notes

test(codemirror): fire selectionchange after the selection moves, as browsers do

Claudefcd6d86d12c0
diff --git a/packages/codemirror/src/test/setup.ts b/packages/codemirror/src/test/setup.ts
new file mode 100644
index 0000000000..2bc123cd17
--- /dev/null
+++ b/packages/codemirror/src/test/setup.ts
@@ -0,0 +1,24 @@
+deferSelectionChange();
+
+/**
+ * Fires `selectionchange` after the code that moved the selection, as browsers do.
+ *
+ * happy-dom dispatches it from inside `Selection.collapse()`. CodeMirror moves the DOM selection
+ * during `EditorView.update()`, and its listener updates the view again, which throws
+ * "Calls to EditorView.update are not allowed while an update is in progress".
+ */
+function deferSelectionChange() {
+ const dispatch = document.dispatchEvent.bind(document);
+ // happy-dom's `dispatchEvent()` calls itself again for each event phase.
+ const deferred = new WeakSet<Event>();
+
+ document.dispatchEvent = (event: Event) => {
+ if (event.type !== "selectionchange" || deferred.has(event)) {
+ return dispatch(event);
+ }
+
+ deferred.add(event);
+ queueMicrotask(() => dispatch(event));
+ return true;
+ };
+}
diff --git a/packages/codemirror/tsconfig.lib.json b/packages/codemirror/tsconfig.lib.json
index 53a8df3b12..66b4baae21 100644
--- a/packages/codemirror/tsconfig.lib.json
+++ b/packages/codemirror/tsconfig.lib.json
@@ -36,6 +36,7 @@
"src/**/*.test.js",
"src/**/*.spec.js",
"src/**/*.test.jsx",
- "src/**/*.spec.jsx"
+ "src/**/*.spec.jsx",
+ "src/test/**"
]
}
diff --git a/packages/codemirror/vite.config.ts b/packages/codemirror/vite.config.ts
index 4932a471d7..c741473c1b 100644
--- a/packages/codemirror/vite.config.ts
+++ b/packages/codemirror/vite.config.ts
@@ -31,6 +31,7 @@ export default defineConfig(() => ({
watch: false,
globals: true,
environment: 'happy-dom',
+ setupFiles: ['./src/test/setup.ts'],
include: ['src/**/*.{test,spec}.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'],
reporters: [
'default',
@@ -45,7 +46,7 @@ export default defineConfig(() => ({
},
provider: 'v8',
include: ['src/**/*.{ts,tsx}'],
- exclude: ['**/*.{test,spec}.{ts,mts,cts,tsx,js,jsx}', '**/*.d.ts'],
+ exclude: ['**/*.{test,spec}.{ts,mts,cts,tsx,js,jsx}', '**/*.d.ts', 'src/test/**'],
// Codecov resolves an lcov `SF:` path by matching it against the repo's file list, so the
// package-relative paths istanbul emits by default (`src/index.ts`, relative to cwd) are
// ambiguous in this monorepo and get attributed to whichever package wins the match. Emit