Skip to content

"Vibe-Trading: Your Personal Trading Agent"

24.7 KB
Raw Blame
"""Mandate enforcement gate tests (SPEC.md Mandate Enforcement §3–§6).

Parametrized per limit: each case submits an order breaching exactly one limit
and asserts a refusal carrying the breach; one in-mandate case asserts the order
forwards through to the underlying mock MCP tool. Universe market-cap/liquidity
floors are exercised by monkeypatching the loader-backed helpers (no network).
"""

from __future__ import annotations

import json
import threading
from datetime import datetime, timedelta, timezone
from pathlib import Path
from typing import Any

import pytest

import src.live.enforcement as enforcement
import src.live.order_guard as order_guard
import src.live.paths as paths
from src.live.enforcement import (
    BREACH_KIND_INSTRUMENT,
    BREACH_KIND_QUANTITATIVE,
    BREACH_KIND_UNIVERSE,
    OrderIntent,
    check_mandate,
)
from src.live.mandate.model import (
    MANDATE_SCHEMA_VERSION,
    AssetClass,
    ConsentMeta,
    HardCaps,
    InstrumentType,
    Mandate,
    UniverseConstraint,
)
from src.tools.mcp import MCPRemoteToolSpec
from tests import robinhood_mcp_helpers as rh


# --------------------------------------------------------------------------- #
# Fixtures + mock MCP adapter                                                  #
# --------------------------------------------------------------------------- #


@pytest.fixture
def live_runtime(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> Path:
    """Point the live root at a tmp dir so tests never touch the real store."""
    monkeypatch.setattr(paths, "get_runtime_root", lambda: tmp_path)
    return tmp_path


class _MockAdapter:
    """Minimal MCPServerAdapter stand-in with recording call_tool."""

    def __init__(self, *, positions: Any, balance: Any) -> None:
        self.server_name = "robinhood"
        self._positions = positions
        self._balance = balance
        self.call_records: list[dict[str, Any]] = []
        self.order_calls: list[dict[str, Any]] = []

    def call_tool(self, remote_name: str, arguments: dict, *, local_name: str | None = None) -> dict:
        self.call_records.append({"remote": remote_name, "arguments": arguments})
        if remote_name == "get_equity_positions":
            return rh.positions(self._positions)
        if remote_name == "get_portfolio":
            return rh.portfolio(total_value=str(self._balance))
        # The order placement itself (super().execute forwards here).
        self.order_calls.append({"remote": remote_name, "arguments": arguments})
        return {"status": "ok", "order_id": "rh_test_1", "state": "accepted"}


def _spec() -> MCPRemoteToolSpec:
    return MCPRemoteToolSpec(
        server_name="robinhood",
        remote_name="place_equity_order",
        local_name="mcp_robinhood_place_equity_order",
        description="Place an order.",
        parameters={
            "type": "object",
            "properties": {
                "symbol": {"type": "string"},
                "side": {"type": "string"},
                "instrument_type": {"type": "string"},
                "notional_usd": {"type": "number"},
                "quantity": {"type": "number"},
            },
            "additionalProperties": True,
        },
    )


def _mandate(expires_in_days: int = 30, **caps_overrides: Any) -> Mandate:
    created = datetime.now(timezone.utc)
    caps = {
        "account_funding_usd": 5000.0,
        "max_order_notional_usd": 750.0,
        "max_total_exposure_usd": 5000.0,
        "max_leverage": 1.0,
        "allowed_instruments": (InstrumentType.EQUITY, InstrumentType.ETF),
        "max_trades_per_day": 5,
    }
    caps.update(caps_overrides)
    return Mandate(
        schema_version=MANDATE_SCHEMA_VERSION,
        hard_caps=HardCaps(**caps),
        universe=UniverseConstraint(
            asset_classes=(AssetClass.US_EQUITY, AssetClass.US_ETF),
            min_market_cap_usd=None,
            min_avg_daily_volume_usd=None,
            exclude_symbols=("GME",),
        ),
        consent=ConsentMeta(
            created_at=created.isoformat(),
            consent_token_sha256="deadbeef",
            broker="robinhood",
            account_ref="acct_ref_xyz",
            expires_at=(created + timedelta(days=expires_in_days)).isoformat(),
        ),
    )


def _write_mandate(live_runtime: Path, mandate: Mandate) -> None:
    broker = live_runtime / "live" / "robinhood"
    broker.mkdir(parents=True, exist_ok=True)
    payload = {
        "schema_version": mandate.schema_version,
        "hard_caps": {
            "account_funding_usd": mandate.hard_caps.account_funding_usd,
            "max_order_notional_usd": mandate.hard_caps.max_order_notional_usd,
            "max_total_exposure_usd": mandate.hard_caps.max_total_exposure_usd,
            "max_leverage": mandate.hard_caps.max_leverage,
            "allowed_instruments": [i.value for i in mandate.hard_caps.allowed_instruments],
            "max_trades_per_day": mandate.hard_caps.max_trades_per_day,
        },
        "universe": {
            "asset_classes": [a.value for a in mandate.universe.asset_classes],
            "min_market_cap_usd": mandate.universe.min_market_cap_usd,
            "min_avg_daily_volume_usd": mandate.universe.min_avg_daily_volume_usd,
            "exclude_symbols": list(mandate.universe.exclude_symbols),
        },
        "consent": {
            "created_at": mandate.consent.created_at,
            "consent_token_sha256": mandate.consent.consent_token_sha256,
            "broker": mandate.consent.broker,
            "account_ref": mandate.consent.account_ref,
            "expires_at": mandate.consent.expires_at,
        },
    }
    (broker / "mandate.json").write_text(json.dumps(payload), encoding="utf-8")


# --------------------------------------------------------------------------- #
# check_mandate — pure decision function, parametrized per limit               #
# --------------------------------------------------------------------------- #


def _intent(**overrides: Any) -> OrderIntent:
    base = {
        "symbol": "AAPL",
        "side": "buy",
        "notional_usd": 100.0,
        "quantity": None,
        "instrument_type": InstrumentType.EQUITY,
    }
    base.update(overrides)
    return OrderIntent(**base)


def _check(intent: OrderIntent, mandate: Mandate, *, positions=None, daily_count=0):
    return check_mandate(
        mandate,
        intent,
        positions if positions is not None else [],
        {"equity": 5000.0},
        broker="robinhood",
        remote_tool="place_equity_order",
        daily_count=daily_count,
    )


def test_in_mandate_order_passes() -> None:
    assert _check(_intent(notional_usd=100.0), _mandate()) is None


@pytest.mark.parametrize(
    "intent_kwargs, mandate_kwargs, positions, daily_count, expect_limit, expect_kind",
    [
        # Exclude-list (universe, structural).
        (dict(symbol="GME"), {}, [], 0, "exclude_symbols", BREACH_KIND_UNIVERSE),
        # Disallowed instrument (instrument, structural).
        (dict(instrument_type=InstrumentType.CRYPTO), {}, [], 0, "allowed_instruments", BREACH_KIND_INSTRUMENT),
        # Per-order notional (quantitative).
        (dict(notional_usd=1000.0), {}, [], 0, "max_order_notional_usd", BREACH_KIND_QUANTITATIVE),
        # Total exposure (quantitative): existing $4900 + $200 buy > $5000 cap.
        (dict(notional_usd=200.0), {}, [{"market_value": 4900.0}], 0, "max_total_exposure_usd", BREACH_KIND_QUANTITATIVE),
        # Leverage (quantitative): tiny funding makes 1x leverage breach.
        (dict(notional_usd=600.0), dict(account_funding_usd=500.0, max_total_exposure_usd=1e9), [], 0, "max_leverage", BREACH_KIND_QUANTITATIVE),
        # Daily count (quantitative): already at the cap.
        (dict(notional_usd=100.0), {}, [], 5, "max_trades_per_day", BREACH_KIND_QUANTITATIVE),
    ],
)
def test_each_limit_breach(
    intent_kwargs, mandate_kwargs, positions, daily_count, expect_limit, expect_kind
) -> None:
    breach = _check(
        _intent(**intent_kwargs),
        _mandate(**mandate_kwargs),
        positions=positions,
        daily_count=daily_count,
    )
    assert breach is not None
    assert breach.limit == expect_limit
    assert breach.kind == expect_kind


def test_unreadable_positions_fail_closed() -> None:
    # A position with no parseable value → total-exposure check denies.
    breach = _check(_intent(notional_usd=100.0), _mandate(), positions=[{"junk": 1}])
    assert breach is not None
    assert breach.limit == "max_total_exposure_usd"


@pytest.mark.parametrize("side", ["buy", "sell"])
def test_share_notional_gate_refuses_options_even_when_permitted(side: str) -> None:
    """An instrument allowance does not supply an options risk calculation."""
    breach = _check(
        _intent(instrument_type=InstrumentType.OPTION, side=side),
        _mandate(allowed_instruments=(InstrumentType.OPTION,)),
    )
    assert breach is not None
    assert breach.kind == BREACH_KIND_INSTRUMENT
    assert breach.limit == "options_unsupported"


@pytest.mark.parametrize(
    "row",
    [
        # Toss / Dhan / KIS shape: quantity + current_price.
        {"symbol": "AAPL", "quantity": 10, "current_price": 25.0},
        # Zerodha / Shoonya shape: quantity + ltp.
        {"symbol": "AAPL", "quantity": 10, "ltp": 25.0},
        # Futu shape: already a market value, spelled market_val.
        {"code": "AAPL", "qty": 10, "market_val": 250.0},
    ],
)
def test_direct_sdk_position_shapes_are_priced_not_fail_closed(row: dict) -> None:
    """Connector-shaped rows that only carry current_price/ltp/market_val must
    price correctly instead of tripping the fail-closed exposure denial every
    other order would then hit regardless of size (#position-pricing-gap)."""
    breach = _check(_intent(notional_usd=100.0), _mandate(), positions=[row])
    assert breach is None


def test_universe_market_cap_floor_denies_when_below(monkeypatch: pytest.MonkeyPatch) -> None:
    monkeypatch.setattr(enforcement, "market_cap_usd", lambda s, ac: 1.0e8)
    mandate = _mandate()
    mandate = Mandate(
        schema_version=mandate.schema_version,
        hard_caps=mandate.hard_caps,
        universe=UniverseConstraint(
            asset_classes=mandate.universe.asset_classes,
            min_market_cap_usd=1.0e9,  # floor above the stubbed cap
            min_avg_daily_volume_usd=None,
            exclude_symbols=mandate.universe.exclude_symbols,
        ),
        consent=mandate.consent,
    )
    breach = _check(_intent(notional_usd=100.0), mandate)
    assert breach is not None
    assert breach.limit == "min_market_cap_usd"
    assert breach.kind == BREACH_KIND_UNIVERSE


def test_universe_market_cap_missing_data_fail_closed(monkeypatch: pytest.MonkeyPatch) -> None:
    monkeypatch.setattr(enforcement, "market_cap_usd", lambda s, ac: None)
    mandate = _mandate()
    mandate = Mandate(
        schema_version=mandate.schema_version,
        hard_caps=mandate.hard_caps,
        universe=UniverseConstraint(
            asset_classes=mandate.universe.asset_classes,
            min_market_cap_usd=1.0e9,
            min_avg_daily_volume_usd=None,
            exclude_symbols=mandate.universe.exclude_symbols,
        ),
        consent=mandate.consent,
    )
    breach = _check(_intent(notional_usd=100.0), mandate)
    assert breach is not None
    assert breach.limit == "min_market_cap_usd"  # no data → DENY


# --------------------------------------------------------------------------- #
# LiveOrderGuardTool — end to end through the gate                             #
# --------------------------------------------------------------------------- #


def _guard(adapter, **kwargs):
    return order_guard.LiveOrderGuardTool(adapter, _spec(), broker="robinhood", session_id="s1", **kwargs)


def test_guard_forwards_in_mandate_order(live_runtime: Path) -> None:
    _write_mandate(live_runtime, _mandate())
    adapter = _MockAdapter(positions=[], balance=5000.0)
    guard = _guard(adapter)
    out = json.loads(guard.execute(symbol="AAPL", side="buy", instrument_type="equity", notional_usd=100.0))
    assert out.get("status") == "ok"
    assert out.get("order_id") == "rh_test_1"
    assert len(adapter.order_calls) == 1
    # Daily counter incremented exactly once on confirmed forward.
    counter = json.loads((live_runtime / "live" / "robinhood" / "trade_counter.json").read_text())
    assert counter["count"] == 1


@pytest.mark.parametrize("type_key", ["type", "instrument_type", "asset_class", "instrument_class"])
def test_mcp_equity_entry_cannot_forward_an_option(
    live_runtime: Path, type_key: str
) -> None:
    """Reject option aliases on the real gate path before any order is sent."""
    _write_mandate(live_runtime, _mandate(allowed_instruments=(InstrumentType.OPTION,)))
    adapter = _MockAdapter(positions=[], balance=5000.0)
    result = json.loads(
        _guard(adapter).execute(
            symbol="AAPL", side="buy", notional_usd=100.0, **{type_key: "option"}
        )
    )
    assert result["status"] == "blocked"
    assert adapter.order_calls == []
    assert not (live_runtime / "live" / "robinhood" / "trade_counter.json").exists()


def test_mcp_guard_serializes_the_daily_cap_with_submission(live_runtime: Path) -> None:
    """MCP placements share the same one-permit transaction as SDK orders."""
    _write_mandate(live_runtime, _mandate(max_trades_per_day=1))
    entered = threading.Event()
    release = threading.Event()

    class _BlockingAdapter(_MockAdapter):
        def call_tool(self, remote_name, arguments, *, local_name=None):
            if remote_name in {"get_equity_positions", "get_portfolio"}:
                return super().call_tool(remote_name, arguments, local_name=local_name)
            self.order_calls.append({"remote": remote_name, "arguments": arguments})
            entered.set()
            assert release.wait(timeout=5)
            return {"status": "ok", "order_id": "rh_test_1", "state": "accepted"}

    adapter = _BlockingAdapter(positions=[], balance=5000.0)
    guard = _guard(adapter)
    outputs: list[dict[str, Any]] = []

    def place() -> None:
        outputs.append(
            json.loads(
                guard.execute(
                    symbol="AAPL",
                    side="buy",
                    instrument_type="equity",
                    notional_usd=100.0,
                )
            )
        )

    first = threading.Thread(target=place)
    second = threading.Thread(target=place)
    first.start()
    assert entered.wait(timeout=2)
    second.start()
    second.join(timeout=1)
    release.set()
    first.join(timeout=5)
    second.join(timeout=5)

    assert len(adapter.order_calls) == 1
    assert sorted(output["status"] for output in outputs) == ["blocked", "ok"]


def test_guard_blocks_over_notional_with_breach(live_runtime: Path) -> None:
    _write_mandate(live_runtime, _mandate())
    adapter = _MockAdapter(positions=[], balance=5000.0)
    guard = _guard(adapter)
    out = json.loads(guard.execute(symbol="AAPL", side="buy", instrument_type="equity", notional_usd=5000.0))
    assert out["status"] == "blocked"
    assert out["decision"] == "pause_for_reauth"
    assert out["requires_reauthorization"] is True
    assert out["breach"]["limit"] == "max_order_notional_usd"
    assert adapter.order_calls == []  # never forwarded


def test_guard_blocks_opening_short_above_gross_exposure_cap(live_runtime: Path) -> None:
    """A sell from zero opens short exposure; it does not reduce risk."""
    _write_mandate(
        live_runtime,
        _mandate(
            account_funding_usd=1000.0,
            max_order_notional_usd=1000.0,
            max_total_exposure_usd=500.0,
            max_leverage=10.0,
        ),
    )
    adapter = _MockAdapter(positions=[], balance=1000.0)
    guard = _guard(adapter)

    out = json.loads(
        guard.execute(
            symbol="AAPL",
            side="sell",
            instrument_type="equity",
            notional_usd=600.0,
        )
    )

    assert out["status"] == "blocked"
    assert out["breach"]["limit"] == "max_total_exposure_usd"
    assert out["breach"]["attempted_value"] == 600.0
    assert adapter.order_calls == []


def test_mixed_book_uses_gross_not_net_exposure() -> None:
    mandate = _mandate(
        account_funding_usd=1000.0,
        max_order_notional_usd=1000.0,
        max_total_exposure_usd=1000.0,
        max_leverage=10.0,
    )
    positions = [
        {"symbol": "MSFT", "quantity": 10.0, "price": 60.0},
        {"symbol": "TSLA", "quantity": -10.0, "price": 50.0},
    ]

    breach = _check(
        _intent(symbol="AAPL", side="buy", notional_usd=100.0),
        mandate,
        positions=positions,
    )

    assert breach is not None
    assert breach.limit == "max_total_exposure_usd"
    assert breach.attempted_value == 1200.0


def test_sell_that_only_reduces_long_exposure_stays_allowed() -> None:
    mandate = _mandate(
        account_funding_usd=1000.0,
        max_order_notional_usd=1000.0,
        max_total_exposure_usd=500.0,
        max_leverage=10.0,
    )
    positions = [{"symbol": "AAPL", "quantity": 10.0, "price": 60.0}]

    assert (
        _check(
            _intent(symbol="AAPL", side="sell", notional_usd=200.0),
            mandate,
            positions=positions,
        )
        is None
    )


def test_guard_structural_breach_denies_no_reauth(live_runtime: Path) -> None:
    _write_mandate(live_runtime, _mandate())
    adapter = _MockAdapter(positions=[], balance=5000.0)
    guard = _guard(adapter)
    out = json.loads(guard.execute(symbol="GME", side="buy", instrument_type="equity", notional_usd=100.0))
    assert out["status"] == "blocked"
    assert out["decision"] == "deny"
    assert out["requires_reauthorization"] is False
    assert out["breach"]["kind"] == BREACH_KIND_UNIVERSE
    assert adapter.order_calls == []


def test_guard_no_mandate_denies(live_runtime: Path) -> None:
    adapter = _MockAdapter(positions=[], balance=5000.0)
    guard = _guard(adapter)
    out = json.loads(guard.execute(symbol="AAPL", side="buy", instrument_type="equity", notional_usd=100.0))
    assert out["status"] == "blocked"
    assert out["decision"] == "deny"
    assert adapter.order_calls == []


def test_guard_expired_mandate_denies_with_reauth(live_runtime: Path) -> None:
    _write_mandate(live_runtime, _mandate(expires_in_days=-1))
    adapter = _MockAdapter(positions=[], balance=5000.0)
    guard = _guard(adapter)
    out = json.loads(guard.execute(symbol="AAPL", side="buy", instrument_type="equity", notional_usd=100.0))
    assert out["status"] == "blocked"
    assert out["requires_reauthorization"] is True
    assert adapter.order_calls == []


def test_guard_unparseable_intent_denies(live_runtime: Path) -> None:
    _write_mandate(live_runtime, _mandate())
    adapter = _MockAdapter(positions=[], balance=5000.0)
    guard = _guard(adapter)
    # Missing side → extractor returns None → DENY.
    out = json.loads(guard.execute(symbol="AAPL", instrument_type="equity", notional_usd=100.0))
    assert out["status"] == "blocked"
    assert adapter.order_calls == []


def test_guard_repeatable_is_false() -> None:
    assert order_guard.LiveOrderGuardTool.repeatable is False
    assert order_guard.LiveOrderGuardTool.is_readonly is False


# --------------------------------------------------------------------------- #
# H2 — failed broker forward must not consume a count or audit "accepted"      #
# --------------------------------------------------------------------------- #


class _FailingForwardAdapter:
    """Adapter whose order placement returns an ERROR envelope (no raise).

    Mirrors ``MCPServerAdapter.call_tool``: broker/network failure is reported as
    a ``{"status": "error", ...}`` envelope, not an exception.
    """

    def __init__(self) -> None:
        self.server_name = "robinhood"
        self.order_calls: list[dict[str, Any]] = []

    def call_tool(self, remote_name: str, arguments: dict, *, local_name: str | None = None) -> dict:
        if remote_name == "get_equity_positions":
            return rh.positions([])
        if remote_name == "get_portfolio":
            return rh.portfolio()
        # The order placement fails at the broker.
        self.order_calls.append({"remote": remote_name, "arguments": arguments})
        return {"status": "error", "error": "broker rejected", "error_type": "BrokerError"}


def _read_audit_records(live_runtime: Path) -> list[dict[str, Any]]:
    ledger = live_runtime / "live" / "audit.jsonl"
    if not ledger.is_file():
        return []
    return [json.loads(line) for line in ledger.read_text().splitlines() if line.strip()]


def test_failed_forward_does_not_consume_count_or_audit_accepted(live_runtime: Path) -> None:
    """H2: an in-mandate order whose forward errors must NOT consume a daily
    count and must NOT write an ``accepted`` record."""
    _write_mandate(live_runtime, _mandate())
    adapter = _FailingForwardAdapter()
    guard = _guard(adapter)

    out = json.loads(
        guard.execute(symbol="AAPL", side="buy", instrument_type="equity", notional_usd=100.0)
    )

    # The order WAS forwarded (it passed the gate) but the broker errored.
    assert len(adapter.order_calls) == 1
    assert out.get("status") == "error"

    # No daily count consumed.
    counter_path = live_runtime / "live" / "robinhood" / "trade_counter.json"
    assert not counter_path.is_file()

    # No "accepted" record; exactly one error record instead.
    records = _read_audit_records(live_runtime)
    assert all(r["outcome"] != "accepted" for r in records)
    accepted = [r for r in records if r["kind"] == "order_placed"]
    assert accepted == []
    errored = [r for r in records if r["outcome"] == "error"]
    assert len(errored) == 1
    assert errored[0]["kind"] == "order_rejected"


def test_successful_forward_consumes_count_and_audits_accepted(live_runtime: Path) -> None:
    """Counterpart to H2: a non-error forward consumes exactly one count and
    writes one ``order_placed``/``accepted`` record carrying ``live_action``."""
    _write_mandate(live_runtime, _mandate())
    adapter = _MockAdapter(positions=[], balance=5000.0)
    guard = _guard(adapter)

    out = json.loads(
        guard.execute(symbol="AAPL", side="buy", instrument_type="equity", notional_usd=100.0)
    )
    assert out.get("status") == "ok"
    counter = json.loads((live_runtime / "live" / "robinhood" / "trade_counter.json").read_text())
    assert counter["count"] == 1
    accepted = [r for r in _read_audit_records(live_runtime) if r["kind"] == "order_placed"]
    assert len(accepted) == 1
    # H5: the redacted audit record is embedded under the frozen marker key.
    assert out[order_guard.LIVE_ACTION_RESULT_KEY]["kind"] == "order_placed"


# --------------------------------------------------------------------------- #
# H3 — notional+quantity ambiguity bypass is closed                           #
# --------------------------------------------------------------------------- #


class _QuoteAdapter:
    """Adapter with a working ``get_equity_quotes`` read tool returning a fixed price."""

    def __init__(self, *, price: float, positions: Any = (), balance: Any = 5000.0) -> None:
        self.server_name = "robinhood"
        self._price = price
        self._positions = list(positions)
        self._balance = balance
        self.order_calls: list[dict[str, Any]] = []
        self.quote_calls: list[dict[str, Any]] = []

    def call_tool(self, remote_name: str, arguments: dict, *, local_name: str | None = None) -> dict:
        if remote_name == "get_equity_positions":
            return rh.positions(self._positions)
        if remote_name == "get_portfolio":
            return rh.portfolio(total_value=str(self._balance))
        if remote_name == "get_equity_quotes":
            self.quote_calls.append({"arguments": arguments})
            return {"status": "ok", "symbol": arguments.get("symbol"), "price": self._price}
        self.order_calls.append({"remote": remote_name, "arguments": arguments})
        return {"status": "ok", "order_id": "rh_test_1", "state": "accepted"}


def test_notional_quantity_bypass_is_closed(live_runtime: Path) -> None:
    """H3: an order carrying a tiny notional but a huge quantity is enforced on
    the quantity-implied notional, so it is NOT waved through."""
    _write_mandate(live_runtime, _mandate())  # max_order_notional_usd = 750
    # 100000 shares * $10 = $1,000,000 implied notional, well over the cap; the
    # explicit $10 notional must not be the value enforced.
    adapter = _QuoteAdapter(price=10.0)
    guard = _guard(adapter)

    out = json.loads(
        guard.execute(
            symbol="AAPL", side="buy", instrument_type="equity",
            notional_usd=10.0, quantity=100000.0,
        )
    )
    assert out["status"] == "blocked"
    assert out["breach"]["limit"] == "max_order_notional_usd"
    assert out["breach"]["attempted_value"] == 1_000_000.0
    assert adapter.order_calls == []  # never forwarded
    assert adapter.quote_calls  # broker quote tool was consulted