Skip to content

"Vibe-Trading: Your Personal Trading Agent"

fix(shadow): honor the configured runtime root (#1017)

Haozhe Wu0805f0afd645
diff --git a/agent/src/shadow_account/storage.py b/agent/src/shadow_account/storage.py
index 9a4d4087a..34a35d6f9 100644
--- a/agent/src/shadow_account/storage.py
+++ b/agent/src/shadow_account/storage.py
@@ -1,9 +1,9 @@
-"""Shadow Account persistence (~/.vibe-trading/shadow_accounts/).
+"""Shadow Account persistence under the configured runtime root.
Layout:
- ~/.vibe-trading/shadow_accounts/<shadow_id>.json ShadowProfile
- ~/.vibe-trading/shadow_runs/<shadow_id>/ backtest run dir
- ~/.vibe-trading/shadow_reports/<shadow_id>.pdf rendered report
+ <runtime-root>/shadow_accounts/<shadow_id>.json ShadowProfile
+ <runtime-root>/shadow_runs/<shadow_id>/ backtest run dir
+ <runtime-root>/shadow_reports/<shadow_id>.pdf rendered report
"""
from __future__ import annotations
@@ -15,12 +15,13 @@ from datetime import datetime, timezone
from pathlib import Path
from typing import Any
+from src.config.paths import get_runtime_root
from src.shadow_account.models import ShadowProfile, ShadowRule
def _root() -> Path:
"""Return the Shadow Account root directory (auto-created)."""
- root = Path.home() / ".vibe-trading"
+ root = get_runtime_root()
root.mkdir(parents=True, exist_ok=True)
return root
diff --git a/agent/tests/test_runner_env.py b/agent/tests/test_runner_env.py
index f616005cd..f4c239ab8 100644
--- a/agent/tests/test_runner_env.py
+++ b/agent/tests/test_runner_env.py
@@ -115,14 +115,17 @@ def test_backtest_runtime_env_adds_exact_current_run_root(
]
-def test_execute_keeps_real_home_run_valid_after_home_is_sandboxed(
[email protected]("run_bucket", ("runs", "shadow_runs"))
+def test_execute_keeps_runtime_run_valid_after_home_is_sandboxed(
monkeypatch,
tmp_path: Path,
+ run_bucket: str,
) -> None:
real_home = tmp_path / "real-home"
- run_dir = real_home / ".vibe-trading" / "runs" / "run-1"
+ run_dir = real_home / ".vibe-trading" / run_bucket / "run-1"
run_dir.mkdir(parents=True)
monkeypatch.setenv("HOME", str(real_home))
+ monkeypatch.delenv("VIBE_TRADING_HOME", raising=False)
monkeypatch.delenv("VIBE_TRADING_ALLOWED_RUN_ROOTS", raising=False)
entry = _probe_entry(
diff --git a/agent/tests/test_user_state_paths.py b/agent/tests/test_user_state_paths.py
index 037076390..973264a28 100644
--- a/agent/tests/test_user_state_paths.py
+++ b/agent/tests/test_user_state_paths.py
@@ -80,6 +80,24 @@ def test_state_dir_helpers_live_under_runtime_root(
assert get_uploads_dir() == root / "uploads"
+def test_shadow_account_dirs_live_under_runtime_root(
+ monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+ from src.shadow_account.storage import profiles_dir, reports_dir, runs_dir
+ from src.tools.path_utils import _default_run_roots
+
+ root = tmp_path / "state-root"
+ monkeypatch.setenv("VIBE_TRADING_HOME", str(root))
+
+ assert profiles_dir() == root / "shadow_accounts"
+ assert reports_dir() == root / "shadow_reports"
+ shadow_run = runs_dir("shadow_test")
+ assert shadow_run == root / "shadow_runs" / "shadow_test"
+ assert shadow_run.parent.resolve() in {
+ candidate.resolve() for candidate in _default_run_roots()
+ }
+
+
def test_legacy_cli_constants_derive_from_runtime_root() -> None:
from cli import _legacy
from src.config import paths